Page MenuHomePhorge
Differential D25083

Remarkup: simplify the way "internal links" could be identified
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 10:08.
Tags
None
Referenced Files
F2162439: D25083.id370.diff
Thu, Apr 25, 10:49
F2162438: D25083.id369.diff
Thu, Apr 25, 10:49
F2162434: D25083.id368.diff
Thu, Apr 25, 10:49
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Wed, Apr 24, 21:17
Unknown Object (File)
Mon, Apr 15, 11:32
Unknown Object (File)
Thu, Apr 11, 07:17
Unknown Object (File)
Thu, Apr 11, 03:47
View All Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15182: Simplify the way "internal links" are identified
Summary

This modification should not change anything logically.

Introduce a couple of methods (without using it) to identify
internal links, in terms of:

  • anchors
  • relative URLS
  • absolute URLs that do not point to the internal base URI

https://we.phorge.it/T15182

Identifying these case could be useful to decide to apply
further logics in the future, out of the scope of this patch.

Closes T15182

Test Plan
  • Verify that nothing has changed logically

Diff Detail

Repository
rP Phorge
Branch
T15161-remarkup-internal-links-refactor-child-apply
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php:82XHP16TODO Comment
Advicesrc/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php:122XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 158
Build 158: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 23 2023, 10:08
Owners added a reviewer: O1: Blessed Committers.Mar 23 2023, 10:08
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 23 2023, 10:08
Harbormaster completed remote builds in B156: Diff 368.Mar 23 2023, 10:08
valerio.bozzolan requested review of this revision.Mar 23 2023, 10:08
valerio.bozzolan edited the summary of this revision. (Show Details)Mar 23 2023, 10:09
valerio.bozzolan added a task: T15182: Simplify the way "internal links" are identified.
valerio.bozzolan removed a task: T15161: Internal resources should avoid to become external links, as default.
IMPORTANT: First, Land this: D25082
valerio.bozzolan mentioned this in T15182: Simplify the way "internal links" are identified.Mar 23 2023, 10:11
valerio.bozzolan updated this revision to Diff 369.Mar 23 2023, 10:23
valerio.bozzolan added a task: T15161: Internal resources should avoid to become external links, as default.

fix relative cases

Harbormaster completed remote builds in B157: Diff 369.Mar 23 2023, 10:23
valerio.bozzolan updated this revision to Diff 370.Mar 23 2023, 10:25

fix typo

Harbormaster completed remote builds in B158: Diff 370.Mar 23 2023, 10:25
valerio.bozzolan removed a task: T15161: Internal resources should avoid to become external links, as default.Mar 23 2023, 10:50
valerio.bozzolan mentioned this in D25084: Remarkup: avoid to open internal pages as external links (as default).
valerio.bozzolan added a parent revision: D25084: Remarkup: avoid to open internal pages as external links (as default).Mar 26 2023, 17:03
valerio.bozzolan added a comment.Apr 7 2023, 21:15

Squashed here:

D25118: Remarkup: make less internal links open in new tabs

valerio.bozzolan abandoned this revision.Apr 7 2023, 21:16

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
infrastructure/
markup/
markuprule/
14 lines1%
Loading...
O1: Blessed Committers
14 lines0%
Loading...
O1: Blessed Committers
50 lines2%
Loading...
O1: Blessed Committers

Diff 370

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0