Page MenuHomePhorge
Differential D25082

Remarkup: minor refactor to identify anchor and relative URIs
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 09:20.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 25, 08:24
Unknown Object (File)
Thu, Jul 25, 08:23
Unknown Object (File)
Thu, Jul 25, 08:22
Unknown Object (File)
Thu, Jul 25, 08:22
Unknown Object (File)
Wed, Jul 24, 14:58
Unknown Object (File)
Wed, Jul 24, 00:50
Unknown Object (File)
Wed, Jul 24, 00:50
Unknown Object (File)
Wed, Jul 24, 00:50
View All Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15182: Simplify the way "internal links" are identified
Summary

This modification should not change anything logically.

This change simplifies these checks:

  • identify an anchor
  • identify a relative URI

https://we.phorge.it/T15182

The methods are introduced in PhutilRemarkupRule since that
is the parent class of these children classes:

  • PhutilRemarkupDocumentLinkRule
  • PhutilRemarkupHyperlinkRule

Ref T15182

Test Plan
  • Just check that nothing has been changed logically

Diff Detail

Repository
rP Phorge
Branch
T15161-remarkup-internal-links-refactor
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 155
Build 155: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 23 2023, 09:20
Owners added a reviewer: O1: Blessed Committers.Mar 23 2023, 09:20
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 23 2023, 09:20
valerio.bozzolan requested review of this revision.Mar 23 2023, 09:20
Harbormaster completed remote builds in B153: Diff 365.Mar 23 2023, 09:20
valerio.bozzolan removed a task: T15161: Internal resources should avoid to become external links, as default.Mar 23 2023, 09:21
valerio.bozzolan updated this revision to Diff 366.Mar 23 2023, 09:22
valerio.bozzolan added a task: T15161: Internal resources should avoid to become external links, as default.

run celerity to make lint happy

Harbormaster completed remote builds in B154: Diff 366.Mar 23 2023, 09:22
valerio.bozzolan updated this revision to Diff 367.Mar 23 2023, 09:24

improve inline doc a bit

Harbormaster completed remote builds in B155: Diff 367.Mar 23 2023, 09:24
valerio.bozzolan mentioned this in D25083: Remarkup: simplify the way "internal links" could be identified.Mar 23 2023, 10:08
valerio.bozzolan mentioned this in T15182: Simplify the way "internal links" are identified.Mar 23 2023, 10:11
valerio.bozzolan removed a task: T15161: Internal resources should avoid to become external links, as default.Mar 23 2023, 10:17
valerio.bozzolan abandoned this revision.Apr 7 2023, 21:16

Squashed here:

D25118: Remarkup: make less internal links open in new tabs

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
resources/
celerity/
100%
Loading...
O1: Blessed Committers
src/
infrastructure/
markup/
markuprule/
4 lines1%
Loading...
O1: Blessed Committers
24 lines3%
Loading...
O1: Blessed Committers

Diff 367

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0