(I agree that internally, the Herald rule should be saved as a Global Task-based. And I agree that it should be easily added and edited from the Workboard. I think that, in the future, this still need the Project Tag to be saved internally - as a kind of Object rule - so that, in the future, it will allow a more efficient query to find all global Herald rules without a Tag + all global Herald rules that are assigned to a Tag where that Tag is IN the list of Task's Tags.)

@rraval Could you or someone else verify that a project that is made visible only to Administrators still shows up when a user opens the search selection list on the Subscribers field? And is this considered to be a bug or a feature? Of course i can set up a new Task for this if that makes sense.

Is this related to Phorge itself?

I tested locally following the test plan and I've found this edit very useful.

arc lint

Rebased on master, ran bin/celerity map to resolve merge conflict.

Wow! Thank you so much.

Thank you.

I'm not assigned to this since I'm not really active. I was just curious. Feel free to give it a try and add more notes.

In T15047#3542, @avivey wrote:

I personally hate the $a = []; style, at least for empty arrays - I find it not-explicit enough.

Looks like that's because PhabricatorBadgesSearchConduitAPIMethod extends PhabricatorSearchEngineAPIMethod, and TransactionSearchConduitAPIMethod extends ConduitAPIMethod directly...

In T15047#3538, @valerio.bozzolan wrote:

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document:

https://we.phorge.it/book/contrib/article/php_coding_standards/

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document:

Thank you for this question.

Here a stupid spoiler of this. Milestone before:

Some explanations:

avoid same variable storing different things

Please feel free to re-open, adding something in the description :)

I'm unsure about my lines since they do not fit in this week. But I'm not bold enough to create a dedicated week, since this was not promoted to stable.

(If I remember correctly the rules we set for rP, you should be able to arc land all of these now)

@dcog please set your images as visible to everybody (I cannot see them) thanks

@kretov.d note that the provided images should be set to visible for everyone (now I cannot see them). Thanks

No, it's not supported yet
but i plan to work on it in near future

Render spoiler:

• rephrase also the other sentence with tip from avivey

I've done my best to rephrase that. Thanks @avivey

• rephrase sentence with tip from avivey

Thanks for this information. I'm trying to integrate that in the documentation since it's not that obvious

This is just a small change but if you want a spoiler, here how it looks like:

• mention "Administrator" and not just "User" (not just end-users)

@sicenul by the way note that F195188 is a restricted file and nobody can see it

Ok

Maybe I need to reset the config so that the "From" email address does match the SMTP username. Any idea how to do this?

You have to set the metamta.default-address preference - it's one of the locked ones so you have to set it from the cmd line with config set ...