Note that above two patches only allow passing ./bin/storage upgrade but not to run Phorge. That would be a followup once these initial patches got in.

Aug 30 2024, 14:41 · PHP 8 support

aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25814: Fix implicitly nullable parameter declarations for PHP 8.4.

Aug 30 2024, 14:40 · PHP 8 support

aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25813: Fix implicitly nullable parameter declarations for PHP 8.4.

Aug 30 2024, 14:37 · PHP 8 support

aklapper created T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.

Aug 30 2024, 14:29 · PHP 8 support

Aug 29 2024

revi added projects to T15934: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:16: Deprecation Notice, PHP 8 support, Arcanist.

Aug 29 2024, 15:34 · Arcanist, PHP 8 support, Deprecation Notice

Aug 26 2024

aklapper added a revision to T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php: D25811: Fix PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.

Aug 26 2024, 21:40 · PHP 8 support

aklapper added a revision to T15930: PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus: D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

Aug 26 2024, 21:32 · PHP 8 support

aklapper created T15930: PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

Aug 26 2024, 18:49 · PHP 8 support

aklapper created T15929: PHP 8.1 "strlen(null)" exception in PhutilOAuth1Future.php.

Aug 26 2024, 18:49 · PHP 8 support

Aug 23 2024

aklapper added a revision to T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests: D25801: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode.

Aug 23 2024, 11:14 · PHP 8 support

aklapper added a revision to T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests: D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.

Aug 23 2024, 11:08 · PHP 8 support

aklapper created T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests.

Aug 23 2024, 11:02 · PHP 8 support

Aug 22 2024

aklapper closed T15399: PHP 8.2 strlen() null issues when arc-diffing as Resolved by committing rP3c5e43cccbf0: Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery.

Aug 22 2024, 09:17 · Clarification Needed, PHP 8 support

aklapper closed T15399: PHP 8.2 strlen() null issues when arc-diffing, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Aug 22 2024, 09:17 · PHP 8 support

Aug 19 2024

aklapper added a revision to T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated: D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

Aug 19 2024, 19:49 · Deprecation Notice, PHP 8 support

aklapper renamed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated from PHP 8.3: ldap_connect() call signature deprecated to PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Aug 19 2024, 18:48 · Deprecation Notice, PHP 8 support

aklapper added a comment to T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Confirming my suspicion on PHP 8.3 (while I'm still struggling to successfully bind locally).
As far as I can tell (well, I'm running into ldap_bind(): Unable to bind to server: Can't contact LDAP server after the patch above while my local LDAP server is running but that's nothing new triggered by the patch above), the patch above seems to work.

Aug 19 2024, 18:48 · Deprecation Notice, PHP 8 support

valerio.bozzolan added a comment to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

The root cause seems an array(null) here in the base case:

Aug 19 2024, 12:43 · PHP 8 support

Aug 15 2024

aklapper added a revision to T15399: PHP 8.2 strlen() null issues when arc-diffing: D25779: Fix PHP 8.1 "strlen(null)" exception in DiffusionGitRawDiffQuery.

Aug 15 2024, 12:33 · Clarification Needed, PHP 8 support

aklapper added a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15399: PHP 8.2 strlen() null issues when arc-diffing.

Aug 15 2024, 12:22 · PHP 8 support

aklapper added a parent task for T15399: PHP 8.2 strlen() null issues when arc-diffing: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.

Aug 15 2024, 12:22 · Clarification Needed, PHP 8 support

Aug 11 2024

aklapper added a revision to T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider: D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.

Aug 11 2024, 21:00 · PHP 8 support

aklapper created T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider.

Aug 11 2024, 20:57 · PHP 8 support

aklapper closed T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Aug 11 2024, 20:36 · PHP 8 support

aklapper closed T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController as Resolved by committing rP58f1c83a5ac5: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.

Aug 11 2024, 20:36 · PHP 8 support

aklapper added a comment to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.

Not sure what "similar working links" means... Something like https://we.phorge.it/diviner/find/?name=PhutilSafeHTML ?

Aug 11 2024, 16:17 · PHP 8 support

aklapper renamed T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef from PHP 8.1 "strlen(null)" exception in DivinerAtomRef to PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Aug 11 2024, 15:38 · PHP 8 support

aklapper added a revision to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef: D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Aug 11 2024, 15:29 · PHP 8 support

aklapper added a comment to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Urgh. In calling https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/query/DivinerAtomQuery.php$340 , $this->titles is an array which has a length of 1, with its only member being null. Sounds like there's already something fishy before.

Aug 11 2024, 15:28 · PHP 8 support

valerio.bozzolan added a comment to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.

Where I can find similar working links? I've tried generating Diviner books for both Arcanist and Phorge but http://phorge.localhost/diviner/find/?name=JX.Stratcom is still giving me 404

Aug 11 2024, 15:10 · PHP 8 support

aklapper created T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Aug 11 2024, 15:01 · PHP 8 support

aklapper added a revision to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController: D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.

Aug 11 2024, 15:00 · PHP 8 support

aklapper created T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.

Aug 11 2024, 14:57 · PHP 8 support

Aug 7 2024

aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Aug 7 2024, 11:57 · PHP 8 support

aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction as Resolved by committing rP88225b99f2fc: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.

Aug 7 2024, 11:57 · PHP 8 support

Aug 5 2024

aklapper added a revision to T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction: D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.

Aug 5 2024, 11:43 · PHP 8 support

aklapper created T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.

Aug 5 2024, 11:38 · PHP 8 support

Aug 4 2024

aklapper closed T15810: Exception when "limit" (page size) API parameter is float, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Aug 4 2024, 10:16 · PHP 8 support

aklapper closed T15810: Exception when "limit" (page size) API parameter is float as Resolved by committing rP1cc04fb83cd5: Explicitly cast "limit" (page size) API parameter to int.

Aug 4 2024, 10:16 · PHP 8 support

Aug 2 2024

aklapper closed T15900: PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Aug 2 2024, 19:27 · PHP 8 support

aklapper closed T15900: PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView as Resolved by committing rP81ffe4f8b152: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView.

Aug 2 2024, 19:27 · PHP 8 support

aklapper added a revision to T15900: PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView: D25761: Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView.

Aug 2 2024, 13:35 · PHP 8 support

aklapper created T15900: PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView.

Aug 2 2024, 13:32 · PHP 8 support

aklapper closed T15835: Misc "Return type is not covariant" errors for method Iterator::key() as Resolved by committing rPa110aa471e98: Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative….

Aug 2 2024, 09:44 · PHP 8 support

Jul 27 2024

aklapper closed T15893: PHP 8.1 "strlen(null)" exception for LDAP login without password, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Jul 27 2024, 04:47 · PHP 8 support

aklapper closed T15893: PHP 8.1 "strlen(null)" exception for LDAP login without password as Resolved by committing rP7909f6a91937: Fix PHP 8.1 "strlen(null)" exception on LDAP login without password.

Jul 27 2024, 04:47 · PHP 8 support

Jul 26 2024

aklapper updated the task description for T15893: PHP 8.1 "strlen(null)" exception for LDAP login without password.

Jul 26 2024, 14:50 · PHP 8 support

aklapper added a revision to T15893: PHP 8.1 "strlen(null)" exception for LDAP login without password: D25748: Fix PHP 8.1 "strlen(null)" exception on LDAP login without password.

Jul 26 2024, 14:46 · PHP 8 support

aklapper created T15893: PHP 8.1 "strlen(null)" exception for LDAP login without password.

Jul 26 2024, 14:43 · PHP 8 support

Jul 11 2024

aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Jul 11 2024, 05:25 · PHP 8 support

aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView as Resolved by committing rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

Jul 11 2024, 05:25 · PHP 8 support

Jul 9 2024

aklapper added a revision to T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView: D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

Jul 9 2024, 22:23 · PHP 8 support

aklapper created T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView.

Jul 9 2024, 22:10 · PHP 8 support

Jul 2 2024

aklapper added a revision to T15835: Misc "Return type is not covariant" errors for method Iterator::key(): D25711: Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()".

Jul 2 2024, 13:04 · PHP 8 support

Jun 25 2024

aklapper closed T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Jun 25 2024, 08:13 · PHP 8 support

aklapper closed T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest as Resolved by committing rP5a9cf81ae592: Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in….

Jun 25 2024, 08:13 · PHP 8 support

Jun 24 2024

aklapper added a revision to T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest: D25699: Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine.

Jun 24 2024, 13:15 · PHP 8 support

aklapper renamed T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest from PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment data in AphrontRequest to PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest.

Jun 24 2024, 13:12 · PHP 8 support

aklapper updated the task description for T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest.

Jun 24 2024, 13:10 · PHP 8 support

aklapper created T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest.

Jun 24 2024, 13:04 · PHP 8 support

Jun 19 2024

revi added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283.

$ git show
commit d519f75dfdee61bb109468aa708c47f53f3e5128 (HEAD -> stable, origin/stable)
Author: Mark Jervelund <EMAIL-REDACTED>
Date:   Mon Feb 12 11:51:24 2024 +0100

Jun 19 2024, 14:05 · PHP 8 support, Deprecation Notice

aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283.

@revi: Could you please double-check and confirm that the line 144 in <phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php is
'n' => $this->escapeToken($repository->getRepositorySlug()),
in your installation? Thanks in advance!

Jun 19 2024, 13:52 · PHP 8 support, Deprecation Notice

Jun 11 2024

aklapper closed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Jun 11 2024, 20:52 · PHP 8 support

aklapper closed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block as Resolved by committing rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.

Jun 11 2024, 20:52 · PHP 8 support

aklapper renamed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block from PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has single @task block to PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.

Jun 11 2024, 05:55 · PHP 8 support