Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Portal
ClosedPublic

Authored by aklapper on Jun 5 2024, 11:44.
Tags
None
Referenced Files
F2985648: D25681.1740075948.diff
Wed, Feb 19, 18:25
F2977854: D25681.1739654074.diff
Fri, Feb 14, 21:14
F2950466: D25681.1738780022.diff
Tue, Feb 4, 18:27
F2939223: D25681.1738031508.diff
Mon, Jan 27, 02:31
F2938207: D25681.1737979903.diff
Sun, Jan 26, 12:11
F2933584: D25681.1737776445.diff
Fri, Jan 24, 03:40
F2933583: D25681.1737776437.diff
Fri, Jan 24, 03:40
F2933499: D25681.1737771880.diff
Fri, Jan 24, 02:24

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:34]

Closes T15847

Test Plan

Go to /portal/edit/form/default/, set a name and click Create Portal.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable