Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in DivinerFindController
ClosedPublic

Authored by aklapper on Aug 11 2024, 15:00.
Tags
None
Referenced Files
F2979528: D25768.1739860324.diff
Mon, Feb 17, 06:32
F2977771: D25768.1739653313.diff
Fri, Feb 14, 21:01
F2977768: D25768.1739653310.diff
Fri, Feb 14, 21:01
F2977726: D25768.1739649493.diff
Fri, Feb 14, 19:58
F2977694: D25768.1739645029.diff
Fri, Feb 14, 18:43
F2977351: D25768.1739636917.diff
Fri, Feb 14, 16:28
F2977350: D25768.1739636915.diff
Fri, Feb 14, 16:28
F2977349: D25768.1739636913.diff
Fri, Feb 14, 16:28

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerFindController.php:40]

Closes T15910

Test Plan

Go to this (or any other Diviner Find URL not passing a type URI parameter): now it works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML

Go to this (or any other Diviner Find URL passing a type URI parameter): it still works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable