Paths

Table of Contentst

Differential D25821

Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier
ClosedPublic
Actions

Authored by aklapper on Sat, Sep 7, 07:33.

Tags

None

Referenced Files

	F2506990: D25821.1726991224.diff
	Sat, Sep 21, 07:47

	F2506989: D25821.1726991199.diff
	Sat, Sep 21, 07:46

	F2506988: D25821.1726991197.diff
	Sat, Sep 21, 07:46

	F2506982: D25821.1726990625.diff
	Sat, Sep 21, 07:37

	F2504909: D25821.1726916229.diff
	Fri, Sep 20, 10:57

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15936: PHP8.1 strlen(): Passing null to parameter is deprecated

Commits

rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/srv/phorge/phorge/src/applications/diffusion/query/DiffusionCommitQuery.php:779]

Closes T15936

Test Plan

Unclear.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sat, Sep 7, 07:33

Owners added a reviewer: O1: Blessed Committers.Sat, Sep 7, 07:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Sep 7, 07:33

aklapper requested review of this revision.Sat, Sep 7, 07:33

Harbormaster completed remote builds in B1585: Diff 2461.Sat, Sep 7, 07:33

sgtm

This revision is now accepted and ready to land.Fri, Sep 20, 02:00

Closed by commit rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier. · Explain WhyFri, Sep 20, 06:49

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP9cd62bdcc432: Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

3 lines

O1: Blessed Committers

Diff 2484

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...