Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier
ClosedPublic

Authored by aklapper on Sep 7 2024, 07:33.
Tags
None
Referenced Files
F3686794: D25821.1745586392.diff
Thu, Apr 24, 13:06
F3681741: D25821.1745560451.diff
Thu, Apr 24, 05:54
F3678944: D25821.1745550264.diff
Thu, Apr 24, 03:04
F3673706: D25821.1745477708.diff
Wed, Apr 23, 06:55
F3670559: D25821.1745468246.diff
Wed, Apr 23, 04:17
F3388072: D25821.1744444166.diff
Fri, Apr 11, 07:49
F3387831: D25821.1744442185.diff
Fri, Apr 11, 07:16
F3369060: D25821.1744212874.diff
Tue, Apr 8, 15:34

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/srv/phorge/phorge/src/applications/diffusion/query/DiffusionCommitQuery.php:779]

Closes T15936

Test Plan

Unclear.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable