Accepting but please wait other comments - 2 weeks?

...but don't follow my tip, since the above thing forces to a specific class and it's different than the old and already-proposed behavior

I'm personally OK with this, premising that Phorge never used assert(), as far as I can see.

I agree with @waldyrious and I just want to add that, if somebody wants to add a button (and restore multi-line), here is probably the code:

Also without that comment in 1942. Feel free to omit. It's self-explaining.

The root cause seems an array(null) here in the base case:

Thanks for this prototype but unfortunately this approach has the problem that it's verticalized on Maniphest and it should really not be expanded for Phriction or to any other component that may have a description and may suffer the same thing.

Fix a bug, grow another bug 🌈 https://t.me/phabricator/889

The solution was to take direct children project and call $child->setParentProjectPHID($my_parent_phid).

This was more tricky than expected. Basically we "just" need to call PhabricatorProjectsMembershipIndexEngineExtension method materialize() on the parent.

Finally in my Phorge I can kill these milestones \o/

Thanks. Maybe it happens only to me but if my content is very short I see an UX regression

After only 30 hours of work. Wow. asd

Any patch is welcome :)

Thanks. Tested and it works! no regressions.

Exactly. Like I said probably you will find interesting things debugging $old_text. I guess it's empty. That's probably our root cause. What do you think about?

Maybe interesting, there is this different non-deprecated API:

Double-slam accept

In your opinion, why is the current code not working? I mean, it should do exactly that, checking the text before, and the text after, so, to only mention newly-introduced mentions.

Only one fix remains. I set "unclear" in the test plan accordingly to T15536. If you still want to merge, just:

git rebase master

rebase

feeex typo (theenks aklapper)

Where I can find similar working links? I've tried generating Diviner books for both Arcanist and Phorge but http://phorge.localhost/diviner/find/?name=JX.Stratcom is still giving me 404

Just for the glory of the archive. I've tested this feature in production before landing.

I guess this is the time. Feel free to land as usual with

Well, I doubt we can dig more than this.

@aklapper I see. What do you think about D25301#15795 ?

OK. Full immersion mode 🌈

I'm trying to reproduce, creating a repository, stopping phlog, and pushing, and starting and immediately randomly stopping phlog.

At the moment we have a multi-thread command existence checker, and it early dies if a command is not existing.

I wonder if "Workboard Triggers" may do the job here.

be based on unit tests

OK thanks

remove unuseful newline