Do not re-subscribe users who are mentioned in a task description and are not task subscribers when editing an existing task description.
They should not forcefully get re-subscribed as these users were not "newly" mentioned (again).
Closes T15915
Differential D25775
Do not re-subscribe @mentions when editing task description aklapper on Aug 13 2024, 20:12. Authored by
Details
Do not re-subscribe users who are mentioned in a task description and are not task subscribers when editing an existing task description. Closes T15915
Diff Detail
Event TimelineComment Actions Eh, there is a trade-off: Editing the description of an existing task to add a @mention will not add this newly mentioned user as a task subscriber anymore. I guess there could be even more code to compare/parse the old description text and the new description text for new @mentions not existing in the old description, or we could just accept this corner case for the time being? Comment Actions Thanks for this prototype but unfortunately this approach has the problem that it's verticalized on Maniphest and it should really not be expanded for Phriction or to any other component that may have a description and may suffer the same thing. More understanding on the root cause is needed. Probably the root cause is "just" that getOldValue() returns an empty string. In that case we should probably at least understand what object is that (sub-class of PhabricatorTransactionRemarkupChange?) and we probably we need something like a generateOldValue() or something similar. More discussion needed. Thanks. Comment Actions Per https://we.phorge.it/rP65634781b44fb6a5e182c896705d44e04490ba76 ,
That commit deprecated getRemarkupBlocks() still called in PhabricatorAuditTransaction and in the foreach loop in PhabricatorApplicationTransaction which does ->setOldValue(null). |