Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()
ClosedPublic
Actions

Authored by aklapper on Aug 15 2024, 14:03.

Tags

None

Referenced Files

	F3313117: D25781.1743214676.diff
	Fri, Mar 28, 02:17

	F3304902: D25781.1743107488.diff
	Wed, Mar 26, 20:31

	F3296961: D25781.1742980125.diff
	Tue, Mar 25, 09:08

	F3292241: D25781.1742888799.diff
	Mon, Mar 24, 07:46

	F3290042: D25781.1742858177.diff
	Sun, Mar 23, 23:16

	F3254888: D25781.1742488015.diff
	Wed, Mar 19, 16:26

	F3218718: D25781.1741736918.diff
	Mon, Mar 10, 23:48

	F3058672: D25781.1741009887.diff
	Sun, Mar 2, 13:51

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()

Summary

Add an additional check that $empty_exception is not null before try to throw it.

Test Plan

Read the previous code; run static code analysis.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 15 2024, 14:03

Owners added a reviewer: O1: Blessed Committers.Aug 15 2024, 14:03

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 15 2024, 14:03

aklapper requested review of this revision.Aug 15 2024, 14:03

Harbormaster completed remote builds in B1531: Diff 2374.Aug 15 2024, 14:03

sgtm

This revision is now accepted and ready to land.Aug 15 2024, 15:16

Closed by commit rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage(). · Explain WhyAug 15 2024, 18:24

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPedb2175a9bb5: Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage().

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

query/

DiffusionCommitQuery.php

2 lines

O1: Blessed Committers

Diff 2375

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Fix PhabricatorEmptyQueryException handling in DiffusionCommitQuery::loadPage()ClosedPublicActions