Page MenuHomePhorge

Fix $boot_length comparison in PhagePHPAgentBootloader
ClosedPublic

Authored by aklapper on Aug 11 2024, 20:48.
Tags
None
Referenced Files
F3502720: D25770.1744797167.diff
Tue, Apr 15, 09:52
F3393217: D25770.1744495487.diff
Fri, Apr 11, 22:04
F3390377: D25770.1744466360.diff
Fri, Apr 11, 13:59
F3387562: D25770.1744438249.diff
Fri, Apr 11, 06:10
F3371827: D25770.1744246044.diff
Wed, Apr 9, 00:47
F3368533: D25770.1744209607.diff
Tue, Apr 8, 14:40
F3368450: D25770.1744209179.diff
Tue, Apr 8, 14:32
F3362346: D25770.1744079390.diff
Mon, Apr 7, 02:29

Details

Summary

$boot_length = strlen($boot_sequence->toString()) returns an int and strlen() expects a string as a parameter. Thus calling if (strlen($boot_length) > 8192) afterwards to get the string length of an integer makes no sense.

Test Plan

Read the code.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable