Page MenuHomePhorge

Fix $boot_length comparison in PhagePHPAgentBootloader
ClosedPublic

Authored by aklapper on Aug 11 2024, 20:48.
Tags
None
Referenced Files
F3336539: D25770.1743576231.diff
Tue, Apr 1, 06:43
F3329946: D25770.1743482248.diff
Mon, Mar 31, 04:37
F3328906: D25770.1743465110.diff
Sun, Mar 30, 23:51
F3328044: D25770.1743449436.diff
Sun, Mar 30, 19:30
F3327326: D25770.1743436797.diff
Sun, Mar 30, 15:59
F3325142: D25770.1743409919.diff
Sun, Mar 30, 08:31
F3321573: D25770.1743356519.diff
Sat, Mar 29, 17:41
F3294883: D25770.1742946362.diff
Mon, Mar 24, 23:46

Details

Summary

$boot_length = strlen($boot_sequence->toString()) returns an int and strlen() expects a string as a parameter. Thus calling if (strlen($boot_length) > 8192) afterwards to get the string length of an integer makes no sense.

Test Plan

Read the code.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable