Page MenuHomePhorge

Fix return value of PhutilTestCase::tryTestCaseMap()
ClosedPublic

Authored by aklapper on Aug 17 2024, 22:15.
Tags
None
Referenced Files
F3022640: D25791.1740794516.diff
Fri, Feb 28, 02:01
F3020691: D25791.1740785576.diff
Thu, Feb 27, 23:32
F3020689: D25791.1740785573.diff
Thu, Feb 27, 23:32
F3020686: D25791.1740785567.diff
Thu, Feb 27, 23:32
F3002003: D25791.1740445179.diff
Mon, Feb 24, 00:59
F3002002: D25791.1740445178.diff
Mon, Feb 24, 00:59
F2987686: D25791.1740117198.diff
Thu, Feb 20, 05:53
F2981879: D25791.1739940649.diff
Tue, Feb 18, 04:50

Details

Summary

PhutilTestCase::tryTestCases() returns void. Thus PhutilTestCase::tryTestCaseMap() should behave the same way as PhutilTestCase::assertException(): return void.

Test Plan

Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable