Fix return value of PhutilTestCase::tryTestCaseMap()
ClosedPublic
Actions

Authored by aklapper on Aug 17 2024, 22:15.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC0d5f4379709d: Fix return value of PhutilTestCase::tryTestCaseMap()

Summary

PhutilTestCase::tryTestCases() returns void. Thus PhutilTestCase::tryTestCaseMap() should behave the same way as PhutilTestCase::assertException(): return void.

Test Plan

Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 17 2024, 22:15

Owners added a reviewer: O1: Blessed Committers.Aug 17 2024, 22:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 17 2024, 22:15

aklapper requested review of this revision.Aug 17 2024, 22:15

Harbormaster completed remote builds in B1544: Diff 2389.Aug 17 2024, 22:15

sgtm

This revision is now accepted and ready to land.Aug 17 2024, 22:44

Closed by commit rARC0d5f4379709d: Fix return value of PhutilTestCase::tryTestCaseMap(). · Explain WhyAug 18 2024, 07:42

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC0d5f4379709d: Fix return value of PhutilTestCase::tryTestCaseMap().

Revision Contents
Changeset List

Path

Size

Packages

src/

unit/

engine/

phutil/

PhutilTestCase.php

2 lines

O1: Blessed Committers

Diff 2390

View Options

src/unit/engine/phutil/PhutilTestCase.php

Fix return value of PhutilTestCase::tryTestCaseMap()ClosedPublicActions