\o/

Also, this mashes up Diffusion and Repositories to add confusion

I don't get the code.
src/applications/diffusion/controller/DiffusionIdentityViewController.php (note the View in its name) includes stuff like
$edit_uri = $this->getApplicationURI("identity/edit/{$id}/") defining ->setName(pht('Edit Identity')) (note the Edit here).
Also, this mashes up Diffusion and Repositories to add confusion (DiffusionIdentityEditController calls PhabricatorRepositoryIdentityEditEngine?).
I think I give up.

I was honestly not aware of that. Interesting. Thanks!

DO you know about arc browse?

In T15129#11054, @Cigaryno wrote:

.. and vice versa

In T15129#10661, @aklapper wrote:

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

It's important to restrict the ability to create Diffusion IDs.

In T15491#10740, @speck wrote:

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

In T15491#10740, @speck wrote:

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

Assuming this as Resolved but feel free to attach other details in the question itself and reopen :)

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

It turns out that this is a duplicate:
T15443: Add Diffusion policy capability "Can Edit and View Identities"

Our currently running version is git commit 1ba5c8c26095 from 2023-04-20, so that change should already be included. In fact, I can see the --encoding utf8 argument to hg in various logs.

Oh sorry I love to randomly rename things :D

No, your edit is not correct. The same happens in search, as I indicated in the description:

or craft a query for Diffusion commits, specifying X as author

So if after following my instructions you go to /diffusion/commit/query/all/, you see all of the commits with the author field correctly displayed. If, however, you proceed to editing a query and you select user X as author, you get the "old state".

Let's try to reduce the surface

But, they identities probably should be editable only for:

• people who can edit the repository (people who administer it)
• you, if the email matches yours (since you somehow pushed in the repository)

Uh thanks. Interesting. Yeah probably with considerations under Security probably.

Done.

Ah sorry for this bug, please visit the files and set Public (I cannot see them)

Ah, sorry. I'll create the ticket in a minute.

(As a member of Trusted Contributors, you can use the "Create Task" button to directly file tickets in Maniphest. The "Ponder first" approach is/was mostly intended to keep non-community-members from flooding the task list).

Could you check whether your install is running with this change? https://secure.phabricator.com/D21676

From the exception

STDERR
waiting for lock on working directory of /var/repo/8 held by process '112297' on host 'ec6149cd0a0b/f000037a'

It sounds like another hg process is operating on that repo at the time.

Again @amit I know you have other things to do :) Can you just try to manually apply this patch?

Hi @amit can you please confirm if D25204 fixes your problem? I tested it locally and it works, but having a double-check from you would be super-nice. Thanks!

Actually this issue blocks loading most (all?) icons; also the favicon of the site.

I think the future() I linked for literally calls ./bin/repository update ..., and sets the timeout on that.
That invokes the future() you found, which calls hg pull, and adds another timeout.

I'm not sure where the buildUpdateFuture() function you linked to is used, but in the stack trace that I see (see previous comment), the future is buit inside executeMercurialUpdate(…), which calls $repository->getRemoteCommandFuture(), which boils down to the call newRemoteCommandEngine(…)->newFuture(); in the repo base class.

In the repo management panel, I see this error:

Raw Error
Error updating working copy: Command failed with error #255!
COMMAND
hg --config ui.ssh=/var/www/phorge/phorge/bin/ssh-connect pull -- '********'

Looking at the diff, I think this timeout only applies to Drydock cloning the repository for its builds, not for "observing" repositories - and Drydock might not support Mercurial anyway.

I'm interested in discovering if that alert disappears if we disable the URL of type "No I/O". Example, disabling this:

Thanks! I created a Task with the Diffusion tag for it.

Thanks for this detailed report :) You are now a Trusted Contributors and you can create Tasks. Feel free to keep this question opened, or elevate as Task under Diffusion.
Thank you so much for this interesting report