In T15161#4416, @avivey wrote:I agree with this, but I think we should let this wait for broader discussion - there maybe good counter-arguments.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 19 2023
Jun 19 2023
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.
Jun 15 2023
Jun 15 2023
May 29 2023
May 29 2023
valerio.bozzolan added a comment to T15106: "Upload file" in remarkup text fields should attach by default .
Another use case: Drag & Drop on a new Object description, even if the Object is not already created, should attach by default to it.
May 27 2023
May 27 2023
_____________________________________
( I think having Remarkup rules being )
( able to spawn their documentation )
( section would be great, yup )
-------------------------------------
o . .
o / `. .' "
o .---. < > < > .---.
o | \ \ - ~ ~ - / / |
_____ ..-~ ~-..-~
| | \~~~\.' `./~~~/
--------- \__/ \__/
.' O \ / / \ "
(_____, `._.' | } \/~~~/
`----. / } | / \__/
`-. | / | / `. ,~~|
~-.__| /_ - ~ ^| /- _ `..-'
| / | / ~-. `-. _ _ _
|_____| |_____| ~ - . _ _ _ _ _>
I think a more generic solution here is "Make the Remarkup Help Page Extensible", so that Remarkup rules can add their own sections (Possibly under the Guides application, if it still exists?)
May 24 2023
May 24 2023
May 23 2023
May 23 2023
valerio.bozzolan moved T15182: Simplify the way "internal links" are identified from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
May 22 2023
May 22 2023
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.
Premising I am trying to make few variations to the current behavior implemented by Evan
You are the best, thanks for this tip
Thanks a lot!
By the way you are now a Trusted Contributors :) Thanks
Ah nice thanks @smith - feel free to move that as Answer
You can do it using HTML tags and literal line breaks, like this:
11 | 22 |
AA | B B |
But you probably already know that, given that the task you quoted was closed by committing this revision.
(<br> doesn't work here, but I think it should, even if it's ignored in plain Remarkup.)
May 18 2023
May 18 2023
There’s possibly other reasons why they left it undocumented but it was a while back and I haven’t gone digging in the upstream for details.
Historically the reason why these aren’t documented is that they originally required installing 3rd party tools on the server. They were documented in tasks upstream but there was a security issue found with using graphviz so at that time out of caution they reimplemented figlet and cowsay in php rather than passing arguments to a 3rd party executable. After the implementation change documentation was never updated.
Discovered from D25142
May 9 2023
May 9 2023
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing: Remarkup.
(Sorry for the ping poing, re-adding Remarkup hoping to be useful since this seems an issue in Remarkup itself, but last word to avivey)
avivey removed a project from T15203: Remarkup: allow to mention a Slowvote (without embedding): Slowvote.
valerio.bozzolan added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.
Premising that very probably a fix there would not 100% resolve that upstream issue but surely this deserves a fix :D
May 4 2023
May 4 2023
valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
valerio.bozzolan updated the task description for T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
valerio.bozzolan updated the task description for T15106: "Upload file" in remarkup text fields should attach by default .
May 3 2023
May 3 2023
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
May 1 2023
May 1 2023
Apr 29 2023
Apr 29 2023
valerio.bozzolan updated subscribers of T15293: Try to avoid message: Transaction (of type "core:file") has no effect.
Hi @Dylsss thanks again for your improvement. Have you any idea about why that message happens?
valerio.bozzolan triaged T15293: Try to avoid message: Transaction (of type "core:file") has no effect as Normal priority.
Apr 26 2023
Apr 26 2023
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
valerio.bozzolan closed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!, a subtask of T15106: "Upload file" in remarkup text fields should attach by default , as Resolved.
Apr 25 2023
Apr 25 2023
valerio.bozzolan updated the task description for T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!.
valerio.bozzolan renamed T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()! from Error: Empty ID passed to JX.$()! to RemarkupMetadata.js - Error: Empty ID passed to JX.$()!.
valerio.bozzolan triaged T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()! as High priority.
Apr 24 2023
Apr 24 2023
(Ignored unrelated build failures, see fix: D25133)
Restricted Repository Identity closed D25052: Add and use new RemarkupMetadata class.
Rebased and applied suggested changes
In D25052#4102, @Dylsss wrote:I reverted to a previous commit (36dba82224de1b64bf571ebae5e944ce8a02e7c2) and still get this error when uploading from the remarkup toolbar upload button. So I don't think it is related to this change.
Apr 23 2023
Apr 23 2023
In D25052#4034, @valerio.bozzolan wrote:WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean
Apr 21 2023
Apr 21 2023
In D25052#4020, @MCPCN wrote:I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.
Apr 20 2023
Apr 20 2023
WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean
Amazing @Dylsss you have green light here. Feel free to land.
In D25052#4020, @MCPCN wrote:I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.
Using the upload button has different behaviour to drag&drop - files uploaded using the upload button need to be manually attached to the object which is a bit of a faff (not sure if there's a way to automatically do this?):
I'm the author of Q49 - just confirmed that this patch appears to work in our environment (latest release of Phabricator) - files uploaded to Maniphest tasks are accessible to others.
valerio.bozzolan triaged T15106: "Upload file" in remarkup text fields should attach by default as Normal priority.
I start triaging this to Normal priority since this problem creates situations that don't happen with many proprietary weird alternatives like Trello, Asana etc., where their Drag & Drop "just works" since their file are always visible to all members and so it's considered as "working" for their end-users (well, thanks to the fact that Trello etc. have a terrible permission management system, thousand years back from Phorge, and they really have no concept of "single file permission", and so they win easy in these confrontations where the user expects something basic and it doesn't happen as default by some of our "attach to something" corner cases).
Apr 19 2023
Apr 19 2023
Bukkit added a project to T15245: Continue bulleted/numbered list during new line: Feature Requests.
Apr 12 2023
Apr 12 2023
Apr 7 2023
Apr 7 2023
Apr 6 2023
Apr 6 2023
valerio.bozzolan edited projects for T15106: "Upload file" in remarkup text fields should attach by default , added: Files; removed Files (archived).
avivey edited projects for T15075: Add support for @link in diviner, added: Diviner; removed Diviner (archived).
Apr 5 2023
Apr 5 2023
Apr 4 2023
Apr 4 2023
valerio.bozzolan removed a revision from T15132: Support monospaced links in remarkup: D25110: Fix "Search" Application description.
valerio.bozzolan added a parent task for T15132: Support monospaced links in remarkup: T15230: Fix Search Application description.
(I just added in the description the keyword "backtick" so I can easily find this)
Apr 2 2023
Apr 2 2023
Mar 29 2023
Mar 29 2023
valerio.bozzolan closed T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine as Wontfix.
By mistake I thought it was a formal global configuration but it seems it's not. So, I don't think it deserves a dedicated documentation.
Mar 28 2023
Mar 28 2023
Mar 27 2023
Mar 27 2023
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
valerio.bozzolan renamed T15203: Remarkup: allow to mention a Slowvote (without embedding) from Slowvote Remarkup: add support for layout link to Remarkup: allow to mention a Slowvote (without embedding).
valerio.bozzolan updated the task description for T15203: Remarkup: allow to mention a Slowvote (without embedding).
valerio.bozzolan triaged T15203: Remarkup: allow to mention a Slowvote (without embedding) as Wishlist priority.
Cigaryno added a project to T15106: "Upload file" in remarkup text fields should attach by default : Files (archived).
Mar 25 2023
Mar 25 2023
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.
I agree. Having said that I'm not bold enough to propose a "default: open in same tab" since at the moment we have the exact contrary. That is why I proposed this compromise based on the destination.
valerio.bozzolan renamed T15161: Internal resources should avoid to become external links, as default from Internal pages should open in the same tab as default to Internal resources should avoid to become external links, as default.
avivey added a comment to T15161: Internal resources should avoid to become external links, as default.
I agree with this, but I think we should let this wait for broader discussion - there maybe good counter-arguments.
Mar 24 2023
Mar 24 2023
Mar 23 2023
Mar 23 2023
valerio.bozzolan lowered the priority of T15181: Document the configuration "uri.same-window" of PhutilRemarkupEngine from Low to Wishlist.
valerio.bozzolan renamed T15161: Internal resources should avoid to become external links, as default from Internal links should open in the same tab as default to Internal pages should open in the same tab as default.
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
valerio.bozzolan updated the task description for T15182: Simplify the way "internal links" are identified.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0