lint

I've git-merged everything from upstream into our rP and rARC, so there's going to be a few new emails about commits...

I don't think we have this capability right now.

Anyway, looks good to me.

Did you create this with arc diff? arc which can explain why it chose rP.
You can also add a .arcconfig file and explicitly configure rHP there.

@speck I think we're sort of good to go here? maybe update?

In T15096#2333, @sario528 wrote:

Allowing a user to make quick simple changes with nothing but a web browser is IMO the single best way to encourage new contributors.

I'd point out that Gerrit was originally intended to work with a client-side tool called repo (Which also manages multi-repo code trees).
The git push ... <magic ref> is kind of a workaround for users that found having a client-side tool annoying to use :)

In T15090#2123, @Matthew wrote:

That's intentional (upstream) because it's very hard to make any actual attack with this information can't be made without it.

err, I was trying to put it out as a Security PSA, so I clicked "Create security task" which I guess is the opposite of a PSA...

lgtm.

The upstream discussion is at https://secure.phabricator.com/T8787

4pm-8pm GMT (6-10pm GMT+2) sounds good to me - I can even go up to ~midnight and looks like I'm the east-most.

Modern(ish) linters support a separate "interpreter" config - if that's set, they run $interpreter $binary $args rather then just $binary $args. Can this be utilized?

This is my primary jab at Packages - think of it maybe as an RFC.

oh, wow. 8.1 breakage are massive - and I'm guessing more such breaking changes would creep in in next versions?

I've left a comment on the server-side diff.

In T15006#1429, @speck wrote:

I can provide more information later this weekend but I think it would help if we set up a virtual meeting with anyone interested in helping to get this done.

Sague font family is probably important on Windows.

Also, https://secure.phabricator.com/T7413 for the phone-home feature.

The kind of teams that use Centos/Redhat are very conservative - they're exactly the teams that would not install PHP from an "alternative" source (or from source code). They also tend to keep to older OS versions, as long as they are supported, and would not be happy with a single machine being different from the rest.
All that to say, it would make these teams sad to require an upgrade.

+1 for CentOS 7.

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

Turns out there is Javelin support for "copy text" already implemented - I think it's used when copying from 2-up display, or when white-space is visible.
Anyway, I have an example code at https://secure.phabricator.com/P2080 for a button that copies arbitrary text.

I think I just set that via "Global Default": https://we.phorge.it/settings/builtin/global/

I like the idea of having an easily greppeable token...

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

In T15010#1060, @codemouse92 wrote:

I agree with the doc, and would like to sign too.

I just want everything "important" to be happening here, where the search and cross-references works and async communication is easy.

The translated text can be a property of the dialogue itself, if we're worried about having extra objects laying around - the confirmation feels like it's a feature of the dialogue anyway.

There's no way to invoke pht from JS (because it's really complicated in the general case). The general practice is to provide the translated value from PHP when building the relevant objects. There should be an example in the UIExamples app - there's a page with buttons built in JS.

There already are a bunch of worthwhile changes in Phabricator we should pick up; @Matthew - want to load them to check out the procedure? I can do that otherwise.

Here's the terms I've been thinking of for accepting a project to Phactory:

1. Directly related to Phorge in a significant way:

Good: Module for integration with some other system; New Phorge app that does something reasonable; scripts for administration work.
Bad: A space-zombie game that can report high-scores to IRC, Slack and Phorge.

In T15030#916, @dcog wrote:

In T15030#914, @avivey wrote:

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

That sounds awesome! Cool name :) Curious, did this come up in Zulip? I need to log back in there.

nit-pick: maybe name them phabricator/master and phabricator/stable.

(I should stop reading stuff before coffee. You'd think I'd know that by now...)

I'm thinking of hosting them here, giving each project to manage their own repositories, but having a more tight control over the creation of the repo (for technical reasons) and projects.
I'd like to only have projects that are clearly related to Phorge in the install, because we're not GitHub.

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

I would like to officially submit myself as a Core Team member.

TBH, I'm a little confused about the way forward here, and I think this our biggest blocker?
I have some time I can put towards this, but I'm not sure what I should be doing.