Page MenuHomePhorge

Phorge (flame)
Public**Public** chat suitable for do not disturb in the main channel - so to have spikes of high traffic. Tip: unset email notifications here :D

Sorry for the noise! ๐Ÿ˜…

Great, glad it wasn't in our end ๐Ÿ˜

Now I'm wondering if there had been other emails I have been missing due to the same problem ๐Ÿ˜… I guess I'll have to periodically check spam in that inbox now ๐Ÿคฆ

avivey left the room.
Sep 12th, 2023

Belive me or not, but in the 3rd time in a row, nobody attended in my online "Phorge meeting"

I sincerely think that God hates me

Sep 15th, 2023

BUAHAHAHAAHAHH they approved D25066 (EVIL LAUGH)

Sep 19th, 2023

Hey Valerio, I'm not such a power user of Phorge, so if you'd like me to test the patch, please explain how do I create a milestone (I have a board with columns, but they don't seem to be milestones, and I can't find a menu to create one). In any case, that would make the test plan more detailed, which would be great for future reference.

Thanks @waldyrious nice tip. Now the test plan is a bit more complete, thanks. If your test has success, please feel free to Add Action > Accept Revision. Everyone can do this soft-review and it's still very useful

Sep 20th, 2023

Has anyone considered changing the "Accept Revision" to something that better indicates its "soft" nature? It currently sounds like I'm claiming some authority to accept or reject a revision. Especially because the preview message says "Accept Revision: These changes will be approved" without any qualifier (e.g. "by you")

Anyway, I've tested and accepted the patch. Nice work :)

It's a bit part of what you are suggesting

(I've edited the description to mention that button right now)

Sep 24th, 2023

Hey @valerio.bozzolan I'm trying to update D25425 but my arc install seems to be botched. I'm getting an error related to xphast and can't seem to resolve it. Here are the relevant logs of what I tried: https://we.phorge.it/P23. Any ideas?

Is it possible to update the revision using git commands directly? I'd be happy to do that too (in fact I'd prefer it, it irks me a bit to have to learn a separate set of commands for contributing to a single project...)

Sep 25th, 2023

Nope, but feel free to follow T15535

Oct 17th, 2023

VisualStudioCode : GitHub = Emacs : Phorge
Change my mind asd

Oct 19th, 2023
chobotnice joined the room.
Nov 7th, 2023

@valerio.bozzolan woohoo, I managed to fix the issue with my local Arcanist install! I am able to submit revisions again :D https://we.phorge.it/D25458

@valerio.bozzolan Now that I've got arc working again, I was able to finally update D25425 following your review. Can you check it again?

You are the best

Nov 9th, 2023

โค๏ธ

Are you talking to me? Am I able to land patches? I didn't think I had the permission to do so.

@waldyrious Once your patch got accepted by O1 folks, you can land it as the patch author. (If the author does not land it, someone has to commandeer the patch first to take over, basically.)

Yeah that is the lovely weird Phorge workflow ยฎ

arc patch D25458
arc land

Oh, nice :)

I almost got it, but I'm getting a weird error :/ โ†’ https://we.phorge.it/P25

Any hints?

Ah. Uhm. Maybe:

  1. If it asked you your HTTP credentials, they are these: https://we.phorge.it/settings/user/waldyrious/page/vcspassword/
  2. If it didn't ask your HTTP credentials, we have a problem in Phorge.it :D Sorry. Please use SSH.
  3. (preferred) push over SSH (in your phorge/.gitconfig file you should set ssh://git@we.phorge.it/source/phorge.git) and setup your SSH keys (https://we.phorge.it/settings/user/waldyrious/page/ssh/)
Nov 10th, 2023
โ€ข l2dy joined the room.

Note that I can run the very exact commands in my computer to land for you, but I know you really want to give this workflow a try since it's super weird the first time. Nice experience guaranteed asd

It didn't ask for credentials. I didn't have an SSH set up in my Phorge account either, but I do have SSH keys in my ~/.ssh, so maybe it tried to use them? Anyway, I did add one of my keys to https://we.phorge.it/settings/user/waldyrious/page/ssh/ and I still get the same error.

That said, I noticed that:

  • git remote -v indicates that the remote URL for the phorge repo uses HTTP: https://we.phorge.it/source/phorge.git
  • git config --list | grep ssh shows that I have set up the following url.ssh://git@github.com/.insteadof=https://github.com/ but nothing regarding phorge

So I'll try to change the remote URL and try again.

Ha! That must be it, because now it did show me the typical "authenticity of host" message that shows up when connecting over SSH for the first time, and indeed, the patch is now landed! ๐ŸŽ‰

So I take away two things from this experience:

  1. The error messages need to be made clearer, or at least mention the possibility of the Issue I had and how to fix it
  2. The documentation needs to explain the steps to set up the repo locally for contribution in more detail. Currently neither https://we.phorge.it/book/contrib/article/contrib_intro/ nor https://we.phorge.it/book/contrib/article/contributing_code/ nor https://we.phorge.it/book/contrib/article/developer_setup/ explains this.

I'd be happy to contribute improvements on either front. Do you have any insight on how to proceed to do so?

Btw I also landed D25425! ๐Ÿ˜ƒ ๐Ÿ˜ƒ

Yeah, maybe we can split the section "Writing and submitting patches" to "Writing patches" and with "Submitting patches"
https://we.phorge.it/book/contrib/article/contributing_code/
So to also mention how to use Arcanist
https://we.phorge.it/book/phorge/article/arcanist_quick_start/

Also replacing Phacility with us :) asd

Nov 11th, 2023

I don't think I know enough to make those changes myself ๐Ÿ˜… so I started with a much simpler patch which I had already prepared before: D25465. Feel free to suggest additions/improvements there!

โ€ข l2dy left the room.
Nov 21st, 2023
Matthew joined the room.
Nov 28th, 2023

Could someone with permissions replace "today" by "25 August 2023" (I think?) on https://we.phorge.it/w/changelog/2023.32/ please? TIA

Done thanks (maybe we can escalate Aklapper as Blessed Communicator)

Dec 2nd, 2023

@valerio.bozzolan that was the fastest token I ever got ๐Ÿ˜‚

I have now added before-after screenshots :)

(I'm speaking of https://we.phorge.it/D25485, for context)

Dec 6th, 2023

@valerio.bozzolan is there anything missing on my side for D25466 to move forward? No hurries, just making sure we're not waiting on each other :)

Dec 7th, 2023

Oh thanks. Tested again. Love it

I damn hate this week, at work we have a total mess and customers screaming about legacy stuff

My only friend at work is our Phorge installation and your patches

๐Ÿ˜… ๐Ÿ˜ I'm glad they're offering some relief. Supporting legacy stuff is such a chore.

Actually, nevermind. Let's not get into the weeds for a minor optimization. I'll land the change as-is and later we can refine that bit if we deem it useful.

Dec 8th, 2023

Yeah I've seen that comment but I don't know :D

Dec 13th, 2023

I love over-engineering commit messages and putting stupid things in test plans btw

Hahah I lost count of how much time I've spent writing near-essays in commit message bodies ๐Ÿ˜…

Dec 14th, 2023

WHOOOO ANOTHER BLESSED COMMITTER \o/ aklapper \o/

Nice! ๐Ÿ‘๐Ÿ‘

Dec 15th, 2023

Uh thanks

Jan 4th, 2024
doommius joined the room.
Jan 8th, 2024

Lol @akpapper in D25494 I think we should roll a dice

Jan 12th, 2024

Hi @sirocyl if you want ethernal glory, feel free to propose a patch - I'm talking about this: https://we.phorge.it/T15006#14958

So basically you do local changes and then you run ../arcanist/bin arc diff

Hi @aklapper if you want to try your new +1/-1 review power, we have an easy-peasy thing here D25507

Yeah I need to catch up with a few things...may have some more time soon because no reallife work interfering :P

Jan 18th, 2024

Lol in this page there are 700+ talks and Phorge is the number 7

Jan 29th, 2024
Feb 1st, 2024

I mean in "Projects are hashtags are tags."

Feb 5th, 2024

Thanks @philj0st for the report in D25530 (you are now in the family of Trusted Contributors )

โ€ข philj0st joined the room.

o/ no problem! thanks for the quick fix and warm welcome.

Feb 6th, 2024

I am trying to set up Differential for existing Bitbucket repos.
Users can login via Bitbucket OAuth. To observe a Bitbucket repo from Differential do I need a technical user in Bitbucket (either via https or ssh).
Am I correct in my assumption there's no way to directly use Bitbucket's access control via OAuth (scopes/claims)?
Would copying the Bitbucket access control manually to Phorge policies be the only way to do it?

Sorry if this is the wrong place to ask. I'll gladly repost somewhere else if that's the case.

I'm quite sure that OAuth does not automagically import access controls at the moment, my friend

mmh yeah thought so :) thanks for the information!

(I'm also unaware of any similar software with a similar feature)

Probably best to ask in Ponder

I just don't get the big picture. I mean:

  • You have a repository on Diffusion, observing Bitbucket (nice, easy)
  • You want a nice OAuth login to Bitbucket (nice, easy I think)
  • You want
  • You want that ONLY some people can see the BitBucket repository in BitBucket, and you want that very same permission in your Diffusion (?)

Maybe you can extend the OAuth login to automagically import teams from BitBucket, and create as related Tag in Phorge, maybe with a prefix like "BitBucket-Team-*", and force these Tags to be not editable by nobody.

So your Diffusion is Visible by that "BitBucket-Team-Foo"

So, the more people connect to OAuth, the more teams you import and the more people join the right groups

Feb 8th, 2024

Great Idea! I might look into that. I'm also unaware of any similar software with a similar feature especially outside of the Atlassian stack, it was wishful thinking :) who knows.

And yes you got the big picture. My team used Upsource before, which has been sunset in 2023. We work trunk based and Bitbucket supports only PR-based reviews. For now we would mostly need Differential's features.