Phorge (flame)

Public**Public** chat suitable for do not disturb in the main channel - so to have spikes of high traffic. Tip: unset email notifications here :D

• Join Room

Yeah, maybe we can split the section "Writing and submitting patches" to "Writing patches" and with "Submitting patches"
https://we.phorge.it/book/contrib/article/contributing_code/
So to also mention how to use Arcanist
https://we.phorge.it/book/phorge/article/arcanist_quick_start/

Also replacing Phacility with us :) asd

I don't think I know enough to make those changes myself 😅 so I started with a much simpler patch which I had already prepared before: D25465. Feel free to suggest additions/improvements there!

Could someone with permissions replace "today" by "25 August 2023" (I think?) on https://we.phorge.it/w/changelog/2023.32/ please? TIA

Done thanks (maybe we can escalate Aklapper as Blessed Communicator)

@valerio.bozzolan that was the fastest token I ever got 😂

@valerio.bozzolan is there anything missing on my side for D25466 to move forward? No hurries, just making sure we're not waiting on each other :)

Oh thanks. Tested again. Love it

😅 😁 I'm glad they're offering some relief. Supporting legacy stuff is such a chore.

@valerio.bozzolan WDYT about this commment in particular? https://we.phorge.it/D25466#inline-3284

Actually, nevermind. Let's not get into the weeds for a minor optimization. I'll land the change as-is and later we can refine that bit if we deem it useful.

Yeah I've seen that comment but I don't know :D

I love over-engineering commit messages and putting stupid things in test plans btw

Hahah I lost count of how much time I've spent writing near-essays in commit message bodies 😅

WHOOOO ANOTHER BLESSED COMMITTER \o/ aklapper \o/

Nice! 👏👏

Uh thanks

Lol @akpapper in D25494 I think we should roll a dice

Hi @sirocyl if you want ethernal glory, feel free to propose a patch - I'm talking about this: https://we.phorge.it/T15006#14958

So basically you do local changes and then you run ../arcanist/bin arc diff

Hi @aklapper if you want to try your new +1/-1 review power, we have an easy-peasy thing here D25507

Yeah I need to catch up with a few things...may have some more time soon because no reallife work interfering :P

Lol in this page there are 700+ talks and Phorge is the number 7

@aklapper is there a typo here? https://we.phorge.it/T15701#15029

@valerio.bozzolan no

I mean in "Projects are hashtags are tags."

Thanks @philj0st for the report in D25530 (you are now in the family of Trusted Contributors )

o/ no problem! thanks for the quick fix and warm welcome.

I am trying to set up Differential for existing Bitbucket repos.
Users can login via Bitbucket OAuth. To observe a Bitbucket repo from Differential do I need a technical user in Bitbucket (either via https or ssh).
Am I correct in my assumption there's no way to directly use Bitbucket's access control via OAuth (scopes/claims)?
Would copying the Bitbucket access control manually to Phorge policies be the only way to do it?

Sorry if this is the wrong place to ask. I'll gladly repost somewhere else if that's the case.

I'm quite sure that OAuth does not automagically import access controls at the moment, my friend

mmh yeah thought so :) thanks for the information!

(I'm also unaware of any similar software with a similar feature)

Probably best to ask in Ponder

I just don't get the big picture. I mean:

• You have a repository on Diffusion, observing Bitbucket (nice, easy)
• You want a nice OAuth login to Bitbucket (nice, easy I think)
• You want

Maybe you can extend the OAuth login to automagically import teams from BitBucket, and create as related Tag in Phorge, maybe with a prefix like "BitBucket-Team-*", and force these Tags to be not editable by nobody.

Great Idea! I might look into that. I'm also unaware of any similar software with a similar feature especially outside of the Atlassian stack, it was wishful thinking :) who knows.

And yes you got the big picture. My team used Upsource before, which has been sunset in 2023. We work trunk based and Bitbucket supports only PR-based reviews. For now we would mostly need Differential's features.

@mturdus I'm trying to install the lovely Diagrams app following https://we.phorge.it/source/diagrams/ but "arc liberate" gives an error to me from Phorge directory

LOAD ERROR Failed to load library at location "/var/www/phorge/src". This library is specified by "Configuration (Project Config File (/var/www/phorge/.arcconfig))". Check that the setting is correct and the library is located in the right place.

The error is resolved if I remove src/extensions/diagrams

My stack trace is

For more information, see: https://phurl.io/u/newclasses at [<arcanist>/src/init/init-library.php:26]
arcanist(head=arcpatch-D25489, ref.master=8ef1ead6aca0, ref.arcpatch-D25489=8ef1ead6aca0), phorge(head=master, ref.master=e2bec4c1f58b)
  #0 __phutil_autoload(string) called at [<phorge>/src/extensions/diagrams/src/storage/Diagram.php:3]
  #1 PhutilBootloader::executeInclude(string) called at [<arcanist>/src/init/lib/PhutilBootloader.php:291]
  #2 PhutilBootloader::loadExtension(string, string, string) called at [<arcanist>/src/init/lib/PhutilBootloader.php:109]
  #3 PhutilBootloader::registerLibrary(string, string) called at [<arcanist>/src/init/lib/core.php:5]
  #4 phutil_register_library(string, string) called at [<phorge>/src/__phutil_library_init__.php:3]
  #5 include_once(string) called at [<arcanist>/src/init/lib/PhutilBootloader.php:251]
  #6 PhutilBootloader::executeInclude(string) called at [<arcanist>/src/init/lib/PhutilBootloader.php:215]
  #7 PhutilBootloader::loadLibrary(string) called at [<arcanist>/src/init/lib/moduleutils.php:40]
  #8 phutil_load_library(string) called at [<arcanist>/src/runtime/ArcanistRuntime.php:457]
  #9 ArcanistRuntime::loadLibrary(ArcanistConfigurationEngine, string, string) called at [<arcanist>/src/runtime/ArcanistRuntime.php:374]
  #10 ArcanistRuntime::loadLibraries(ArcanistConfigurationEngine, ArcanistConfigurationSourceList, PhutilArgumentParser) called at [<arcanist>/src/runtime/ArcanistRuntime.php:104]
  #11 ArcanistRuntime::executeCore(array) called at [<arcanist>/src/runtime/ArcanistRuntime.php:37]
  #12 ArcanistRuntime::execute(array) called at [<arcanist>/support/init/init-arcanist.php:6]
  #13 require_once(string) called at [<arcanist>/bin/arc:10]

I mean, prefixed by

[2024-02-27 10:13:21] EXCEPTION: (PhutilMissingSymbolException) Failed to load symbol "DiagramDAO" (of type "class or interface").

The class or interface "DiagramDAO" is not defined in the library map of any loaded library.

(The class is there in ./src/extensions/diagrams/storage/DiagramDAO.php)

T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType")

@aklapper I'm starting to have fun writing branch names for Differential folks - thanks again for that life lesson

@20after4 Ouch I see we have no documentation in No documentation here about that Remarkup feature. If you hack the document I will immediately +1 https://we.phorge.it/book/phorge/article/remarkup/

Hi @tsc you are now in the family of Trusted Contributors - thanks for any task

In T15121#16097, @aklapper wrote:

Would you like to go to court to defend that statement? :)

YES

Oh did not see that chat and I'm spamming the main channel.

Don't worry be flame

Still need someone to look at my stuff If I'm doing it right: D25558

Hi, I need more context. What is that patch supposed to do, which problem is that patch supposed to solve? Editing its title and description is welcome :)

The patch in itself is not that useful, it would be more usefull if you could watch the whole file in it's current state, because I'm implementing this extension from scratch and want to know if I'm doing it right.

@aklapper I updated the description. I hope it is more clear what needs to be done.

@bekay probably n.3 and n.4 should be swapped in the README (?) https://we.phorge.it/source/diagrams/repository/master/

@Jack_who_built_the_house please set these as visible to everybody F2157279 F2157280 - sorry for this extra step

The next week I will be on heavy vacancy, so I will be probably more available for little tests and reviews lol
Thanks @aklapper for the true fun in this period. I love having Differential full of stuff and vibrant lol

Heh, thanks in advance. :D Installed PHPStan for code analysis so there's a good bunch of things to fix and a few more complicated ones to come

OK, I'm scared now lol

We all are. But together, we will face and overcome our fears! Doubleswear.

wait, where did my messages here go?

What makes you think there were some?

not sure, i sort of recall having some messages here, guess im recalling wrong :P

@aklapper btw imagine an Italian port authority telling «"salga a bordo cazzo"» to an Italian capitan that means “fucking get on board.”

Heh, you remind me of my favorite escalation moments in Italy after that Wikimania conference :D

Really thanks @aklapper since only thanks to your bugs I discovered, today, how the damn "app welcome messages" are rendered

Heh, while I'm still screaming over very strange Javelin JS behavior here :D

God will bless whoever will master Javelin

All the sigil things is relatable, but insteresting and understandable, for CSS/HTML separation. But then, why the hell to find a sigil I must express its specific HTML tag name? If I want separation, and I want to assign a sigil on a tag, it's nonsense to stuck on a specific HTML tag and look for ul tags with dog sigil, and does not work if I migrate that sigil to a div

Heads-up: I plan to accept the CSS modernization changes in https://we.phorge.it/D25619 but a second person testing is ofc welcome

For that patch I suggest the "whatcouldgowrong" macro

Maybe notable for https://phabricator.wikimedia.org/phame/post/view/316/iterative_improvements/:

• T107254 Closed tickets in Bugzilla migrated without a closing date (→ maybe to be mentioned in "bad data in our database")
• https://we.phorge.it/book/phorge/article/remarkup_cowsay/ - add documentation for cowsay

The last one is quite important/critical imvho asd

OK I will stop editing Phorge, I've maked 5 typos in a row. Maybe better to sleep a bit.