Page MenuHomePhorge

Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
ClosedPublic

Authored by aklapper on Jul 9 2024, 21:26.
Tags
None
Referenced Files
F3345046: D25727.1743685122.diff
Wed, Apr 2, 12:58
F3341336: D25727.1743652190.diff
Wed, Apr 2, 03:49
F3335607: D25727.1743564666.diff
Tue, Apr 1, 03:31
F3334800: D25727.1743554074.diff
Tue, Apr 1, 00:34
F3333518: D25727.1743536336.diff
Mon, Mar 31, 19:38
F3331400: D25727.1743505851.diff
Mon, Mar 31, 11:10
F3326444: D25727.1743419010.diff
Sun, Mar 30, 11:03
F3314491: D25727.1743230599.diff
Fri, Mar 28, 06:43

Details

Summary

The expression $all_tags[$tag]['count'] does not do anything. Reading the surrounding code, intention is to display a "Common" section on /settings/panel/emailpreferences/ listing MailTags defined by at least two different applications. (This is currently not the case anyway as Phorge prefixes all MailTags with their corresponding application but might be a future use case.)
This change fixes the logic accordingly.

Closes T15874

Test Plan

Apply the patch; replace the value of a random const MAILTAG_* line in the codebase with the value of another random const MAILTAG_* line in the codebase to make it "common", now see that /settings/panel/emailpreferences/ displays this MailTag in a "Common" section on top of the options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable