Page MenuHomePhorge

Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
ClosedPublic

Authored by aklapper on Jul 9 2024, 21:26.
Tags
None
Referenced Files
F3605107: D25727.1745251861.diff
Sun, Apr 20, 16:11
F3541298: D25727.1744896922.diff
Wed, Apr 16, 13:35
F3498021: D25727.1744791451.diff
Tue, Apr 15, 08:17
F3389959: D25727.1744461982.diff
Fri, Apr 11, 12:46
F3387386: D25727.1744436389.diff
Fri, Apr 11, 05:39
F3372126: D25727.1744248446.diff
Wed, Apr 9, 01:27
F3371962: D25727.1744247157.diff
Wed, Apr 9, 01:05
F3368286: D25727.1744207337.diff
Tue, Apr 8, 14:02

Details

Summary

The expression $all_tags[$tag]['count'] does not do anything. Reading the surrounding code, intention is to display a "Common" section on /settings/panel/emailpreferences/ listing MailTags defined by at least two different applications. (This is currently not the case anyway as Phorge prefixes all MailTags with their corresponding application but might be a future use case.)
This change fixes the logic accordingly.

Closes T15874

Test Plan

Apply the patch; replace the value of a random const MAILTAG_* line in the codebase with the value of another random const MAILTAG_* line in the codebase to make it "common", now see that /settings/panel/emailpreferences/ displays this MailTag in a "Common" section on top of the options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable