Page MenuHomePhorge

Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
ClosedPublic

Authored by aklapper on Jul 9 2024, 21:26.
Tags
None
Referenced Files
F2977902: D25727.1739657654.diff
Fri, Feb 14, 22:14
F2977901: D25727.1739657653.diff
Fri, Feb 14, 22:14
F2977900: D25727.1739657652.diff
Fri, Feb 14, 22:14
F2977869: D25727.1739655978.diff
Fri, Feb 14, 21:46
F2977847: D25727.1739654068.diff
Fri, Feb 14, 21:14
F2951455: D25727.1738887870.diff
Thu, Feb 6, 00:24
F2898317: D25727.1737253431.diff
Jan 18 2025, 02:23
F2877690: D25727.1737005604.diff
Jan 15 2025, 05:33

Details

Summary

The expression $all_tags[$tag]['count'] does not do anything. Reading the surrounding code, intention is to display a "Common" section on /settings/panel/emailpreferences/ listing MailTags defined by at least two different applications. (This is currently not the case anyway as Phorge prefixes all MailTags with their corresponding application but might be a future use case.)
This change fixes the logic accordingly.

Closes T15874

Test Plan

Apply the patch; replace the value of a random const MAILTAG_* line in the codebase with the value of another random const MAILTAG_* line in the codebase to make it "common", now see that /settings/panel/emailpreferences/ displays this MailTag in a "Common" section on top of the options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable