Extending this task to include support for PHP 8.3 which is due to be released today.

That warning can be ignored as I'm guessing it's detecting phorge in we.phorge.it

If somebody could land this at some point, that would be great!

We should definitely prioritize this, as after November of this year we won’t support any stable/maintained versions of PHP

Expanding task to also include adding compatibility with PHP 8.2

fix

fix

Yes it is used for mailing via smtp, so probably most installs use it

Could somebody please land this at some point t?

@Matthew the arcanist herald rule needs to be set to trigger when both conditions are met - currently even if a change is accepted only a member of Releasers can land the change because it will trigger for anyone who isn’t a member of Releasers. We want it to trigger if it both hasn’t been reviewed and the user isn’t a member of Releasers.

https://we.phorge.it/book/phorge/article/installation_guide/

In D25055#1786, @Cigaryno wrote:

Could you do this:

• Replace the Phabricator logo with the Phorge logo.
• Replace the G+ like Google logo with the current Google logo that was used since 2015.

Optional: Replace the Facebook logo with the new one that has a different blue.

Oh actually they do work now - never mind

The GitHub mirrors still don’t work yet, those reps are empty currently.

I'll note that the developer-mode, timezone, serious-business and production-url config settings still use Phabricator in the names

@avivey I see that the repos currently access GitHub anonymously. For auto mirror to work you need to configure a valid credential. By this I mean you need to create a username/password passphrase credential with creds for a GitHub account that has write access to the GitHub repos, and set it in the diffusion uris.

I would say the current create forms are fine, there should be 2 edit forms, 1 unrestricted one only visible to trusted users, and a restricted one that is only visible to non-trusted users (can be done with custom policy)

I’ll note that there is currently a restricted create form, for Trusted Contributors that allows anything to be changed.

We should also generate the arcanist docs.

@20after4 per commits like https://secure.phabricator.com/D9202 the changes were abandoned - there is no MediaWiki auth provider in core

Yeah if that RFC passes then that would make things way easier. And yes I used sed for a lot of the changes.

Ok, so in zulip in #general under the bridge topic that is bridged to IRC.

The fixes mentioned there would take a long time to implement, as things like strlen() are used in 900+ files.

In T15064#1705, @jeremy.norris wrote:

There were more upstream changes made a week ago, https://secure.phabricator.com/w/changelog/2021.49/, that included improved PHP8 compatibility...

That'll be changes for PHP 8.0 compatibility, but that's not the same as PHP 8.1 compatibility.

In T15064#1703, @jeremy.norris wrote:

Wouldn't a massive changeset like this greatly increase difficulty of performing future merges of upstream (secure.phabricator.com)?

I have submitted patches to fix most of the issues. The following issues still remain.

In T15059#1654, @speck wrote:

I just checked the emails I receive to my gmail account and noticed that the emails seem to be from the secure.phorge.dev domain. Should those be received from we.phorge.it instead? I was in the process of filling out an issue form for Microsoft and noticed this discrepancy. Could that cause issues like this?

After making lots of changes in my clone to suppress deprecation warnings, I am stuck at the following error.
[Wed Dec 01 16:06:24.853494 2021] [proxy_fcgi:error] [pid 2472770:tid 139879417599744] [client <REDACTED>] AH01071: Got error 'PHP message: [2021-12-01 16:06:24] EXCEPTION: (Exception) Bad getter call: getPreferences at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1620]
PHP message: arcanist(head=master, ref.master=c53bb21bbd3e), phabricator(head=master, ref.master=4448a93a4067), testwiki-ext-misc(head=master, ref.master=c12e85d3a97a)
PHP message: #0 <#2> LiskDAO::call(string, array) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1598]
PHP message: #1 <#2> LiskDAO::call(string, array) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:446]
PHP message: #2 <#2> PhabricatorUser::loadGlobalSettings() called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:377]
PHP message: #3 <#2> PhabricatorUser::getUserSetting(string) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:428]
PHP message: #4 <#2> PhabricatorUser::getTranslation() called at [<phabricator>/src/applications/auth/engine/PhabricatorAuthSessionEngine.php:1127]
PHP message: #5 <#2> PhabricatorAuthSessionEngine::willServeRequestForUser(PhabricatorUser) called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:109]
PHP message: #6 <#2> PhabricatorController::willBeginExecution() called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:271]
PHP message: #7 phlog(Exception) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
PHP message: #8 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, Exception) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
PHP message: #9 AphrontApplicationConfiguration::handleThrowable(Exception) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
PHP message: #10 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message Log, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP messaghutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]PHP messaguration.php:204]
PHP messaglicationConfiguration.php:204]PHP messagont/configuration/AphrontApplicationConfiguration.php:204]
PHP messagd at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message aphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message: #11 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]PHP message: [2021-12-01 16:06:24] EXCEPTION: (PhutilAggregateException) Encountered a processing exception, then another exception when trying to build a response for the first exception.\n - Exception: Bad setter call: setUserPHID\n - Exception: Bad getter call: getPreferences at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:316]
PHP message: arcanist(head=master, ref.master=c53bb21bbd3e), phabricator(head=master, ref.master=4448a93a4067), testwiki-ext-misc(head=master, ref.master=c12e85d3a97a)
PHP message: #0 <#4> LiskDAO::call(string, array) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:446]
PHP message: #1 <#4> PhabricatorUser::loadGlobalSettings() called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:377]
PHP message: #2 <#4> PhabricatorUser::getUserSetting(string) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:428]
PHP message: #3 <#4> PhabricatorUser::getTranslation() called at [<phabricator>/src/applications/auth/engine/PhabricatorAuthSessionEngine.php:1127]
PHP message: #4 <#4> PhabricatorAuthSessionEngine::willServeRequestForUser(PhabricatorUser) called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:109]
PHP message: #5 <#4> PhabricatorController::willBeginExecution() called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:271]
PHP message: #6 <#3> LiskDAO::call(string, array) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1598]
PHP message: #7 <#3> LiskDAO::__call(string, array) called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:666]PHP message: #8 <#3> PhabricatorApplicationSearchEngine::getBuiltinQueries() called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:500]
PHP message: #9 <#3> PhabricatorApplicationSearchEngine::loadAllNamedQueries() called at [<phabricator>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:537]
PHP message: #10 <#3> PhabricatorApplicationSearchEngine::loadEnabledNamedQueries() called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:157]
PHP message: #11 <#3> PhabricatorMainMenuSearchView::getGlobalSearchScopeItems(PhabricatorUser, PhabricatorFlagsApplication) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:205]
PHP message: #12 <#3> PhabricatorMainMenuSearchView::buildModeSelector(string, string) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuSearchView.php:89]
PHP message: #13 <#3> javelin_tag(string, array, array) called at [<phabricator>/src/view/phui/PHUIListItemView.php:426]
PHP message: #14 <#3> phutil_tag(string, array, array) called at [<phabricator>/src/infrastructure/javelin/markup.php:70]
PHP message: #15 <#3> javelin_tag(string, array, array) called at [<phabricator>/src/view/AphrontTagView.php:161]
PHP message: #16 <#3> AphrontTagView::render() called at [<phabricator>/src/view/AphrontView.php:222]
PHP message: #17 <#3> AphrontView::producePhutilSafeHTML() called at [<phabricator>/src/infrastructure/markup/render.php:111]
PHP message: #18 <#3> phutil_escape_html(PHUIListView) called at [<phabricator>/src/infrastructure/markup/render.php:135]
PHP message: #19 <#3> phutil_escape_html(array) called at [<phabricator>/src/infrastructure/markup/render.php:97]
PHP message: #20 <#3> phutil_tag(string, array, array) called at [<phabricator>/src/view/page/menu/PhabricatorMainMenuView.php:168]
PHP message: #21 <#3> PhabricatorMainMenuView::render() called at [<phabricator>/src/view/page/PhabricatorStandardPageView.php:374]
PHP message: #22 <#3> PhabricatorStandardPageView::willRenderPage() called at [<phabricator>/src/view/page/AphrontPageView.php:46]
PHP message: #23 <#3> AphrontPageView::render() called at [<phabricator>/src/applications/base/controller/PhabricatorController.php:286]
PHP message: #24 <#3> PhabricatorController::willSendResponse(AphrontDialogResponse) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:300]
PHP message: #25 <#2> AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
PHP message: #26 <#2> AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]
PHP message: #27 phlog(PhutilAggregateException) called at [<phabricator>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
PHP message: #28 AphrontUnhandledExceptionResponse::setException(PhutilAggregateException) called at [<phabricator>/webroot/index.php:46]'

I think this task is mostly resolved. The zulip chat is a temporary thing, and it hasn't been used anytime recently. We could bridge the IRC channel to it if we wanted to have a more permanent zulip instance.

A member of Trusted Contributors will land it for you.

@speck I can’t get you added as you aren’t currently authenticated with NickServ.

In T15035#1445, @MacFan4000 wrote:

So, I sent a community registration ticket back in July,and never heard back. They say they have a backlog. I think though it would be easier if we do a project registration and have it be done by somebody who can verify that they represent Phorge. (either through a file on the web root or else DNS)

For the record we are up to 22 user in the channel currently.

So, I sent a community registration ticket back in July,and never heard back. They say they have a backlog. I think though it would be easier if we do a project registration and have it be done by somebody who can verify that they represent Phorge. (either through a file on the web root or else DNS)

@io for GitHub we have a task (T15046)

For the rest, I think they can be created on an as-needed basis.

I will note that also the tech docs aren’t fully generated since there should be docs for most of the phorge/phabricator classes. Also the arcanist docs aren’t generated at all.