Page MenuHomePhorge

replace usage of each() with foreach() for smtp

Authored by MacFan4000 on Nov 27 2022, 21:20.
Referenced Files
F419564: D25059.diff
Mon, Dec 11, 16:44
Unknown Object (File)
Sat, Dec 9, 06:10
Unknown Object (File)
Fri, Dec 8, 16:37
Unknown Object (File)
Fri, Dec 8, 02:33
Unknown Object (File)
Fri, Dec 1, 19:39
Unknown Object (File)
Fri, Dec 1, 16:08
Unknown Object (File)
Fri, Dec 1, 12:41
Unknown Object (File)
Wed, Nov 29, 06:40



this replaces uses with warning suppression of each() (depreccated in
PHP7, removed in PHP8) with foreach

Test Plan

can verify that these chages do work (tested on my own install)

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

  1. Is this even used?
  2. Looks like the file is currently in Windows mode; can you please split this to 2 diffs, or just keep the original line-ending?

Yes it is used for mailing via smtp, so probably most installs use it

This revision is now accepted and ready to land.Feb 2 2023, 19:05

If somebody could land this at some point, that would be great!

I will land since the author asked this kind of help, and avivey confirmed, and also asked to keep the same "no newline at end of file" and that's respected.