replace usage of each() with foreach() for smtp
Needs ReviewPublic
Actions

Authored by MacFan4000 on Nov 27 2022, 21:20.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 27, 15:53

	Unknown Object (File)
	Mon, Jan 23, 17:36

	Unknown Object (File)
	Fri, Jan 13, 00:54

	Unknown Object (File)
	Thu, Jan 5, 23:44

	Unknown Object (File)
	Thu, Jan 5, 23:44

	Unknown Object (File)
	Thu, Jan 5, 14:41

	Unknown Object (File)
	Tue, Jan 3, 18:31

	Unknown Object (File)
	Dec 12 2022, 11:46

Subscribers

Details

Reviewers

• dsadad

Group Reviewers

O1: Blessed Committers
Blessed Committers

Summary

this replaces uses with warning suppression of each() (depreccated in
PHP7, removed in PHP8) with foreach

Test Plan

can verify that these chages do work (tested on my own install)

Diff Detail

Repository

rP Phorge

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 94
Build 94: arc lint + arc unit

Event Timeline

MacFan4000 created this revision.Nov 27 2022, 21:20

Owners added a reviewer: O1: Blessed Committers.Nov 27 2022, 21:20

Herald added subscribers: Matthew, valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptNov 27 2022, 21:20

MacFan4000 requested review of this revision.Nov 27 2022, 21:20

Harbormaster completed remote builds in B94: Diff 289.Nov 27 2022, 21:20

MacFan4000 added a reviewer: Blessed Committers.Nov 27 2022, 21:21

Cigaryno added a subscriber: Cigaryno.Dec 16 2022, 10:36

• dsadad accepted this revision.Dec 17 2022, 16:34

Is this even used?
Looks like the file is currently in Windows mode; can you please split this to 2 diffs, or just keep the original line-ending?

Revision Contents
Changeset List

Path

Size

Packages

externals/

phpmailer/

class.smtp.php

1628 lines

O1: Blessed Committers

Diff 289

View Options

externals/phpmailer/class.smtp.php

replace usage of each() with foreach() for smtpNeeds ReviewPublicActions