HomePhorge

Fix incorrect quoting of author in 'arc patch'

Description

Fix incorrect quoting of author in 'arc patch'

Summary:
Author field is formatted with csprintf, which would be appropriate
if the resulting string was concatenated into a shell command as a
string -- but because the flags are passed as a vector of strings
and not parsed by the shell, this results in extraneous shell
quoting making it into to author field. In particular this
renders my name as D'\''Anna instead of D'Anna

Test Plan:
Performed 'arc patch' with and without these changes, confirmed
that my apostrophe was no longer mangled by shell quotes in the
resulting commit.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: MacFan4000, Ekubischta, speck, tobiaswiese, valerio.bozzolan

Differential Revision: https://we.phorge.it/D25026

Details

Provenance
ldannaAuthored on Oct 23 2021, 19:01
MacFan4000Committed on Oct 23 2021, 19:02
MacFan4000Pushed on Oct 23 2021, 19:02
Reviewer
Restricted Owners Package
Differential Revision
D25026: Fix incorrect quoting of author in 'arc patch'
Parents
rARC5407e5e5c67e: Fix PhutilLibraryMapBuilder to call the right function in log()
Branches
Unknown
Tags
Unknown
References
HEAD -> master