In D25501#14443, @aklapper wrote:

This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/

So, as default, a transform is created. Should we attach that transform instead?

Would you like to propose a small cute patch for this? It's just a matter of running arc diff or ../arcanist/bin/arc diff

In addition, it seems only the owner can see their stuff here.

unknown magic accepts any kind of input (e.g. letters) and converts it into a 0.

Thanks! some quick tips maybe relevant:

In D25479#14404, @avivey wrote:

Yeah, looks like IntField isn't doing much now (yet?). It could get setDefault() like PhabricatorSearchSelectField, plus validateControlValue()

This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/

There might be room for performance improvements - currently for each $query, PhabricatorApplication::isClassInstalledForViewer is called again though some queries share the same application.

Document abstract function that it can return string|null

Also looked into very hackish $application_of_query = preg_split('/(?=[A-Z])/', get_class($query)); but the *TransactionQuery.php class naming scheme is too inconsistent, e.g. PhabricatorSpacesTransactionQuery instead of SpacesTransactionQuery (same for Slowvote, Phurl, Owners, Badges, Calendar, Packages, Paste, maybe more).

If it still works, feel free to land

probably "low", but might be interesting to investigate.

Improve performance (as proposed by Valerio)

Yeah, looks like IntField isn't doing much now (yet?)

That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️

I ended up running this

I think it might be applicable here and in several other places that follow the general pattern of “look up all subclasses of a given feature and then loop over all of them to run extension hooks “

@20after4 suggested an "is-application-installed"-aware class-finder recently - I wonder if that would also handle this?

Argh, note to myself: Simply define $hide_packages = (!id(new PhabricatorPackagesApplication())->isInstalled()); and add ->setIsHidden($hide_packages)...

They have no space at FOSDEM 2024 for Phorge, nor in Collaboration and..., nor in Lightning talks :(

I close this as invalid since we received no additional feedback. Feel free to add more details :) Thanks \o/

Nah my friend, sorry me, my example was incomplete. I've updated that.

I'm too stupid to see the exact optimization, performance-wise (but probably not important). :)

I think that the best alternative we have for that, is YunoHost. So, an Open Source suite to easily deploy applications on your server. Give it a try. If you like it, I think that, there, Phorge may land.

Just for some micro-optimization, note that preg_replace() has a 5th parameter called $count

I can confirm that this patch fixes the string problem. However, I am super super puzzled that after applying this patch, the CSS definition line-height: 22px for .phabricator-wordmark is suddenly missing in both Chromium 120 and Firefox 120, moving the wordmark a bit higher in the upper left corner (on my two screenshots, that is "Phoriorge").

I assumed that $this->newStringIndex($value) in the next line implies a string here but let's play safe, indeed.

Right, makes sense as I do not fully know the internal logic.
As PhabricatorStandardCustomField is generic, also keep null check type-generic

The only trouble with maintaining a separate arcanist package is keeping the version in sync with phorge. Phabricator never followed anything like semantic versioning and there was never really any stable api version to depend on. Perhaps we could think about versioning and release cycles that follow a more predictable major version release cycle with API compatibility guarantees. It is certainly more convenient (for the upstream) to avoid all of that but it offloads quite a bit of burden on anyone trying to use the software.

TLDR; I think @aklapper is on the right track: I did some more digging and it looks like something similar to P24 is probably the only reasonably easy solution.

Phacility was very much against this kind of things, but I actually favor supporting some packages, at least for Arcanist on the big package-managers - if nothing else, it would allow us to make sure the package with the right name is doing the right thing.

Feel free to review, in case:

Unfortunately they have not accepted our proposal in the track Collaboration and Content Management. I've proposed that again as Lightning talk as suggested to me by FOSDEM ex-speakers.

I keep arcanist cloned in /home/kuba/bin/arcanist. /home/kuba/bin/arc is this executable file:

I've managed to land the diff with arc --config-file ~/.arcrc land

do you have an entry for "https://we.phorge.it/api/" in your ~/.arcrc ?

Abandoning as superseded by rP1c098c273d06ea3cf8215245ea109f41c59593d9 (which first requires commandeering)

also, arc get-config hosts --verbose - but note that it will actually print out the tokens, hide those.