OK, tested by 3 hackers, no git regressions, more SVN stability, more inline documentation, more abstraction, very Phorgi, already tracking follow-ups, yuuup

In T15957#22436, @keithzg wrote:

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN, it just wasn't being noticed in my SVN testing because it doesn't go wrong if run from any subfolder. So for example in a checkout of rARC, running arc browse . in the root directory will pop one into the bogus path of, say, https://we.phorge.it/source/arcanist/browse/master/home/keithzg/Code/git/arcanist, but if I'm in my local ~/Code/git/arcanist/src/ then arc browse . pops open https://we.phorge.it/source/arcanist/browse/master/src as intended.

The only remaining issue I could find in retesting was that, when run on the root of a repo, apparently SVN exhibits the same behaviour as Git does in T15957; and furthermore in my testing actually Git also doesn't have that problem if arc browse . is run in a subfolder rather than the root of a repo. (It's just so much more common to be in the root of a Git repo, and so much less common to be in the true root of an SVN repo, that we didn't notice!)

Closed all inline comments.

• adopt suggested indentation in ArcanistRepositoryRef.php:91-94
• adopt explicit "TODO" in ArcanistRepositoryRef.php:138-139

Reading (and testing) this again/more, after our first round in person a few days ago, now that I have a local SVN repo, I cannot find anything wrong or non-working, still I'd ideally appreciate another pair of eyes.
Added two more small comments.

ArcanistRepositoryAPI: apply suggested inline comment:

look mum, I'm learning English

improve comments (again) - thanks

avoid double unset(), just use or

update inline doc, thanks aklapper

Seems to work locally.

@mturdus I have landed this but have reintroduced this code which you have removed - please accept my fix: D25960

@valerio.bozzolan could you please add to either H28 or H29 Affected files contains none of map.php?

The code to select which tests to run by default is in ArcanistWorkflow::selectPathsForWorkflow().

Thanks. I can confirm with PHP 8.4.4 after upgrading one of my machines.

In T15990#20841, @aklapper wrote:

Which PHP version do you use?

I fail to reproduce with PHP 8.3 with the given steps: ../arcanist/bin/arc diff --create --help prints the help as expected, with no error.
Which PHP version do you use?

Do you think that this is wontfix? I think yes after https://we.phorge.it/T15281#10042

Any additional tips for the test plan? Maybe hacker @20after4

Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.

Uh!

I see. So, is that functionality already a part of arc diff? In other words, if arc work T123 would have worked exactly the same way as arc work branch-name (by creating a branch that's called either T123 or branch-name), then arc diff would correctly link it?

Yes - it works seamlessly because if the local branch has a task number in it, the diff is automatically linked to that task when you run arc diff

I'd assume that it also links the task and the diff together and optionally allows to close the task automatically on diff land?

Just adding references