Page MenuHomePhorge
Feed Advanced Search

Tue, May 14

revi attached a referenced file: F2191753: image.png.
Tue, May 14, 22:01 · Arcanist, Bug Reports
revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

git config --global core.quotepath false

Tue, May 14, 21:54 · Arcanist, Bug Reports
revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

Posted question at git@vger.kernel.org.

Tue, May 14, 15:35 · Arcanist, Bug Reports

Sat, May 11

revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

I also faced this, tested @ D25623, and found out git format-patch was emitting that result which causes git apply to fail. See this git format-patch example.

Sat, May 11, 09:56 · Arcanist, Bug Reports

Fri, May 10

aklapper closed T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24 as Resolved by committing rARC7f28d7266f81: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 16:13 · Arcanist, Deprecation Notice
aklapper added a revision to T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24: D25632: Fix PHP 8.1 "preg_match(null)" exception for missing Content-Type.
Fri, May 10, 10:04 · Arcanist, Deprecation Notice
revi created T15821: Deprecation notice @ HTTPFutureHTTPResponseStatus.php:24.
Fri, May 10, 07:27 · Arcanist, Deprecation Notice

Wed, May 8

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

Wed, May 8, 08:25 · Discussion Needed, Arcanist

Tue, May 7

valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

At least, please go to GitLab, instead of GitHub, so at least you use Free Software :)

Tue, May 7, 09:08 · Discussion Needed, Arcanist
micax added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Just some (probably final) thoughts on arcanist and phabricator/phorge. After quite a bit of discussion internally, we are moving on to GitHub with our repositories (which were previously stored in another Git server - not Phabricator). But that move also spells the end for our/my 10+ year long use of Phabricator, because when we move to GitHub, we'll also be ditching Phabricator for code reviews.

Tue, May 7, 07:58 · Discussion Needed, Arcanist

Mon, May 6

valerio.bozzolan closed Q136: [BUG] Arcanist exception during the initialization on PHP 8.1 as resolved.
Mon, May 6, 12:34 · Arcanist, Bug Reports
valerio.bozzolan added a comment to Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
Mon, May 6, 12:33 · Arcanist, Bug Reports
valerio.bozzolan added a comment to Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
Mon, May 6, 12:33 · Arcanist, Bug Reports
zhe asked Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
Mon, May 6, 09:54 · Arcanist, Bug Reports

Thu, May 2

valerio.bozzolan moved T15541: "arc browse <file>" does not support Subversion from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Thu, May 2, 18:31 · User-valerio.bozzolan, Arcanist

Tue, Apr 30

valerio.bozzolan triaged T15805: Cannot patch a diff that edits files with non-ascii filenames as High priority.
Tue, Apr 30, 13:09 · Arcanist, Bug Reports

Apr 4 2024

aklapper removed a parent task for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15223: Fix Phorge PhabricatorFactDaemon::run() in PHP 8.2: Passing null to parameter #1 ($string) of type string is deprecated.
Apr 4 2024, 21:39 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

Mar 15 2024

Sten closed T15667: Update PhpunitTestEngine to not call phpunit with --log-json option as Resolved by committing rARC7c5e607e9752: Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use….
Mar 15 2024, 16:09 · Arcanist

Mar 8 2024

valerio.bozzolan added a comment to T15541: "arc browse <file>" does not support Subversion.

Since Subversion allows to checkout just a sub-directory,

Mar 8 2024, 07:12 · User-valerio.bozzolan, Arcanist

Feb 1 2024

aklapper added a revision to T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum): D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Feb 1 2024, 14:12 · Phorge, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a project to T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum): Phorge.
Feb 1 2024, 11:42 · Phorge, Arcanist, User-valerio.bozzolan

Jan 24 2024

valerio.bozzolan added a comment to T15695: Maintain Arcanist in Debian.

Maybe we can wontfix this, and try other more modern approaches like flatpak. Example:

Jan 24 2024, 16:38 · Arcanist, Phorge
valerio.bozzolan added a project to T15695: Maintain Arcanist in Debian: Arcanist.
Jan 24 2024, 16:36 · Arcanist, Phorge

Jan 18 2024

valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jan 18 2024, 14:08 · Phorge Development Tools, Arcanist, User-valerio.bozzolan

Dec 18 2023

valerio.bozzolan closed T15693: Fix Arcanist commit in PHP 8.1 (Subversion), a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Dec 18 2023, 10:37 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15693: Fix Arcanist commit in PHP 8.1 (Subversion) as Resolved by committing rARC6142fcd5264f: Fix Subversion "commit" support in PHP 8.1.
Dec 18 2023, 10:37 · PHP 8 support, Arcanist, User-valerio.bozzolan

Dec 14 2023

valerio.bozzolan added a revision to T15693: Fix Arcanist commit in PHP 8.1 (Subversion): D25498: Fix Subversion "commit" support in PHP 8.1.
Dec 14 2023, 17:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan triaged T15693: Fix Arcanist commit in PHP 8.1 (Subversion) as High priority.
Dec 14 2023, 17:21 · PHP 8 support, Arcanist, User-valerio.bozzolan

Dec 8 2023

deric updated the question details for Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker.
Dec 8 2023, 08:17
deric asked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker.
Dec 8 2023, 08:14

Dec 6 2023

deric asked Q97: Unable to submit patch via arc diff.
Dec 6 2023, 15:24 · Arcanist
l2dy closed Q80: Bug: passing null to strlen in readLocalArcConfig as resolved.
Dec 6 2023, 14:24 · Arcanist

Dec 4 2023

matmarex closed T15544: `arc lint` can't run `jshint` on Windows as Resolved.
Dec 4 2023, 22:04 · Arcanist

Dec 1 2023

speck added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

6 year old in-your-face unreported bugs like these make me wonder how many people use Phabricator/Phorge :-(

It's not many, but this issue would be specific to anyone using Phabricator/Phorge for PHP development, which is likely Phab/Phorge itself is close to 100% of that market. And Phab/Phorge also itself has its own unit testing framework instead of PHPUnit.

Dec 1 2023, 01:00 · Arcanist

Nov 14 2023

Sten added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

As an aside, what do you think of https://github.com/campbsb/example-phorge-php-project - should we put a selection of example projects on https://we.phorge.it, either as individual repos, or one repo containing a bunch of examples, or somewhere in the arcanist repo ?

Nov 14 2023, 11:17 · Arcanist
Sten added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

More complete test case added to D25472 which demonstrates the following error:

Nov 14 2023, 11:10 · Arcanist
Sten added a revision to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option: D25472: Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use junit output rather than json..
Nov 14 2023, 09:57 · Arcanist
valerio.bozzolan added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.
In T15667#14211, @Sten wrote:

how many people use Phabricator/Phorge :-(

Nov 14 2023, 09:38 · Arcanist
Sten added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

I guess the documentation needs an update on page https://we.phorge.it/book/phorge/article/arcanist_lint_unit/ and/or https://we.phorge.it/book/phorge/article/arcanist_new_project/

Nov 14 2023, 09:28 · Arcanist
Sten added a comment to T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.

6 year old in-your-face unreported bugs like these make me wonder how many people use Phabricator/Phorge :-(

Nov 14 2023, 09:22 · Arcanist
Sten claimed T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.
Nov 14 2023, 07:40 · Arcanist
Sten created T15667: Update PhpunitTestEngine to not call phpunit with --log-json option.
Nov 14 2023, 07:40 · Arcanist

Nov 5 2023

l2dy asked Q80: Bug: passing null to strlen in readLocalArcConfig.
Nov 5 2023, 01:38 · Arcanist

Oct 31 2023

l2dy asked Q79: Is arc.land.onto.default configuration deprecated?.
Oct 31 2023, 11:36 · Arcanist

Oct 13 2023

fgaz updated the answer wiki for Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 13 2023, 06:40 · Arcanist
fgaz updated the answer wiki for Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 13 2023, 06:39 · Arcanist
fgaz closed Q77: Arcanist writes cache files to its source directory, and this prevents packaging as resolved.
Oct 13 2023, 06:37 · Arcanist

Oct 3 2023

fgaz added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Nix

Oct 3 2023, 14:17 · Arcanist
valerio.bozzolan added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Just for my curiosity, what lovely package are you crafting? APT? snap? Thanks :)

Oct 3 2023, 14:15 · Arcanist
fgaz updated the question details for Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 3 2023, 14:14 · Arcanist
fgaz asked Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Oct 3 2023, 14:13 · Arcanist

Aug 14 2023

bob closed T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation as Resolved by committing rARCdf6c315ace5f: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Aug 14 2023, 08:58 · PHP 8 support, Arcanist, User-valerio.bozzolan
bob closed T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Aug 14 2023, 08:58 · PHP 8 support, Arcanist, User-valerio.bozzolan

Aug 11 2023

valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Aug 11 2023, 17:01 · Phorge Development Tools, Arcanist, User-valerio.bozzolan

Aug 10 2023

bob added a revision to T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation: D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Aug 10 2023, 16:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
bob created T15599: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in patch operation.
Aug 10 2023, 16:17 · PHP 8 support, Arcanist, User-valerio.bozzolan

Jul 26 2023

valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

Jul 26 2023, 08:27 · Discussion Needed, Arcanist

Jul 24 2023

avivey removed a project from T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: Phorge General/Unknown.
Jul 24 2023, 11:54 · Discussion Needed, Arcanist

Jul 18 2023

valerio.bozzolan closed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans), a subtask of T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, as Resolved.
Jul 18 2023, 10:41 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) as Resolved by committing rARCb996b4799b02: phutil_nonempty_scalar(): don't throw when receiving a boolean scalar.
Jul 18 2023, 10:41 · User-valerio.bozzolan, Arcanist

Jul 11 2023

avivey added a comment to T15281: $HOME missing from commands issued by ExecFuture.

See https://we.phorge.it/T15533#11839 - the env-selecting code in ExecFuture has this logic:

Jul 11 2023, 18:42 · User-valerio.bozzolan, Arcanist

Jul 9 2023

matmarex added a revision to T15544: `arc lint` can't run `jshint` on Windows: D25341: Fix ArcanistExternalLinter on Windows.
Jul 9 2023, 22:55 · Arcanist
matmarex claimed T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:53 · Arcanist
matmarex created T15544: `arc lint` can't run `jshint` on Windows.
Jul 9 2023, 22:38 · Arcanist

Jul 7 2023

valerio.bozzolan updated the task description for T15541: "arc browse <file>" does not support Subversion.
Jul 7 2023, 13:48 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15541: "arc browse <file>" does not support Subversion.

Hi @speck are you still a Mercurial user? Does arc browse <file> work for you? Just for my curiosity

Jul 7 2023, 11:53 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15541: "arc browse <file>" does not support Subversion.
Jul 7 2023, 11:50 · User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15541: "arc browse <file>" does not support Subversion as Low priority.
Jul 7 2023, 11:49 · User-valerio.bozzolan, Arcanist
szotsaki added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

It is on Diffusion > My repository > Selected commit SHA diff page. E.g. https://<domain>/R1:abdcdefgh

Jul 7 2023, 07:47 · Localization, Bug Reports, Diffusion

Jul 6 2023

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I've extracted T15535: Using Differential with plain Git, without requiring Arc for the git-push-for-revision.

Jul 6 2023, 13:29 · Discussion Needed, Arcanist
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan)

Jul 6 2023, 13:14 · Discussion Needed, Arcanist
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Has anyone experimented with using arcanist in a docker container? I see two people have published these on dockerhub:

Jul 6 2023, 10:00 · Discussion Needed, Arcanist
avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

Where exactly are you seeing this error? what page exactly?

Jul 6 2023, 06:47 · Localization, Bug Reports, Diffusion

Jul 5 2023

szotsaki created T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..
Jul 5 2023, 21:27 · Localization, Bug Reports, Diffusion
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan), and it technically can't delete the branch (it can prevent it from being created, but that shows up as an error in the user-side).
But it should be able to at least trigger the flow and provide a URL for the user to click on.

Jul 5 2023, 20:26 · Discussion Needed, Arcanist
Ekubischta added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Could this be solved with a Herald action?

Jul 5 2023, 19:28 · Discussion Needed, Arcanist
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I suspect there's also a problem of motivation: These things are lots of work, and the people who are capable of performing them - people who are comfortable with working with these tools - will not personally benefit from this stuff. The people who would benefit the most are people who are not involved in the project at all...

Jul 5 2023, 16:23 · Discussion Needed, Arcanist

Jul 4 2023

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I think the current actionable steps we can take are:

Jul 4 2023, 18:10 · Discussion Needed, Arcanist
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524

Jul 4 2023, 17:38 · Discussion Needed, Arcanist

Jul 3 2023

Cigaryno updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Jul 3 2023, 19:46 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey added a project to T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file: Phorge Development Tools.
Jul 3 2023, 18:16 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
avivey added a project to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: Discussion Needed.
Jul 3 2023, 18:13 · Discussion Needed, Arcanist
avivey raised the priority of T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file from Normal to High.
Jul 3 2023, 08:43 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jul 3 2023, 08:26 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file from The Celerity unit tests are not automatically run when touching a CSS file to The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jul 3 2023, 08:25 · Phorge Development Tools, Arcanist, User-valerio.bozzolan

Jun 26 2023

aklapper closed T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog as Resolved.
Jun 26 2023, 10:44 · Arcanist, PHP 8 support

Jun 24 2023

avivey assigned T15485: error when running arc liberate after deleting a source file to goddenrich.
Jun 24 2023, 18:21 · Arcanist, Bug Reports
avivey added a comment to T15485: error when running arc liberate after deleting a source file.

I'm unable to reproduce:
I've deleted a file in arcanist library, and ran arc liberate. I got no error message and the __phutil_library_map__.php was updated correctly.

Jun 24 2023, 09:10 · Arcanist, Bug Reports

Jun 22 2023

ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
Jun 22 2023, 15:03 · Arcanist, Differential, Affects-FreeBSD

Jun 19 2023

valerio.bozzolan added a project to T15485: error when running arc liberate after deleting a source file: Arcanist.
Jun 19 2023, 19:44 · Arcanist, Bug Reports
valerio.bozzolan added a revision to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:39 · PHP 8 support, Arcanist, User-valerio.bozzolan

Jun 17 2023

valerio.bozzolan closed T15051: default.pem in Arcanist is out of date - maybe remove it completely? as Resolved.

I think we can consider this as resolved by our dear @jacques since I just tried and it finally works ✨

Jun 17 2023, 15:32 · Arcanist
valerio.bozzolan added a revision to T15051: default.pem in Arcanist is out of date - maybe remove it completely?: D25049: Update the extracted cURL SSL CA bundle.
Jun 17 2023, 15:26 · Arcanist

Jun 16 2023

valerio.bozzolan moved T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from Backlog to 🔥 Trap on the User-valerio.bozzolan board.
Jun 16 2023, 21:38 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

Jun 12 2023

valerio.bozzolan moved T15281: $HOME missing from commands issued by ExecFuture from PingDeath 🌚 to 🔥 Trap on the User-valerio.bozzolan board.
Jun 12 2023, 13:06 · User-valerio.bozzolan, Arcanist
valerio.bozzolan placed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies up for grabs.

I honestly have nothing more to be done here. I would like to set as resolved but there are sub-tasks opened

Jun 12 2023, 07:59 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Jun 12 2023, 07:58 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
avivey triaged T15139: arc edit - util to complete the "edit" button as Wishlist priority.
Jun 12 2023, 07:37 · Arcanist

Jun 10 2023

aklapper closed T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field as Resolved.
Jun 10 2023, 14:36 · Projects, Arcanist, PHP 8 support
avivey added a comment to T15281: $HOME missing from commands issued by ExecFuture.

In T12071, @epriestly mentions that individually selecting env-vars to copy "build[s] some resistance to "Shellshock" class vulnerabilities", which is kind of a compelling argument.

Jun 10 2023, 08:51 · User-valerio.bozzolan, Arcanist