Page MenuHomePhorge
Feed All Stories

Wed, Oct 23

aklapper closed D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Wed, Oct 23, 09:08
aklapper committed rARC99e57a702164: Fix implicitly nullable parameter declarations for PHP 8.4.
Fix implicitly nullable parameter declarations for PHP 8.4
Wed, Oct 23, 09:08
avivey added a comment to D25823: arc browse: add support to Subversion repos.

(The Arguments have a supports feature for these cases - like https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 . Not sure what it actually does, but ๐Ÿคท๐Ÿปโ€โ™‚๏ธ)

Wed, Oct 23, 07:22

Oct 23 2024

keithzg added a comment to D25823: arc browse: add support to Subversion repos.

What if the user used the svn checkout svn+ssh://phab@phorge.example.com/source/myrepo/trunk myRepoOnlyTrunk form - are we still able to find the right target when arc browse lol.txt? Is it a common use-case?

Oct 23 2024, 00:43

Oct 22 2024

valerio.bozzolan planned changes to D25823: arc browse: add support to Subversion repos.

I will add a warning about --branch and better management

Oct 22 2024, 19:56
aklapper added a comment to D25829: Update mimemailparser from May 2011 version to 8.0.4.

For testing, I deployed the latest revision of this proposed patch in our downstream instance and created a task via incoming plain text mail with attachments - seems to still work as expected so no obvious breakage (yet): https://phabricator.wikimedia.org/T377859

Oct 22 2024, 15:16
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

Fix typo

Oct 22 2024, 11:51
aklapper updated the diff for D25829: Update mimemailparser from May 2011 version to 8.0.4.

mimemailparser: Check that PHP mailparse extension is installed

Oct 22 2024, 11:50
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Oct 22 2024, 08:35 ยท PHP 8 support
aklapper closed T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter as Resolved by committing rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 22 2024, 08:35 ยท PHP 8 support
aklapper closed D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 22 2024, 08:35
aklapper committed rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
Oct 22 2024, 08:35
speck accepted D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.

The function name including a negative, โ€œnonemptyโ€, throws me offโ€ฆ

Oct 22 2024, 01:04

Oct 21 2024

aklapper requested review of D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 21 2024, 18:08
aklapper added a revision to T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter: D25830: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 21 2024, 18:08 ยท PHP 8 support
aklapper created T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.
Oct 21 2024, 18:05 ยท PHP 8 support
aklapper closed T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Oct 21 2024, 16:52 ยท PHP 8 support
aklapper closed T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests as Resolved.
Oct 21 2024, 16:52 ยท PHP 8 support
aklapper added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

The email body says Herald added a comment.
The email subject line header says [Changed Project Column] (not [Commented On]).
So I wouldn't say it is incorrectly attributed.
AFAIK there are no Herald rules which trigger a separate email notification on its own (but I agree that the described behavior also has confused me in the past) as Herald rules are always triggered by some other previous action.

Oct 21 2024, 16:50 ยท Herald, Maniphest
aklapper updated the diff for D25828: ManiphestReportController: Separate legacy and synthetic data handling.

Try to make this a separate branch

Oct 21 2024, 14:31
valerio.bozzolan added inline comments to D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Oct 21 2024, 13:59
aklapper added inline comments to D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Oct 21 2024, 08:32
aklapper created T15950: Update copy of external xhprof library.
Oct 21 2024, 08:24
valerio.bozzolan closed T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal as Resolved by committing rARCb3d45c710414: ArcanistBundleTestCase: fix support of non-English environments.
Oct 21 2024, 05:35 ยท User-valerio.bozzolan
valerio.bozzolan closed D25809: ArcanistBundleTestCase: fix support of non-English environments.
Oct 21 2024, 05:35
valerio.bozzolan committed rARCb3d45c710414: ArcanistBundleTestCase: fix support of non-English environments.
ArcanistBundleTestCase: fix support of non-English environments
Oct 21 2024, 05:35
valerio.bozzolan added a comment to T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.

Thanks, little cute Phorge kitten in profile picture <3

Oct 21 2024, 05:34 ยท User-valerio.bozzolan
valerio.bozzolan added inline comments to D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Oct 21 2024, 05:30

Oct 20 2024

syncer added a comment to Q156: How to support project commercialy? (Answer 197).

Hire someone from the Community seems most optimal for many reasons

Oct 20 2024, 21:29
20after4 accepted D25828: ManiphestReportController: Separate legacy and synthetic data handling.

Nice, it's a good step towards cleaning up this mess!

Oct 20 2024, 21:08
20after4 added Q156: How to support project commercialy? (Answer 197).
Oct 20 2024, 21:01
20after4 accepted D25809: ArcanistBundleTestCase: fix support of non-English environments.
Oct 20 2024, 20:43
20after4 accepted D25829: Update mimemailparser from May 2011 version to 8.0.4.

It would be nice to have some unit tests for this but that seems like it might be quite a bit of work to implement.

Oct 20 2024, 20:37
aklapper added a comment to T15766: Cleanup a bit MimeMailParser.

@valerio.bozzolan Proposing to decline in favor of T15940: Update copy of external mimemailparser library / D25829: Update mimemailparser from May 2011 version to 8.0.4.
Let's not increase the diff to upstream (13 years difference) even more.

Oct 20 2024, 17:26 ยท Good Starter Task
aklapper requested review of D25829: Update mimemailparser from May 2011 version to 8.0.4.
Oct 20 2024, 17:22
aklapper added a revision to T15940: Update copy of external mimemailparser library: D25829: Update mimemailparser from May 2011 version to 8.0.4.
Oct 20 2024, 17:22
mainframe98 accepted D25809: ArcanistBundleTestCase: fix support of non-English environments.

Confirmed on KDE on Debian 12, everything set to Dutch: LC_ALL evaluates to nl_NL.UTF-8. Fails before applying this change, succeeds afterwards.

Oct 20 2024, 16:56
mainframe98 added a comment to T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.

I can reproduce this (KDE on Debian 12, everything set to Dutch: LC_ALL evaluates to nl_NL.UTF-8). diff returns localized output, but doesn't when using LC_ALL=C.

Oct 20 2024, 16:55 ยท User-valerio.bozzolan
valerio.bozzolan added a comment to T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.

Has anybody a terminal with non-English environment and that obtains a non-English output with this command?

Oct 20 2024, 12:25 ยท User-valerio.bozzolan
valerio.bozzolan added a comment to D25809: ArcanistBundleTestCase: fix support of non-English environments.

Thank you for trying. Let's continue the "how to reproduce" discussion in the bug report T15927

Oct 20 2024, 12:21
avivey added Q156: How to support project commercialy? (Answer 196).
Oct 20 2024, 10:00
avivey added a comment to Q153: php-fpm memory leak.

If it's the daemons that are having problems, you can probably see in the /daemons/ dashboard which tasks are causing problems, and narrow it down from there.

Oct 20 2024, 09:05

Oct 19 2024

aklapper updated the task description for T15940: Update copy of external mimemailparser library.
Oct 19 2024, 15:12
aklapper added a comment to D25828: ManiphestReportController: Separate legacy and synthetic data handling.

ARRRGH, I locally did this on master branch instead of a dedicated branch. Sorry, it's been a while!

Oct 19 2024, 11:00
aklapper added a comment to D25828: ManiphestReportController: Separate legacy and synthetic data handling.

For context, the ManiphestTransaction table in my installation has >10mio entries so some charts do not render but time out. One approach could be Materialized Views but I don't see how that's feasible given the "Project" tag parameter coming into play (and having thousands of project tags in my installation), so my vague followup idea for my installation is to completely disable the code which handles the legacy data only (as creating the modern data does not rely on querying the ManiphestTransaction table), and thus deliberately ignore ancient legacy data from before 2018 for the sake of performance. That's easier to achieve when the upstream spaghetti code doesn't constantly switch between handling legacy and modern/synthetic data.

Oct 19 2024, 10:49
aklapper requested review of D25828: ManiphestReportController: Separate legacy and synthetic data handling.
Oct 19 2024, 10:47
keithzg added a comment to D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.

For what it's worth I've applied this to my personal instance which tracks master, and I've foisted it on my work instance too---ostensibly tracking stable there, but ;)

Oct 19 2024, 04:07

Oct 18 2024

20after4 added a comment to Q153: php-fpm memory leak.
  1. Can you add a swap file to allow memory usage above 8gb? This will have poor performance but it may allow repo processing to continue.
  2. Can you tell if there is a repo which is still importing? Normal day to day repo tracking shouldnโ€™t require tons of ram so the only situation that I can imagine needing this much ram is importing a large repository.
Oct 18 2024, 17:37
chris accepted D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 18 2024, 12:52
chris accepted D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 18 2024, 12:52
chris accepted D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 18 2024, 12:50
aklapper edited the content of Next Up.
Oct 18 2024, 12:20
aklapper closed T15047: Officially raise minimum required PHP version to 7.2 as Resolved by committing rP23a49eb403c9: Bump PHP version requirement from 5.2.3 to 7.2.25.
Oct 18 2024, 12:20 ยท Phorge
aklapper closed T15047: Officially raise minimum required PHP version to 7.2, a subtask of T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated, as Resolved.
Oct 18 2024, 12:20 ยท PHP 8 support
aklapper closed D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Oct 18 2024, 12:20
aklapper committed rP23a49eb403c9: Bump PHP version requirement from 5.2.3 to 7.2.25.
Bump PHP version requirement from 5.2.3 to 7.2.25
Oct 18 2024, 12:20
โ€ข s.quinn added a comment to Q153: php-fpm memory leak.

What is the normal memory usage for the update daemon during the repository update? It seems to be peaking around 8GB per process for our repositories. Maybe I need to add more RAM, i.e. 32 GB to satisfy this, but that's not easy on AWS.

Oct 18 2024, 11:19
โ€ข s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Oct 18 2024, 11:13
avivey added a comment to Q153: php-fpm memory leak.

Repository update is based on how recent the last commit is, but that's only for collecting the list of commits to analyze.
But that should be done in the Daemons, which should at least recover nicely and not break the web side of the application. I don't know if they should be running as php or php-fpm.

Oct 18 2024, 06:44

Oct 17 2024

โ€ข s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Oct 17 2024, 15:22
โ€ข s.quinn added a comment to Q153: php-fpm memory leak.

OK, not the monitoring issue.

Oct 17 2024, 15:22
โ€ข s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Oct 17 2024, 15:02
โ€ข s.quinn added Q153: php-fpm memory leak (Answer 195).
Oct 17 2024, 15:02
โ€ข s.quinn reopened Q153: php-fpm memory leak.
Oct 17 2024, 14:56
nhg159083 added a watcher for Trusted Contributors: nhg159083.
Oct 17 2024, 13:25

Oct 16 2024

Iniquity added a comment to Update From Phabricator.

@Iniquity - Problem solved by removing that sentence lol - thanks. Now seems super-freshy

Thanks! :)

Oct 16 2024, 09:35
valerio.bozzolan added a comment to D25773: Fix submitting forms in a new tab using Ctrl+Return.

@BlankEclair Do you want a little help to land this?

Oct 16 2024, 09:25
valerio.bozzolan added a comment to Update From Phabricator.

@Iniquity - Problem solved by removing that sentence lol - thanks. Now seems super-freshy

Oct 16 2024, 09:08
valerio.bozzolan edited the content of Update From Phabricator.
Oct 16 2024, 09:08
valerio.bozzolan added a member for Trusted Contributors: bojan.
Oct 16 2024, 08:53
valerio.bozzolan edited the content of Update From Phabricator.
Oct 16 2024, 08:52
bojan added a comment to Update From Phabricator.

Arcanist is misspelled as "Archanist" in the 3rd step of "Updating" section.

Oct 16 2024, 08:41
valerio.bozzolan added Q157: Retrieving task comments using conduit (Answer 194).
Oct 16 2024, 07:36
sicenul asked Q157: Retrieving task comments using conduit.
Oct 16 2024, 07:19
sicenul attached a referenced file: F195188: image.png.
Oct 16 2024, 07:11

Oct 15 2024

avivey created Blog Post: 2024 Summer Edition.
Oct 15 2024, 16:48
avivey edited the content of Change Log.
Oct 15 2024, 16:42
avivey committed rPd3c0a7edc3fc: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:42
avivey committed rARC05abd055019c: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:37
valerio.bozzolan added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

Uh! Out of curiosity, what does the notification look like in your web notifications?

Oct 15 2024, 06:52 ยท Herald, Maniphest
valerio.bozzolan added a member for Trusted Contributors: keithzg.
Oct 15 2024, 06:51
keithzg closed Q147: How does one get the value of a custom field in a custom field extension? as resolved.
Oct 15 2024, 04:15 ยท Maniphest
keithzg added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

Okay, I got it! For future reference if anyone in a similar situation is stumbling across this and wants a fully working example to go off of, my more-than-a-little-cargo-culted code is currently:

Oct 15 2024, 04:15

Oct 14 2024

keithzg added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

Many thanks, @20after4! That all largely did it; in addition to setting up the object a bit wrong (I knew it was a ManiphestTask instance, but was failing to get the actual object of it), I was also just using essentially my:custom-field rather than std:maniphest:my:custom-field.

Oct 14 2024, 23:07
Tgr updated the task description for T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:10 ยท Herald, Maniphest
Tgr created T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:09 ยท Herald, Maniphest
โ€ข s.quinn closed Q153: php-fpm memory leak as invalid.
Oct 14 2024, 13:44
โ€ข s.quinn added a comment to Q153: php-fpm memory leak.

Appears to be internal monitoring software causing this (not phorge), thanks for the replies.

Oct 14 2024, 13:43
valerio.bozzolan closed Q156: How to support project commercialy? as resolved.
Oct 14 2024, 13:25
valerio.bozzolan updated the answer details for Q156: How to support project commercialy? (Answer 193).
Oct 14 2024, 13:24
valerio.bozzolan added a member for Trusted Contributors: syncer.
Oct 14 2024, 13:13
valerio.bozzolan added Q156: How to support project commercialy? (Answer 193).
Oct 14 2024, 07:16

Oct 10 2024

syncer updated the question details for Q156: How to support project commercialy?.
Oct 10 2024, 23:09
syncer asked Q156: How to support project commercialy?.
Oct 10 2024, 22:48
sirocyl added a comment to T15630: Fix Fonts.

Noting a user complaint (I'm using a mildly hacked-up Phorge to host https://blog.styx-os.org/ - but the font stack is unchanged): https://fe.disroot.org/objects/5d376f6a-0acc-44fc-bd37-31de8630b647

Oct 10 2024, 09:21
avivey awarded T15948: Allow public API access when equivalent public web access exists a Like token.
Oct 10 2024, 06:54 ยท Conduit, Phorge

Oct 9 2024

20after4 added a comment to T15947: Add method to query if user is member of a list of projects.

Maybe express it as allowed by Policy xxx? (Related to T15277)

Oct 9 2024, 18:23 ยท Feature Requests
20after4 added a comment to T15947: Add method to query if user is member of a list of projects.

So essentially this:

Oct 9 2024, 18:17 ยท Feature Requests
20after4 added a comment to T15948: Allow public API access when equivalent public web access exists.

If I were starting today I would probably design the back-end APIs first, then make the web interface derive from those APIs, such that web requests and api requests are not really any different, at least with regard to enforcing access controls.

Oct 9 2024, 18:07 ยท Conduit, Phorge
valerio.bozzolan awarded T15948: Allow public API access when equivalent public web access exists a Mountain of Wealth token.
Oct 9 2024, 14:56 ยท Conduit, Phorge