Paths

Table of Contentst

-
src/applications/files/document/
-
applications/
-
files/
-
document/
2/3
PhabricatorJupyterDocumentEngine.php

Differential D25830

Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
ClosedPublic
Actions

Authored by aklapper on Oct 21 2024, 18:08.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15951: PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter

Commits

rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/PhabricatorJupyterDocumentEngine.php:326]

Closes T15951

Test Plan

See T15951

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Oct 21 2024, 18:08

Owners added a reviewer: O1: Blessed Committers.Oct 21 2024, 18:08

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 21 2024, 18:08

aklapper requested review of this revision.Oct 21 2024, 18:08

Harbormaster completed remote builds in B1607: Diff 2498.Oct 21 2024, 18:08

The function name including a negative, “nonempty”, throws me off…

This revision is now accepted and ready to land.Oct 22 2024, 01:04

Closed by commit rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter. · Explain WhyOct 22 2024, 08:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

files/

document/

PhabricatorJupyterDocumentEngine.php

2 lines

O1: Blessed Committers

Diff 2499

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Show All 37 Lines	if ($id) {
$credential = PassphraseCredential::initializeNewCredential($viewer)		$credential = PassphraseCredential::initializeNewCredential($viewer)
->setCredentialType($type->getCredentialType())		->setCredentialType($type->getCredentialType())
->setProvidesType($type->getProvidesType())		->setProvidesType($type->getProvidesType())
->attachImplementation($type);		->attachImplementation($type);

$is_new = true;		$is_new = true;

// Prefill username if provided.		// Prefill username if provided.
$credential->setUsername((string)$request->getStr('username'));		$credential->setUsername((string)$request->getStr('username'));
		valerio.bozzolanAuthorUnsubmitted Done Inline Actions I honestly don't know why here we use `(string)`. Probably we just want to set an empty default to prevent that case? Anyway I've copy-pasted that switching-off my brain. I have no intention to discuss that now, but it's just nice to mention that I'm confused. valerio.bozzolan: I honestly don't know why here we use `(string)`. Probably we just want to set an empty default…
		aviveyUnsubmitted Not Done Inline Actions I got curios, so I looked it up: https://secure.phabricator.com/D13261#140865 - looks like it's to convert `null` to `''` for the DB schema. I'm not sure if it's still relevant, but there's probably no harm in keeping it. avivey: I got curios, so I looked it up: https://secure.phabricator.com/D13261#140865 - looks like it's…

		// Prefill name if provided.
		$credential->setName((string)$request->getStr('name'));

		// Prefill description if provided.
		$credential->setDescription((string)$request->getStr('description'));
		valerio.bozzolanAuthorUnsubmitted Done Inline Actions I honestly don't kno valerio.bozzolan: I honestly don't kno

if (!$request->getStr('isInitialized')) {		if (!$request->getStr('isInitialized')) {
$type->didInitializeNewCredential($viewer, $credential);		$type->didInitializeNewCredential($viewer, $credential);
}		}
}		}

$errors = array();		$errors = array();

$v_name = $credential->getName();		$v_name = $credential->getName();
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines

Fix PHP 8.1 "strlen(null)" exception rendering JSON file as JupyterClosedPublicActions