Wow you are fast. I was going to create this :D I can reproduce

Commanding to set as abandoned. Thanks again! Well done for your original troubleshooting.

This makes sense.

git rebase master

Tested locally before and after applying this branch, with two users sending messages in a chat room after clicking the speechbubbles icon in top bar and selecting "Persistent Chat", both functionality wise (clicking the bar in the lower right corner) and by inspecting the element in the web browser's developer tools' inspector. Works as expected.

Just as clarification for myself (maybe already obvious to others):

Thanks for working on this! Works pretty well locally. From a quick test of this branch, while being logged out,

• Maniphest Advanced Search: Setting Assigned to to Current Viewer, I get a Login page.
• Diffusion Commits Advanced Search: Setting Authors to Current Viewer, I get a Login page.
• Differential Advanced Search: Setting both Authors and Reviewers to Current Viewer, I get a Login page.
• Differential Advanced Search: Setting Responsible Users to Current Viewer, I get an exception (DifferentialResponsibleDatasource - probably another source to cover here?)

Thanks again Roberto.

My last comment is also because the W3C does not allow to start an identifier with a number:

Should somebody file a ticket for that?

Please evaluate extended names:

Unrelated but, thanks to your patch, we catched a possible micro-optimization. Here that unrelated change:

Thanks again! This looks perfect in the current state of PholioMockEditor, since it's not an EditEngine and since this is not an appropriate moment to learn all the differences between an "Editor" and an "EditEngine" and/or it's not an appropriate moment to do that kind of migration here now (if ever needed).

Maybe "feature" but note the left sidebar, is not anymore connected to the end of the viewport:

Sharing some comments

In T15815#17273, @valerio.bozzolan wrote:

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

fix abstract function visibility, add more PHPDoc

I'm purely setting "Request Changes" to reflect that IMHO this should not get merged until there is an approach to fix T15579 - otherwise in some corner cases this proposed change would create broken URIs.

I'd prefer not to expose this as an always-visible button simply because it takes screen estate on smaller screens.
Maybe an entry Copy Revision Permalink between two separators in the expandable "View Options" dropdown is an option?

For the record: If I replace the entire file with just:

<?php

(that was me, I didn't have git author configured properly from on the system I landed from)

(that was me, I didn't have git author configured properly from on the system I landed from)

arc unit --everything passed. But I don't think this file is covered by tests at all,

Setting high priority since I'm scared :D Feel free to re-tune

I was not aware that we were executing critical business code inside __destruct() automagic calls. Wow!

Had this issue occur elsewhere, so put a general 'fix' for it:

In T15815#17273, @valerio.bozzolan wrote:

Thanks. Completely agree.

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

In D25626#17531, @aklapper wrote:

This seems to also fix http://phorge.localhost/feed/ so it does not only show me about setting high priority on a new task, but instead shows that the task was created? That would be a nice side effect too IMO.

Maybe relevant, from my Postfix logs:

I can confirm this works as expected for the task view itself in e.g. http://phorge.localhost/T1168 . This seems to also fix http://phorge.localhost/feed/ so it does not only show me about setting high priority on a new task, but instead shows that the task was created? That would be a nice side effect too IMO.

Tested this patch on http://phorge.localhost/feed/transactions/ and in the feed at the bottom of http://phorge.localhost/W20 itself.
Also tested changing panel visibility from Public to Admin only and accessing these URIs as an average user.
All working as expected, no explosions.

Thanks. Completely agree.

In T15815#17250, @valerio.bozzolan wrote:

being able to have people running unit tests and see the results in their language was a feature

In T15096#12185, @valerio.bozzolan wrote:

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

(run the full tests, and then count it as my + O1 Accept).

I think the costs of the extra translations are low, but the cost of "the tests are not being translated for developers" are even lower.

I'd be worried that this might break some tests that do relate to translation/extraction, but running arc unit --everything should solve that.

Thanks. To reviewers: maybe relevant, maybe not:

I 100% see the point of avoiding to "waste translators' time", but I also see that completely removing tests is a big choice for upstream: being able to have people running unit tests and see the results in their language was a feature, so we also "waste a feature".

I tested this one-liner as part of the downstream conversation that pppery and I had in https://phabricator.wikimedia.org/T363364, still I would ideally prefer another upstream opinion before accepting this revision as O1.

Re-diff with linting and tests working hopefully

fix "abstract" function name