Thanks. Confirmed reading this:

Nice catch :) Can reproduce. Tested.

cover all known usages, but set as stub

At least, please go to GitLab, instead of GitHub, so at least you use Free Software :)

Something I stumbled upon few months ago (via forgejo): agit-flow[^1]. Maybe worth sharing here -- for teh record? It does have some CLI client (git-repo) but it's optional and push via git push origin HEAD:refs/for/<target-branch>/<session> would trigger the Code Review process, without gerrit's Change-Id hack.

Just some (probably final) thoughts on arcanist and phabricator/phorge. After quite a bit of discussion internally, we are moving on to GitHub with our repositories (which were previously stored in another Git server - not Phabricator). But that move also spells the end for our/my 10+ year long use of Phabricator, because when we move to GitHub, we'll also be ditching Phabricator for code reviews.

lol

After upgrading PHP from 8.1.22 to 8.1.27, problem fixed. Thank you again, bozz.

Thank you, Bozz.

Thanks again for this patch that highlighted the valley and the mountain in a very clear way.

In D25608#17388, @avivey wrote:

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

After a small database inspection, it seems that uploading the picture causes:

I'm currently stuck on this since I'm trying to refactor the functions to support an indications about "I work for everybody" and "I work for only logged-in users" to be able to distinguish the case "The token exists" VS "The token exists but it's not visible" VS "The token does not exist"

Thanks to @waldyrious for the change. Tested. It works.

Thanks for the recommendation, Andre! I conferred with @valerio.bozzolan and he agrees, too. I have updated the patch.

• Use phutil_implode_html() instead of implode()

(Per my last comment)

I can reproduce but the title is so generic that makes this not actionable.

I guess that would imply editing 15-20 *ConduitAPIMethod.php files which currently

$limit = $request->getValue('limit');
if (!$limit) {
  $limit = $this->getDefaultLimit();
}

and add something like

if (!is_int($limit) && !ctype_digit($limit)) {
  throw new Exception(pht('Field "limit" must be an integer value.'));
}

? Hmm.

That's because we applied D25415

Cannot reproduce anymore / fixed?

Lol. I don't know what we should do here. Feel free to wontfix. Probably this is the solution to an unclear issue.

In D25619#17360, @speck wrote:

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

@speck here you can see the described overflowing:

Test for feed: https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php

All described here with screenshot (and now video): T15809

screenies?

Should the conduit handler also check this and throw an exception? Doing so will send back a more informative error to the caller. I did some of this in https://secure.phabricator.com/D21872

Haven't tested yet, I was just trying to document the patch behavior.

Just a question. Does it work for you? Since locally, {#FA8072} still does not work for me.

Thanks!

Add return value (though it seems to make no difference)