Page MenuHomePhorge
Feed All Stories

Apr 25 2025

keithzg added a comment to Q176: The hierarchy of documents is located after the document in the wiki.

Having the wiki's tree of contents on the side would indeed be pretty nice, I gotta say. This is especially the case on the landing pages of a given instance's wiki, at least until it inevitably sprawls to be gigantic ;)

Apr 25 2025, 22:55 · UX
aklapper closed T15582: Allow blocking users as Wontfix.

No clarification why disabling users is not sufficient, thus declining.

Apr 25 2025, 19:41 · Clarification Needed
aklapper updated the diff for D25972: Remove non-existing min-device-pixel-ratio CSS syntax.

git rebase master

Apr 25 2025, 15:56
aklapper closed D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Apr 25 2025, 15:52
aklapper committed rPdfe8539c6a0f: Remove IE6/7 non-standard "_zoom" CSS workaround.
Apr 25 2025, 15:52
pppery closed D25959: Simplify project regex further.
Apr 25 2025, 15:39
pppery closed T16028: New project remarkup rule misses some project names as Resolved by committing rP4bd591e4414b: Simplify project regex further.
Apr 25 2025, 15:39 · Bug Reports, Remarkup
pppery committed rP4bd591e4414b: Simplify project regex further.
Apr 25 2025, 15:39
pppery updated the diff for D25959: Simplify project regex further.

Whitespace

Apr 25 2025, 15:37
valerio.bozzolan awarded D25974: Remove IE6/7 non-standard "_zoom" CSS workaround a Yellow Medal token.
Apr 25 2025, 14:58
valerio.bozzolan updated the test plan for D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Apr 25 2025, 14:57
valerio.bozzolan updated the test plan for D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Apr 25 2025, 14:56
valerio.bozzolan accepted D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.

Macro wojak_depressed: DAY N. 89232 STILL CLEANING MICROSOFT SHIT

Apr 25 2025, 14:52
aklapper requested review of D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Apr 25 2025, 11:26
mainframe98 added inline comments to D25959: Simplify project regex further.
Apr 25 2025, 11:23
aklapper requested review of D25973: Correct invalid min-height CSS value.
Apr 25 2025, 09:59
aklapper requested review of D25972: Remove non-existing min-device-pixel-ratio CSS syntax.
Apr 25 2025, 09:54
valerio.bozzolan accepted D25959: Simplify project regex further.

Thanks! also for the freshly added unit test :3 :3

Apr 25 2025, 09:47
valerio.bozzolan updated the test plan for D25963: Phriction: Invalid position actions sidebar when large image on top.
Apr 25 2025, 09:45
valerio.bozzolan accepted D25963: Phriction: Invalid position actions sidebar when large image on top.

Seems fixed now. Thanks :3

Apr 25 2025, 09:45
aklapper closed D25895: Do not create search_documentfield table; update docs.
Apr 25 2025, 08:11
aklapper committed rP7aee92b5e95c: Do not create search_documentfield table; update docs.
Apr 25 2025, 08:11
danielyepezgarces added a comment to T15056: Improve Dark Mode.

Ok, I'll improve it, because I still have a lot to learn about Phorge and its source code, otherwise I'll fix those issues myself

Apr 25 2025, 06:47 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
aklapper added a comment to T15056: Improve Dark Mode.

If there is an issue in Phorge then please provide steps to reproduce in Phorge. Please also strip unneeded full quotes which make comments hard to read. Thanks!

Apr 25 2025, 06:20 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
danielyepezgarces added a comment to T15056: Improve Dark Mode.

T391929 In that task on Wikimedia Phabricator, I had put some issues

image.png (453×298 px, 29 KB)
image.png (264×226 px, 13 KB)

Steps to reproduce the bug:

  • Enable the "Dark Mode (Experimental)" theme in Wikimedia Phabricator.
  • Go to the Phabricator Workboard.
  • Click on any button that has a dropdown menu.

And with these steps you can see the error like the images I have attached

I just checked that the issue can be replicated in the Accessibility workboard, on the Affects-Wikimedia workboard it looks good

image.png (700×298 px, 34 KB)

Apr 25 2025, 05:45 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
danielyepezgarces added a comment to T15056: Improve Dark Mode.

image.png (453×298 px, 29 KB)

@danielyepezgarces: Please always provide clear steps to reproduce something somewhere, in most recent Phorge itself.

Screenshot From 2025-04-21 13-57-21.png (480×428 px, 46 KB)

Apr 25 2025, 05:33 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Apr 24 2025

aklapper edited the content of Next Up.
Apr 24 2025, 22:13
aklapper closed D25971: Remove vendor-prefixed -moz-transition CSS syntax.
Apr 24 2025, 22:12
aklapper committed rP7d6c9285c357: Remove vendor-prefixed -moz-transition CSS syntax.
Apr 24 2025, 22:12
valerio.bozzolan accepted D25971: Remove vendor-prefixed -moz-transition CSS syntax.

yesyes

Apr 24 2025, 21:10
aklapper added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

but the "Regular" Icon Style is not available in the free version and is "Pro only".

I was wrong or misinterpreted. fa-regular-400 as part of the "Free" version exists at https://github.com/FortAwesome/Font-Awesome/tree/6.x/webfonts

Apr 24 2025, 19:24
aklapper requested review of D25971: Remove vendor-prefixed -moz-transition CSS syntax.
Apr 24 2025, 19:09
aklapper edited the content of Next Up.
Apr 24 2025, 18:11
aklapper closed D25970: Remove vendor-prefixed background-clip CSS syntax.
Apr 24 2025, 18:11
aklapper committed rP3fd24004d241: Remove vendor-prefixed background-clip CSS syntax.
Apr 24 2025, 18:11
aklapper updated the diff for D25970: Remove vendor-prefixed background-clip CSS syntax.

git rebase master

Apr 24 2025, 18:10
valerio.bozzolan accepted D25970: Remove vendor-prefixed background-clip CSS syntax.

yesyes

Apr 24 2025, 17:32
aklapper edited the content of Next Up.
Apr 24 2025, 17:01
aklapper committed rP367de18e7902: Remove orphan CSS rules from phui-timeline-view.css.
Apr 24 2025, 17:01
aklapper closed D25918: Remove orphan CSS rules from phui-timeline-view.css.
Apr 24 2025, 17:01
aklapper requested review of D25970: Remove vendor-prefixed background-clip CSS syntax.
Apr 24 2025, 16:57
valerio.bozzolan accepted D25918: Remove orphan CSS rules from phui-timeline-view.css.

sgtm

Apr 24 2025, 15:57
aklapper edited the content of Next Up.
Apr 24 2025, 15:46
aklapper closed D25950: Remove PHP APC support and APC references.
Apr 24 2025, 15:46
aklapper committed rP3f5f18a8d6ee: Remove PHP APC support and APC references.
Apr 24 2025, 15:46
aklapper retitled D25918: Remove orphan CSS rules from phui-timeline-view.css from Fix invalid CSS border value for .phui-timeline-preview-header
Apr 24 2025, 15:26
aklapper updated the diff for D25918: Remove orphan CSS rules from phui-timeline-view.css.

Remove two orphan CSS rules from phui-timeline-view.css

Apr 24 2025, 15:25
aklapper updated the diff for D25918: Remove orphan CSS rules from phui-timeline-view.css.

git rebase master only; still Needs Revision

Apr 24 2025, 15:09
aklapper closed T16002: Hide "Audits" section in Email Preferences when Audit is uninstalled as Resolved by committing rPe45f29d965ad: Hide "Audits" section in Email Preferences when uninstalled.
Apr 24 2025, 11:10 · Bug Reports
aklapper closed D25894: Hide "Audits" section in Email Preferences when uninstalled.
Apr 24 2025, 11:10
aklapper committed rPe45f29d965ad: Hide "Audits" section in Email Preferences when uninstalled.
Apr 24 2025, 11:10
aklapper closed D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Apr 24 2025, 11:10
aklapper committed rP7ff426a2bdfc: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Apr 24 2025, 11:10
aklapper added a comment to D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.

Small question: if an user migrates from gmail.com "less secure apps" to gmail.com "App Passwords", isn't that the very same thing?

Apr 24 2025, 11:09
valerio.bozzolan accepted D25895: Do not create search_documentfield table; update docs.

Tested on a fresh install!

Apr 24 2025, 10:32
valerio.bozzolan updated the test plan for D25895: Do not create search_documentfield table; update docs.
Apr 24 2025, 10:32
valerio.bozzolan accepted D25894: Hide "Audits" section in Email Preferences when uninstalled.

Seems good to make D25503 more complete, thanks!

Apr 24 2025, 09:28
valerio.bozzolan updated the test plan for D25894: Hide "Audits" section in Email Preferences when uninstalled.
Apr 24 2025, 09:28
valerio.bozzolan accepted D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.

Small question: if an user migrates from gmail.com "less secure apps" to gmail.com "App Passwords", isn't that the very same thing?

Apr 24 2025, 09:23
valerio.bozzolan requested changes to D25918: Remove orphan CSS rules from phui-timeline-view.css.

Good news: we can be even more aggressive about that broken CSS rule, since it seems orphan.

Apr 24 2025, 09:16
valerio.bozzolan accepted D25950: Remove PHP APC support and APC references.

lgtm

Apr 24 2025, 08:57
mainframe98 accepted D25772: Projects: improve quality of destroy workflow.
Apr 24 2025, 06:25 · Projects
aklapper closed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Apr 24 2025, 06:08 · PHP 8 support
aklapper closed T15829: Deprecation notice @ PhabricatorStandardPageView.php:630 (missing User-Agent HTTP Header) as Resolved by committing rP372316c99836: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Apr 24 2025, 06:08 · PHP 8 support, Deprecation Notice
aklapper closed D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Apr 24 2025, 06:08
aklapper committed rP372316c99836: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Apr 24 2025, 06:08
aklapper edited the content of Next Up.
Apr 24 2025, 06:05
aklapper closed D25919: Fix invalid CSS cursor value for .phui-oi-grippable.
Apr 24 2025, 06:05
aklapper committed rP3acb080f21a2: Fix invalid CSS cursor value for .phui-oi-grippable.
Apr 24 2025, 06:05
aklapper updated the diff for D25919: Fix invalid CSS cursor value for .phui-oi-grippable.

git rebase master

Apr 24 2025, 06:04
aklapper closed D25958: PHPDoc: Fix @return string for methods which can also return null.
Apr 24 2025, 05:59
aklapper committed rP403fb8a85214: PHPDoc: Fix @return string for methods which can also return null.
Apr 24 2025, 05:59

Apr 23 2025

valerio.bozzolan added inline comments to D25835: Strip surrounding whitespace from project and task titles.
Apr 23 2025, 21:12 · Projects, Maniphest
valerio.bozzolan accepted D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.

sgtm

Apr 23 2025, 21:03
valerio.bozzolan accepted D25919: Fix invalid CSS cursor value for .phui-oi-grippable.

sgtm

Apr 23 2025, 21:02
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

implement documentation tips - thanks - also re-wrap some lines to be under 80 chars

Apr 23 2025, 20:40 · Projects
connorgurney awarded Q177: Should it be easier for non-community-members to submit security reports? a Like token.
Apr 23 2025, 18:35 · Security
mainframe98 added inline comments to D25772: Projects: improve quality of destroy workflow.
Apr 23 2025, 17:34 · Projects
aklapper closed D25953: PHPDoc: Replace invalid "key" and "value" types.
Apr 23 2025, 14:38
aklapper committed rARC9454fa21da41: PHPDoc: Replace invalid "key" and "value" types.
Apr 23 2025, 14:38
aklapper closed D25954: PHPDoc: Correct marker in one class header.
Apr 23 2025, 14:37
aklapper committed rP6a0e70d7163c: PHPDoc: Correct marker in one class header.
Apr 23 2025, 14:37
aklapper closed D25952: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:37
aklapper committed rPe31c3041faec: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:37
20after4 awarded rARC4db5dc25e4e8: PHPDoc: Replace invalid "obj" with "object" a Mountain of Wealth token.
Apr 23 2025, 14:37
aklapper closed D25951: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:36
aklapper committed rARC4db5dc25e4e8: PHPDoc: Replace invalid "obj" with "object".
Apr 23 2025, 14:36
20after4 closed T15961: Should we adopt modern PHP type hints in Phorge source code? as Resolved.
Apr 23 2025, 14:34 · Phorge Development Tools, Discussion Needed
valerio.bozzolan moved T16042: Embedded videos are disproportionately huge from Backlog to Feature Requests on the Remarkup board.

P.S. I wonder... what happens if we expose the width/height here. But probably just touching that would be enough. Still, patch welcome 👍

Apr 23 2025, 13:45 · User-valerio.bozzolan, Feature Requests, Remarkup
valerio.bozzolan added projects to T16042: Embedded videos are disproportionately huge: Feature Requests, User-valerio.bozzolan.

Thanks. Yes. I can reproduce. Relevant documentation:

Apr 23 2025, 13:40 · User-valerio.bozzolan, Feature Requests, Remarkup
Daimona created T16042: Embedded videos are disproportionately huge.
Apr 23 2025, 13:28 · User-valerio.bozzolan, Feature Requests, Remarkup
valerio.bozzolan added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

Thaanks @20after4 - I would say: be bold and mark as resolved to get eternal glory 👍 half year of discussion is probably enough and everybody seems happy about this.

Apr 23 2025, 13:20 · Phorge Development Tools, Discussion Needed
Daimona awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Apr 23 2025, 13:09 · Comments
Daimona awarded T15202: Show confirmation dialog also when closing tab if content changed a Yellow Medal token.
Apr 23 2025, 13:07 · Wikimedia Hackathon 2025, Maniphest, User-valerio.bozzolan, UX
valerio.bozzolan accepted D25953: PHPDoc: Replace invalid "key" and "value" types.

yesyes

Apr 23 2025, 13:05
valerio.bozzolan accepted D25951: PHPDoc: Replace invalid "obj" with "object".

yesyes

Apr 23 2025, 13:04
valerio.bozzolan accepted D25952: PHPDoc: Replace invalid "obj" with "object".

yesyes

Apr 23 2025, 13:03
valerio.bozzolan accepted D25954: PHPDoc: Correct marker in one class header.

yesyes

Apr 23 2025, 13:03
valerio.bozzolan accepted D25958: PHPDoc: Fix @return string for methods which can also return null.

yesyes

Apr 23 2025, 13:02
valerio.bozzolan added a comment to D25772: Projects: improve quality of destroy workflow.

Hi @mainframe98 - I still see your block. Do you like the new documentation now? 👍

Apr 23 2025, 12:57 · Projects