This project is now abandonware without you. 😆

Gents, you’re both nothing short of geniuses

Gents, you’re both nothing short of geniuses—fixed before I’d even blinked! Thanks. Will look at fixing it permanently in T15513.

Fix was reverted for now as it had bad side effects.

Oh boy. Thanks

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

Eventually please try reverting this change in your local copy:

Tip: activate DarkConsole and check requests there 👍

Thanks! Appreciate the answer.

That's almost a year old. Time to update.

Automagically deploying the latest unexpectedly faulty commit may make this instance unusable, thus likely not latest stable.

Thanks. I also encourage in not following the mentioned implementation, and not only because they have problems with deleted files (interesting) but also because that solution is verticalized on Wikimedia Commons, and nowadays a "modern" embedder system should probably just use the OEmbed protocol that is quite flexible and would support out of the box an incredible amount of websites, potentially including Wikimedia Commons, with relatively few amount of code, than supporting every single website in the universe.

From checking the network requests when I load an unrelated page and the dialog appears, I can see a POST request to /conpherence/edit/1/ which returns the dialog. I've attached both the request and the response, with light redactions, to P48 and P49.

Can confirm that this appears on all commands rather than just unit, so have renamed the task accordingly.

I guess I should add a big This is untested banner here

Don't check twice for account status; already covered by query parameter

Clean my local dir from other experiments

Triaged this as normal as I don’t think it’s anything urgent, but I personally love it - very helpful when you have lots of files! LGTM in principle.

In T15056#21737, @danielyepezgarces wrote:

T391929 In that task on Wikimedia Phabricator, I had put some issues

Very helpful - thanks!

I have already spent some time implementing types for a few of the widely used utility functions in rARC src/utils/utils.php (like id(), mpull(), newv(), etc..). I will make an effort to get it in shape and submit a diff for review in the near future.

I see no reason not to pursue this. Does anyone else?

This has now been fixed by rPcadc00d744eb which reverts rPfd6118bfa601.

@avivey is right... you should add the button where the remarkup code block is created. The remarkup tests should be edited and the markup of the button added in every txt file testing the code block!

In D25966#25761, @mturdus wrote:

In D25966#25739, @bekay wrote:

First of all: you should create the copy button server side. Ideally inside the remark rule for creating a code block. There you can attach the ressources too. And you can add sigils to the button. Javelin uses sigils to attach behaviors and listen to events.

I'm still creating the button via javascript because if I do if on server side I may break some remarkup unit tests ...

In D25966#25739, @bekay wrote:

First of all: you should create the copy button server side. Ideally inside the remark rule for creating a code block. There you can attach the ressources too. And you can add sigils to the button. Javelin uses sigils to attach behaviors and listen to events.

javascript replaced with javelin stuff