Updating D25382: Update commit accordingly to comments

In D25382#11307, @bob wrote:

Do you mean ?
...

Right... I also quickly tested with Conduit: On http://phorge.localhost/conduit/method/maniphest.search/ entering integer values like 12 or 91 in the fields before, after, limit and this one-liner doesn't show an exception anymore. And same for older http://phorge.localhost/conduit/method/maniphest.query/ and the fields limit and offset there - no exceptions.

Do you mean ?

I tested this without finding any nuclear implosion. Thanks!

Tweaks per review

Forgot the celerity thing

Added .device-desktop to some selectors as requested

In D25305#10771, @valerio.bozzolan wrote:

Can you share a nice A/B test on Microsoft Windows to upload?

I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.

arc lint
arc unit

In D25374#10923, @Matthew wrote:

Please fix unit errors

@ncoker See T15586 instead

I finally managed to lost track: This got already fixed in D25370.

Please wait more feedback from avivey, but I wanted to say that I tested this and I love it

Yeah why not. asd

Thanks for this change that looks absolutely reasonable.

how about something like:

thank you @ncoker, but:

1. This is not a task to discuss specific errors when trying to run on php 8, and
2. We don't expect arcanist to work on php 8 yet

Maybe also something for this topic!
We update php yesterday on our WSL2 (Ubuntu 22.04) clients to 8.1.22 and pulled the latest arcanist from git after the commit
Now we facing this problem on starting arcanist:

This seems totally backward compatible to me

Thanks for this. I need a double-check since I'm quite scared by the background of this root problem but fortunately this seems to have just one occurrence, the one you are fixing.

I love this change, I've looked inside the logic and it seems very correct to me,

Yeah bob this change was already accepted, and now it's super-accepted. This change is adorable, thanks!

and of course after this round I got an additional RuntimeException: ctype_digit(): Argument of type int will be interpreted as string in the future to also tackle

Check for scalar instead of string as the passed value can also be an integer

...and wrong. Needs to check for a scalar instead because with a custom Date field I get: Call to phutil_nonempty_string() expected null or a string, got: int.

Another on when displaying a maniphest with a lot of comments :

Concerning the dashbord's big pannel :

In workboard, when a maniphest's is drag and dropped, available triggers information windows is broken.

In workboard, when maniphest's edit button style is broken on mouse over.

I've updated the celerity map, let me know if I've the green light to land the revision!

Updating D25384: Update celerity map

I'll do it next time, I always do my best to serve my master !

That should be easy given all files until this week… is all doomed. <_<.

You could also try deleting the files from db using bin/remove, which will at least remove them from limbo... assuming you know which files are missing their data.

Hey, the result of the commands:

Sorry for the late reply; was busy IRL.

D25386 and D25387 provide the big "do not crash on deprecation warning", and are probably enough to declare "experimental support for php 8.2" on their own.