Query: All Stories

Unify type-checking for `setHref()` type methods

Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector()

	Include stories about projects I am a member of.

There are, in total, 3 call-sites to setErrorListener - in for the daemons, one for dark-console, and one (PhutilErrorLog) that lives in arcanist but is only used by the SSHD scripts.

Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom…

Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step…

Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan

Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth…

Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential

Replace dedicated Commit Field with an existing one

Minimal fix to the issue as discussed...

I've replaced it with DifferentialRevertPlanCommitMessageField, anyway - that one already has all the required stuff.

Simply adding a FIELDKEY adds Test: to the title of a new diff, but the full fix of making DifferentialTestCommitMessageField a DifferentialCommitMessageCustomField doesn't

Unfortunately, that fix adds the word "Test:" to the title of any new diff. I'm trying to find an existing field that can make the test work, or else find another creative solution.

The test-field gets picked up automatically because we pick all fields. It's missing FIELDKEY, so arc-diff doesn't work at all, and if we add FIELDKEY it shows up as the first field in the arc-diff form.

I have a fix, but can't create it. Will need manually applying to the server:

Please also manually run this

Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!

In workboard, empty column's drop zone is a little bit 'agressive' isn't it ?

Updating D25383: Removing useless fallback string definition when calling idx

Gotcha. So

isset() is safer when pulling things out of arrays.
phutil_non_empty_string() provides for stricter parameter checking as it demands the array value is set, even if set to null.

Thanks! Interestingly you fixed an incomplete fix since D25128

Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors

Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error

Fix PHP 8.1 trim(null) exception in ./bin/diviner generate

tl;dr: I like phutil_nonempty_string($map['query']) better if we know $map['query'] is defined, and phutil_nonempty_string(idx($map, 'query')) otherwise.

Gentle reminder that this has been waiting review for a while now...

All Stories
Use Results
Edit Query
Hide Query

Aug 12 2023

Aug 11 2023

Aug 10 2023

All StoriesUse ResultsEdit QueryHide Query

Aug 12 2023

Aug 11 2023

Aug 10 2023

All Stories
Use Results
Edit Query
Hide Query