Added cross-platform default fonts
ClosedPublic
Actions

Authored by vedranmiletic on Sep 22 2021, 23:00.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15049: Segoe UI Symbol provides bad user experience

Commits

rPf8ffa393c442: Added cross-platform default fonts

Summary

system-ui is provided by modern browsers as a cross-platform default font. Using this font was a controversial choice back in 2017. because it did not address i18n well and therefore it was removed from Bootstrap twbs/bootstrap#22377. However, it was added back in Bootstrap v5 twbs/bootstrap#30561 since it got better over time.

Fixes T15049.

Test Plan

Tested locally for now.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25021

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 88
Build 88: arc lint + arc unit

Event Timeline

vedranmiletic created this revision.Sep 22 2021, 23:00

Owners added a reviewer: O1: Blessed Committers.Sep 22 2021, 23:00

Herald added subscribers: valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptSep 22 2021, 23:00

vedranmiletic requested review of this revision.Sep 22 2021, 23:00

This revision only adds cross-platform default fonts and doesn't remove any of the existing ones.

Could you describe in more detail what this change is doing? - Because I am not familiar with celerity, I did read through https://secure.phabricator.com/book/phabdev/article/celerity/ for some background.

And specifically, does this impact any other browsers other than the one you mentioned having an issue? (e.g. Will this revision change any fonts on any other platforms where this problem does not exist?)

Apologies for the late response, my open source work has been on the sidelines for some time.

In D25021#838, @Ekubischta wrote:

Could you describe in more detail what this change is doing? - Because I am not familiar with celerity, I did read through https://secure.phabricator.com/book/phabdev/article/celerity/ for some background.

Celerity is automatically regenerated when files are changed. The important changes are in the other files.

And specifically, does this impact any other browsers other than the one you mentioned having an issue? (e.g. Will this revision change any fonts on any other platforms where this problem does not exist?)

The idea here is, instead of picking arbitrary fonts, is to go for the platform recommendations (basically what Bootstrap is doing) while only minimally changin the set of existing fonts used. Let's go one by one:

-apple-system - Apple's system font
system-ui - cross-platform and cross-browser standard for specifying the system font, supported by modern browsers, selects Segoe UI on Windows and whatver font you use on Linux (DejaVu Sans, Ubuntu, Fira Sans)
BlinkMacSystemFont - older specification for system font on Mac, doesn't exist on other platforms
'Segoe UI' etc. - if Windows browser you use doesn't know about system-ui