Seems fixed now. Thanks :3
Feed All Stories
Fri, Apr 25
Fri, Apr 25
valerio.bozzolan accepted D25963: Phriction: Invalid position actions sidebar when large image on top.
Do not create search_documentfield table; update docs
danielyepezgarces added a comment to T15056: Improve Dark Mode.
Ok, I'll improve it, because I still have a lot to learn about Phorge and its source code, otherwise I'll fix those issues myself
aklapper added a comment to T15056: Improve Dark Mode.
If there is an issue in Phorge then please provide steps to reproduce in Phorge. Please also strip unneeded full quotes which make comments hard to read. Thanks!
danielyepezgarces added a comment to T15056: Improve Dark Mode.
T391929 In that task on Wikimedia Phabricator, I had put some issues
Steps to reproduce the bug:
- Enable the "Dark Mode (Experimental)" theme in Wikimedia Phabricator.
- Go to the Phabricator Workboard.
- Click on any button that has a dropdown menu.
And with these steps you can see the error like the images I have attached
I just checked that the issue can be replicated in the Accessibility workboard, on the Affects-Wikimedia workboard it looks good
danielyepezgarces added a comment to T15056: Improve Dark Mode.
@danielyepezgarces: Please always provide clear steps to reproduce something somewhere, in most recent Phorge itself.
Thu, Apr 24
Thu, Apr 24
Remove vendor-prefixed -moz-transition CSS syntax
aklapper added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.
I was wrong or misinterpreted. fa-regular-400 as part of the "Free" version exists at https://github.com/FortAwesome/Font-Awesome/tree/6.x/webfonts
aklapper requested review of D25971: Remove vendor-prefixed -moz-transition CSS syntax.
Remove vendor-prefixed background-clip CSS syntax
aklapper updated the diff for D25970: Remove vendor-prefixed background-clip CSS syntax.
git rebase master
Remove orphan CSS rules from phui-timeline-view.css
aklapper requested review of D25970: Remove vendor-prefixed background-clip CSS syntax.
Remove PHP APC support and APC references
aklapper retitled D25918: Remove orphan CSS rules from phui-timeline-view.css from Fix invalid CSS border value for .phui-timeline-preview-header
aklapper updated the diff for D25918: Remove orphan CSS rules from phui-timeline-view.css.
Remove two orphan CSS rules from phui-timeline-view.css
aklapper updated the diff for D25918: Remove orphan CSS rules from phui-timeline-view.css.
git rebase master only; still Needs Revision
Hide "Audits" section in Email Preferences when uninstalled
aklapper committed rP7ff426a2bdfc: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Diviner: Configuring Outbound Mail: Remove incorrect Gmail references
aklapper added a comment to D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Tested on a fresh install!
valerio.bozzolan updated the test plan for D25895: Do not create search_documentfield table; update docs.
Seems good to make D25503 more complete, thanks!
valerio.bozzolan updated the test plan for D25894: Hide "Audits" section in Email Preferences when uninstalled.
valerio.bozzolan accepted D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Small question: if an user migrates from gmail.com "less secure apps" to gmail.com "App Passwords", isn't that the very same thing?
valerio.bozzolan requested changes to D25918: Remove orphan CSS rules from phui-timeline-view.css.
Good news: we can be even more aggressive about that broken CSS rule, since it seems orphan.
aklapper committed rP372316c99836: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header
Fix invalid CSS cursor value for .phui-oi-grippable
aklapper updated the diff for D25919: Fix invalid CSS cursor value for .phui-oi-grippable.
git rebase master
aklapper committed rP403fb8a85214: PHPDoc: Fix @return string for methods which can also return null.
PHPDoc: Fix @return string for methods which can also return null
Wed, Apr 23
Wed, Apr 23
valerio.bozzolan added inline comments to D25835: Strip surrounding whitespace from project and task titles.
valerio.bozzolan accepted D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.
implement documentation tips - thanks - also re-wrap some lines to be under 80 chars
connorgurney awarded Q177: Should it be easier for non-community-members to submit security reports? a Like token.
mainframe98 added inline comments to D25772: Projects: improve quality of destroy workflow.
PHPDoc: Replace invalid "key" and "value" types
PHPDoc: Correct marker in one class header
PHPDoc: Replace invalid "obj" with "object"
20after4 awarded rARC4db5dc25e4e8: PHPDoc: Replace invalid "obj" with "object" a Mountain of Wealth token.
PHPDoc: Replace invalid "obj" with "object"
valerio.bozzolan moved T16042: Embedded videos are disproportionately huge from Backlog to Feature Requests on the Remarkup board.
P.S. I wonder... what happens if we expose the width/height here. But probably just touching that would be enough. Still, patch welcome 👍
valerio.bozzolan added projects to T16042: Embedded videos are disproportionately huge: Feature Requests, User-valerio.bozzolan.
Thanks. Yes. I can reproduce. Relevant documentation:
valerio.bozzolan added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.
Thaanks @20after4 - I would say: be bold and mark as resolved to get eternal glory 👍 half year of discussion is probably enough and everybody seems happy about this.
Daimona awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Daimona awarded T15202: Show confirmation dialog also when closing tab if content changed a Yellow Medal token.
valerio.bozzolan accepted D25958: PHPDoc: Fix @return string for methods which can also return null.
valerio.bozzolan added a comment to D25772: Projects: improve quality of destroy workflow.
Hi @mainframe98 - I still see your block. Do you like the new documentation now? 👍
valerio.bozzolan updated the task description for T16041: Harbormaster Build Plan: improve input "Depends On".
valerio.bozzolan changed the visibility for F3675059: Harbormaster Build Plan - Depends On field - highlight meme.jpg.
valerio.bozzolan added a cover image to T16041: Harbormaster Build Plan: improve input "Depends On".
valerio.bozzolan added inline comments to D25968: Mail Notifications: Do not CC disabled user accounts.
20after4 updated the answer wiki for Q175: Instant messaging not working, disconnected.
20after4 added a comment to Q175: Instant messaging not working, disconnected.
valerio.bozzolan updated the answer wiki for Q175: Instant messaging not working, disconnected.
Tue, Apr 22
Tue, Apr 22
connorgurney added a project to T15018: Make Harbormaster more generally usable and extendable: Connor Gurney.
connorgurney updated the answer wiki for Q175: Instant messaging not working, disconnected.
connorgurney added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
This project is now abandonware without you. 😆
valerio.bozzolan updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
valerio.bozzolan added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Gents, you’re both nothing short of geniuses
connorgurney added a comment to T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room.
Gents, you’re both nothing short of geniuses—fixed before I’d even blinked! Thanks. Will look at fixing it permanently in T15513.
aklapper placed T15513: Cannot edit Conpherence rooms on mobile up for grabs.
Fix was reverted for now as it had bad side effects.
aklapper reopened T15513: Cannot edit Conpherence rooms on mobile as Open by committing rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".