Page MenuHomePhorge
Feed All Stories

Today

valerio.bozzolan accepted D25976: Remove an unneeded condition in PHUITimelineEventView.php.
Sun, Apr 27, 19:10
aklapper added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

FYI I pasted the list of the 341 different FA icons used by Phorge as of 2025-04-24 (excluding the list of all icons in PHUIIconView::getIcons()) in P50

Sun, Apr 27, 17:16
aklapper created P50 FontAwesome icons used on 2025-04-24, excluding the list of all items in PHUIIconView::getIcons().
Sun, Apr 27, 17:15
aklapper closed T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine() as Resolved by committing rP35e233345cd6: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sun, Apr 27, 17:11
aklapper closed D25975: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sun, Apr 27, 17:11
aklapper committed rP35e233345cd6: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()
Sun, Apr 27, 17:11
aklapper requested review of D25978: Fix wrong argument count in numerous calls' signatures.
Sun, Apr 27, 16:17
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

Argh, PEBKAC, right. Thanks!

[acko@fedora phorge (master *$|u=)]$ ./bin/storage upgrade
Target                          Error
phabricator_paste.paste.mailKey Surplus
Sun, Apr 27, 15:46
mainframe98 added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

FontAwesome doing the freemium thing makes me sad, and I'm worried about misinterpreting their license (e.g., I think the fa-regular is not part of free, but is available on the GH repo for paying customers.)

Sun, Apr 27, 13:54
mainframe98 added a comment to D25900: Remove the onboard "mailKey" from Paste.

Works for me: (on rPdfe8539c6a)

Sun, Apr 27, 13:42
avivey added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

All these options make me want to just go with Sprites (See "Tokens" and "Authentication" in https://we.phorge.it/uiexample/view/PHUIIconExample/).

Sun, Apr 27, 13:32
mainframe98 added a comment to T16035: Update embedded copy of Font Awesome 4.7.0.

I can reproduce with the embedded copy of FontAwesome. I cannot reproduce if I use Fork Awesome 1.2. Switching over as a stopgap is a potential solution, especially because it offers SVG support, which can pave the way for a native-SVG replacement.

Sun, Apr 27, 12:53
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

@mainframe98: Does ./bin/lipsum generate pastes work as expected for you? I'm seeing errors here:

 OOPS  Generator ("Pastes") was unable to generate an object.
#1364: Field 'mailKey' doesn't have a default value
Sun, Apr 27, 12:40
aklapper requested review of D25977: PHPDoc: Correct some param types.
Sun, Apr 27, 11:24
aklapper requested review of D25976: Remove an unneeded condition in PHUITimelineEventView.php.
Sun, Apr 27, 10:56

Yesterday

20after4 accepted D25975: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sat, Apr 26, 22:53
20after4 added a comment to T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().

PhabricatorSearchDocument::isInnoDBFulltextEngineAvailable() could be completely removed and this class could instead check the DB software version via mysqli::get_server_info and PDO::getAttribute(PDO::ATTR_SERVER_VERSION) ?
I guess that's a topic for a separate task though...?

Sat, Apr 26, 21:55
aklapper added a comment to T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().

Now that rP7aee92b5e95cfc11059e9ff8788e5e53dc88e84d is merged (plus realizing that shouldUseMySQLSearchEngine() is only called in https://we.phorge.it/source/phorge/browse/master/src/applications/config/check/PhabricatorMySQLSetupCheck.php;7aee92b5e95cfc11059e9ff8788e5e53dc88e84d$106, plus seeing rP48a34eced28d82b77eb840d05702daffb8e3ddbb), maybe PhabricatorSearchDocument::isInnoDBFulltextEngineAvailable() could be completely removed and this class could instead check the DB software version via mysqli::get_server_info and PDO::getAttribute(PDO::ATTR_SERVER_VERSION) ?
I guess that's a topic for a separate task though...?

Sat, Apr 26, 20:38
aklapper requested review of D25975: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sat, Apr 26, 20:34
aklapper added a revision to T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine(): D25975: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sat, Apr 26, 20:34
aklapper added a comment to T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().

Quick and dirty way to test: Insert this in a random place (output listed after the // ):

$services = PhabricatorSearchService::getAllServices();
foreach ($services as $service) {
  phlog(get_class($service));                   // 'PhabricatorSearchService'
  phlog($service->getDisplayName());            // 'MySQL'
  phlog($service->getEngine());                 // Object PhabricatorFerretFulltextStorageEngine
  if ($service->getEngine() instanceof
      PhabricatorFerretFulltextStorageEngine) {
    phlog('yesh');                              // 'yesh'
  }
}
Sat, Apr 26, 20:31
aklapper updated the task description for T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().
Sat, Apr 26, 20:06
valerio.bozzolan closed Q169: Reflecting diff progress on task status as resolved.
Sat, Apr 26, 13:56
valerio.bozzolan marked Q169: Reflecting diff progress on task status (Answer 210) as hidden.
Sat, Apr 26, 13:56
vabocharov added a comment to Q176: The hierarchy of documents is located after the document in the wiki.

The sublevels of the tree can be made hidden, and they can be revealed when clicking on a specific parent. And if the user expands the tree to a large size, then it is worth limiting the maximum size of the panel and showing a vertical scroll when the maximum is reached.

Sat, Apr 26, 08:41 · UX

Fri, Apr 25

keithzg added a comment to Q176: The hierarchy of documents is located after the document in the wiki.

Having the wiki's tree of contents on the side would indeed be pretty nice, I gotta say. This is especially the case on the landing pages of a given instance's wiki, at least until it inevitably sprawls to be gigantic ;)

Fri, Apr 25, 22:55 · UX
aklapper closed T15582: Allow blocking users as Wontfix.

No clarification why disabling users is not sufficient, thus declining.

Fri, Apr 25, 19:41 · Clarification Needed
aklapper updated the diff for D25972: Remove non-existing min-device-pixel-ratio CSS syntax.

git rebase master

Fri, Apr 25, 15:56
aklapper closed D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Fri, Apr 25, 15:52
aklapper committed rPdfe8539c6a0f: Remove IE6/7 non-standard "_zoom" CSS workaround.
Remove IE6/7 non-standard "_zoom" CSS workaround
Fri, Apr 25, 15:52
pppery closed D25959: Simplify project regex further.
Fri, Apr 25, 15:39
pppery closed T16028: New project remarkup rule misses some project names as Resolved by committing rP4bd591e4414b: Simplify project regex further.
Fri, Apr 25, 15:39 · Bug Reports, Remarkup
pppery committed rP4bd591e4414b: Simplify project regex further.
Simplify project regex further
Fri, Apr 25, 15:39
pppery updated the diff for D25959: Simplify project regex further.

Whitespace

Fri, Apr 25, 15:37
valerio.bozzolan awarded D25974: Remove IE6/7 non-standard "_zoom" CSS workaround a Yellow Medal token.
Fri, Apr 25, 14:58
valerio.bozzolan updated the test plan for D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Fri, Apr 25, 14:57
valerio.bozzolan updated the test plan for D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Fri, Apr 25, 14:56
valerio.bozzolan accepted D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.

Macro wojak_depressed: DAY N. 89232 STILL CLEANING MICROSOFT SHIT

Fri, Apr 25, 14:52
aklapper requested review of D25974: Remove IE6/7 non-standard "_zoom" CSS workaround.
Fri, Apr 25, 11:26
mainframe98 added inline comments to D25959: Simplify project regex further.
Fri, Apr 25, 11:23
aklapper requested review of D25973: Correct invalid min-height CSS value.
Fri, Apr 25, 09:59
aklapper requested review of D25972: Remove non-existing min-device-pixel-ratio CSS syntax.
Fri, Apr 25, 09:54
valerio.bozzolan accepted D25959: Simplify project regex further.

Thanks! also for the freshly added unit test :3 :3

Fri, Apr 25, 09:47
valerio.bozzolan updated the test plan for D25963: Phriction: Invalid position actions sidebar when large image on top.
Fri, Apr 25, 09:45