Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

In D25844#22553, @valerio.bozzolan wrote:

I hope you won't send me a lawyer

do you really think I could afford one

@3tayesh Please don't do that again.

git rebase origin/master

lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer

I tried to prepare a unit test but it's not working. But yes the patch itself seems to work thanks

(Sorry I cannot test now) Does the test plan work with just this?

Nice question avivey. We could always disable this but maybe "newcomer admins" may not try to click it, so with more confusion from the other (Dark) Side.

Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.

Is the extension still maintained? While there is no extension store yet, it's possible to host repositories here. https://we.phorge.it/w/docs/extensions/phactory/

Add the newlline

this unfortunately caused T15963: LDAP over TLS is broken :/

(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)

Double slam accept

Simplify return of validateRealName() as proposed by Valerio

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

sgtm. Thanks :) just that comment

Thanks for catching that! Amend in new PhutilNumber()

Finally got a reproducer URI in downstream:

• Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
• Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).

In D25696#22447, @valerio.bozzolan wrote:

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Yes maniphest.edit is the modern way to do it.

Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.

Thanks for the comment

Works on my machine!

Thanks :)

Also update the PhpDoc accordingly

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)