Page MenuHomePhorge

"Delete Repository" button: it's a bit scaring (always active)
Closed, ResolvedPublic

Description

This is a follow-up from this interesting question:

{Q160}

That question reports that the Delete Repository button is always active, and this can be indeed perceived as a scary thing.

Fortunately, who can access that button really does nothing. I mean, really nothing, since that button just shows a popup with some info.

Current situation

image.png (898×1 px, 143 KB)

See the Delete Repository always enabled.

Historical context

Before this change, that button was always disabled :D

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php;3069ef41662d916ea57d254b10491d6e852d8d46$159

Then, was... always enabled.

Proposed solution

From a security point of view, that button could remain always active, since it really does nothing.

  1. But, that button should be disabled, just like any other admin button in the page, if you cannot edit the repository.
  2. Moreover, probably, if you still want to click that disabled button, you should still be allowed to see the related information message, just because it's informative and it does nothing wrong.