I'd love to see better steps to reproduce something somewhere. :-/ I cannot even find e.p.p. or epp. somewhere in the Finnish translations anymore...
Feed All Stories
Feb 16 2025
Feb 16 2025
aklapper added a comment to D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.
Cigaryno updated the test plan for D25873: Fix overlapping elements in Phame for >1791px width.
Cigaryno changed the visibility for Q160: Is it possible to delete repositories as normal user?.
aklapper added a comment to D25873: Fix overlapping elements in Phame for >1791px width.
I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)
aklapper updated the test plan for D25873: Fix overlapping elements in Phame for >1791px width.
aklapper updated the diff for D25873: Fix overlapping elements in Phame for >1791px width.
Fix unaligned elements by changing margin-left: -200px to -200px for div.phui-document-content and for full-size images
aklapper updated the summary of D25873: Fix overlapping elements in Phame for >1791px width.
waldyrious updated the task description for T15644: Support backticks in inline and block code by wrapping with multiple backticks.
aklapper updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
git rebase master
aklapper updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
./bin/celerity map as this touches a JS file
aklapper retitled D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset from T15064: PHP8 related corrections
aklapper added a comment to D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.
@mturdus: Could you land this one please, or would you like any help? Thanks!
mainframe98 added a comment to D25859: PhabricatorLiskDAO: Fragment serializer cache by class.
aklapper added a comment to D25835: Strip surrounding whitespace from project and task titles.
@valerio.bozzolan: Would you like to give this a (hopefully) final review? TIA!
aklapper requested changes to D25872: Implements arc work for git workflow.
Setting Request Changes per the small review comments so far (as I am looking at https://we.phorge.it/differential/query/all/ and it helps to see correct statuses)
Thanks for the patch! I can confirm that after applying the patch, on PHP 8.3 I can successful create the initiative http://phorge.localhost/I4 (and I get an unrelated PHP 8.1 deprecation warning about strlen(): Passing null to parameter #1 in src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php:19)
aklapper updated the summary of D25859: PhabricatorLiskDAO: Fragment serializer cache by class.
aklapper retitled D25883: Add "Understanding Application Transaction Editors" article to Diviner from Preliminary documentation for transaction editors.
This is impressive, thanks for writing this up! I don't have enough expertise to comment on the "Edit Phases", however all in all this looks super helpful for technical understanding!
Confirming that this works as expected. I took the liberty to expand the commit message to also include the current error message.
aklapper updated the summary of D25882: Unbreak the creation of Packages Versions.
amybones requested review of D25883: Add "Understanding Application Transaction Editors" article to Diviner.
Feb 15 2025
Feb 15 2025
mainframe98 requested review of D25882: Unbreak the creation of Packages Versions.
aklapper added inline comments to D25878: Project archival dialog: Mention affected Herald rule conditions.
pppery added inline comments to D25878: Project archival dialog: Mention affected Herald rule conditions.
mainframe98 requested review of D25881: Fix packages base uri and introduce a console for that base uri.
aklapper requested review of D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
aklapper updated the summary of D25879: Fix editing Conpherence rooms on mobile.
aklapper requested review of D25879: Fix editing Conpherence rooms on mobile.
mainframe98 awarded D25878: Project archival dialog: Mention affected Herald rule conditions a Like token.
aklapper added a comment to T15996: Notify about affected Herald rule conditions when archiving a project tag.
With D25878 applied, dialog for folks who can use Herald:
aklapper requested review of D25878: Project archival dialog: Mention affected Herald rule conditions.
avivey added a comment to D25877: Mention on landing page that Phorge is a community fork of Phabricator.
I've deployed it (https://www.phorge.it/)
Cigaryno updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
Cigaryno edited reviewers for D25877: Mention on landing page that Phorge is a community fork of Phabricator, added: Blessed Committers; removed: O1: Blessed Committers.
taavi moved T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) from Backlog to Deprecation Notices on the PHP 8 support board.
Cigaryno requested review of D25877: Mention on landing page that Phorge is a community fork of Phabricator.
Feb 14 2025
Feb 14 2025
Cigaryno added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
aklapper added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
Cigaryno added inline comments to D25876: People Profile Menu: Move "Badges" item lower in panel list.
valerio.bozzolan accepted D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
You're fast. lol I approve because life is too short.
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
null as fast as possible
valerio.bozzolan awarded D25874: Update installation guide to point to GitHub mirrors a Manufacturing Defect? token.
I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Errm yes, now for real
aklapper updated the diff for D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Short-circuit null check, as rightfully proposed by Valerio
valerio.bozzolan added a comment to D25873: Fix overlapping elements in Phame for >1791px width.
With this I have a regression in /w/. Do you have too?
aklapper requested review of D25876: People Profile Menu: Move "Badges" item lower in panel list.
aklapper added a comment to D25874: Update installation guide to point to GitHub mirrors.
No, because people do not read. The "read-only mirror" Wikimedia and GNOME code repos on GitHub regularly receive pull requests because people do not read anything.
Cigaryno added a comment to D25874: Update installation guide to point to GitHub mirrors.
aklapper added inline comments to D25872: Implements arc work for git workflow.
aklapper added a comment to D25874: Update installation guide to point to GitHub mirrors.
I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?
valerio.bozzolan added a comment to D25874: Update installation guide to point to GitHub mirrors.
Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.
Cigaryno updated the task description for T15513: Cannot edit Conpherence rooms on mobile.
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
Thanks. I'm curious if there's anything up that should not call this with null. Also I'm curious to test with a couple of date filters and custom date fields.
Feb 13 2025
Feb 13 2025
slip accepted D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().
LGTM
slip added a comment to D25868: Fix PHP 8.1 "preg_match(null)" exception for missing User-Agent HTTP Header.
I found this, which suggests that this shouldn't be used for headers. https://secure.phabricator.com/D21862
LGTM!
aklapper renamed T15994: PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time from PHP 8.1 ctype_digit/preg_split exceptions in Phrequent for no date/time to PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time.
aklapper renamed T15994: PHP 8.1 ctype_digit/preg_split exceptions in AphrontFormDateControlValue for no date/time from PHP 8.1 ctype_digit/preg_+split exceptions in Phrequent for no date/time to PHP 8.1 ctype_digit/preg_split exceptions in Phrequent for no date/time.
Cigaryno requested review of D25874: Update installation guide to point to GitHub mirrors.
aklapper updated the summary of D25873: Fix overlapping elements in Phame for >1791px width.
aklapper requested review of D25873: Fix overlapping elements in Phame for >1791px width.
aklapper updated the task description for T15985: Fix UX regression in Phame.
valerio.bozzolan accepted D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.
Thanks! I'm sorry that the execute method has undocumented return.
valerio.bozzolan edited the content of Next Up.