Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?

https://we.phorge.it/T15911#19487

After looking again here:

Initialize key as an empty string as proposed by speck

What Valerio says: As $body can be null, make sure that the rest of this function's code deals with an empty string and not with null

Works locally; this makes sense to me (though I'm surprised it's in an Audit related source file).

Rebase; improve PhpDoc

I hope that something is better than nothing I think. Then we can move if we don't like it.

If Harbormaster is fine I better be fine too, dont want no problems with them for reals

Those were just for the looks, but this is of course personal.
I can remove them if you want.

even simpler

Ah! yes - undo ConpherenceViewController

(I don't get the comment about D25784) thanks for feedback

I guess D25784 shouldn't be mashed up in here thus requesting changes.

Uh!

I fail to reproduce a problem locally (after commenting out entire ArcanistBundleTestCase::testGitRepository due to a different issue I'm running into locally).

In D25807#21516, @valerio.bozzolan wrote:

P.S. try applying D25809 to check if the red unit test becomes green

@mturdus: Thanks for the patch! I tested this locally on a wiki page with a bunch of sections and on http://phorge.localhost/book/phorge/article/remarkup/ ; and on Differential's /D1 where it does not affect the ToC panel (good).

fix typo

Deprecated. See wojak_depressed macro instead - https://we.phorge.it/macro/view/14/

LOL don't take this too seriously but sometime this cursed thing makes sense

From the text body:

IMPORTANT: Share that patch to your DBA <snip>

Moah fixees

Nice catch, thanks! Sorry for this regression in unit tests

Does appear fixed in latest master!

@valerio.bozzolan: Thank you! I know this is super boring work, but it allows PHPStan to show other type/class issues which are currently hidden due to PHPStan barking earlier about that non-standard question mark when parsing those lines. :-/

Abandoning in favor of T15890 and D25774 per previous discussion

Abandoning in favor of T15890 and D25774 per previous discussion

I confirm with my hand on my heart that I've consumed my eyes inspecting every single line to be absolutely sure that this PHPDoc probably has a better meaning and will not cause nuclear implosions.