I'm not able to find #conduit in Matrix mozilla.org homeserver btw

(It needs to be quoted just in we.phorge.it since indeed we have a Tag called Conduit :D Sorry for that)

@valerio.bozzolan If you didn't get an answer, try asking in #conduit. I didn't realize that # needs to be quoted in Remarkup. 😢

@valerio.bozzolan Upstream removed code that enforces $always_visible when $file->getIsProfileImage() is true in PhabricatorFileQuery.php, but I'm afraid that this change may break other things, so I did not apply it here, but on the other hand kept the description of "Image will be Public".

Mention upstream commit

Nice! Thanks

Maybe we can mention the upstream commit, and we can amend to set their author information.

It would be great if Mozilla's team could join forces with Phorge. Would you (the core team) contact them in #conduit on chat.mozilla.org and mozilla.slack.com?

Fix lint warnings

I have reviewed it and made some comments. On a remotely related topic, TLS handshakes are expensive and persistent connections can reduce latency and server load by reusing TLS connections, so maybe we should make it configurable outside of cluster.databases as well.

I wonder if they are aware that Phorge exists and that we are open to contributions :)

I will keep this change in my production for a while:

In D25441#12816, @aklapper wrote:

Where to find the test plan?

This seems reasonable to me. It only adds further information to logs. I suppose there are some paths that could result in showing exception on the client-side but including monogram doesn’t seem concerning/dangerous.

If this is considered too dangerous to merge, I could first test this in downstream for a while.

5. for CSS classes, it seems Phorge would use .collapsible-content instead of camel case

Follow review tips

In D25459#13138, @speck wrote:

Would there be a bunch of these lying around?

Ah! Thanks! I was not aware that it was a common practice:

the prefix was added to have arcanist/phorge indication. So, if we use just $ it's better to remove it.

• Adjust message per code review suggestion

Would there be a bunch of these lying around?

Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context.

I've tested this locally with:

Premising that I love your new list of PHIDs:

I cannot double-accept but I like this even more

git rebase master
arc lint
arc unit

Basically, it works :D

Tested, it works, thanks :) Just feel free to follow the suggestion

Remove "'hidden' => true," line from javelin config - no longer required.

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+

Update the button such that it toggles between 'Open Index' and 'Close Index'

In D25457#13055, @valerio.bozzolan wrote:

Non-blocking stuff:

3. Maybe we should also evaluate this?
   

Rebuild celerity map

Skipping lint because I cannot get javelinsymbols from https://github.com/phacility/javelin/tree/master to compile under OSX
Actually, it's the out-of-support 13 year old libfbjs (from https://github.com/facebookarchive/libfbjs) from it which won't compile.
I recommend javelin linting is dropped, and replaced with a more modern javascript linter.

Move javascript into a Javelin event.
Correct mistake in Javelin documentation.

@chris I believe this is a question for you.

So, we are here if I understand correctly:

even more minor change

Revert indentation changes