Looks good to me.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 18 2023
Aug 18 2023
valerio.bozzolan retitled D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
valerio.bozzolan added inline comments to D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
valerio.bozzolan retitled D25410: Documentation: fix unexisting path sshd_config.phabricator.example from Documentation: fix unexisting path sshd_config.phabricator.example
Since the example file was renamed, this change makes the documentation consistent with it.
Also we added exactly one-space somewhere, to create a super-satisfying indentation
in...
Ouch ! Thanks for reporting ! I'll have a look on UI examples (these pages are really cool !) to improve the proposal !
BTW, I'll be away next week so... This will not move forward right now...
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Great, let's prepare for landing ! BTW, I like your images, espacially this one...
Yeah anyway this looks great
In D25409#11652, @avivey wrote:I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...
Switch to using phutil_nonempty_string
SUPER NICE \o/ THANKS
Tested with and without D25387.
I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...
Sten updated the task description for T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
In D25409#11648, @avivey wrote:phutil_nonempty_string is basically the exact same thing, but with stricter type control
phutil_nonempty_string is basically the exact same thing, but with stricter type control
avivey added a project to T15618: Lots of "Unknown Object"s referenced from revisions: Differential.
Rebrand: Add "path" entries to PlatformSymbols
valerio.bozzolan requested review of D25408: Fix Exception in Chat room when you are not a Participant.
valerio.bozzolan renamed T15497: Exception when viewing incoming Chat room messages, when not in Participants from Exception when opening room to Exception when viewing incoming Chat room messages, when not in Participants.
valerio.bozzolan updated subscribers of T15497: Exception when viewing incoming Chat room messages, when not in Participants.
This happened some minutes ago to our friend @waldyrious and I was able to reproduce it on my local computer. I've attached my reproducing instructions.
valerio.bozzolan triaged T15497: Exception when viewing incoming Chat room messages, when not in Participants as Normal priority.
Maybe to be it consistent with "super-rebranded-product/" :D I don't know
I don't understand why the pht was there - it's a "path", why would it be translated?
valerio.bozzolan added a comment to T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally.
Yeah fixed in D25104
I've just:
aklapper committed rP7c58ea140374: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in….
Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in…
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally as Resolved.
Oops, sorry, I was not on master. I was actually testing out D25079. This is already fixed on master, by @valerio.bozzolan.
aklapper closed T15613: PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rPd84dbf8e27ba: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in….
Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in…
valerio.bozzolan awarded T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally a Cup of Joe token.
valerio.bozzolan renamed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer from PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer to PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.
git rebase master
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
Let's visually mark this as needing still some work
Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:
Great news ! I'll land it right now !
I've tested this in place with my eyes on a friend's laptop with PHP 8.1 in the very same problem
Nice job, my little and cute bob.. OH NO! a super-important regression! all of you minions will be fired soon!1!
valerio.bozzolan updated the name of F336217: Overcard Maniphest regress.png from "image.png" to "Overcard Maniphest regress.png".
valerio.bozzolan updated the test plan for D25403: Improve CelerityDarkModePostprocessor shade colors.
valerio.bozzolan accepted D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.
OK I've found that this is about the legacy Conduit entry point for Paste.
valerio.bozzolan retitled D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create from Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit
valerio.bozzolan added a comment to D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.
I'm not able to trigger that part of the code.
valerio.bozzolan accepted D25406: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit.
Tested with and without a value, thaaanks \o/
valerio.bozzolan closed T15615: Mobile: Differential lines should not be wrapped as Resolved by committing rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Line counters: do not wrap when over 999 on mobile
Aug 17 2023
Aug 17 2023
aklapper closed T15611: Typo "this this server" in user visible strings as Resolved by committing rP3a1f568974f7: Fix typo "this this server".
Fix typo "this this server"
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0