Revision has been updated. Any idea why tests/lint were skipped ?

Updating D25394: Simplify base_uri variable check

Tested, nice thaaaanks, with and without dark mode.

Also this is an excuse to run arc diff again, since tests and lints were skippeds :^)

I just mean that if($something) is usually avoided in Phorge "only and mainly" because if("0") is counter-intuitively false (so "0" is falsy even if it's a non-empty string). But here, we have not that problem, since "0" is a don't care value.

IMO, this depends on the objective of this check, I mean, does this check aim to verify if this parameter is defined or does it aim to verify if this parameter looks valid...
Maybe I'm wrong but I guess that the first option was in mind here else a regex would probable be a better approach since the "1" would be considered as a valid URI whereas "0" would not...

Thaanks bob

Several ideas/leads about the fact you cannot reproduce :

For some reasons I'm not able to trigger this problem, but that seems perfect to me, thaaaaanks

As a minion, I'm only working for the glory of my boss ! :P

Yeah feel free to land this as-is, that was easy-peasy accepted

Updating D25399: Reverting formatUser method prototype

Nice thaaanks

Thanks for the patch suggestion ! Then we can :

Yeah thanks

Thanks for this change! Just a small thing

Looks safe and sensible.

I removed another diff's modification included by Arcanist (there is definitely something about arc command that I'm missing...)

When an fatal exception is triggered :

Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?

Updating D25396: Include updated celerity map file

I was updating the diff when I saw below that function getWebsocketURI may also be affected by a NULL issue :

Updating D25382: Update commit accordingly to comments

One day, we'd like pht() to return an object (non-string), but we'll handle that when we get there I guess.

I removed another commit that Arcanist sent in this diff

Updating D25382: Update commit accordingly to comments

In D25382#11307, @bob wrote:

Do you mean ?
...