Thanks! What do we think about affecting only file upload buttons? Example:

./bin/celerity map

Fix to pass the new test plan

Looks good - I'll try to figure out the failed tests issue(s).

Tested valerio's suggestion -
$is_start = $message !== null;

I currently don't have time to work on this so feel free to improve the diff (via arcanist/bin/arc patch D25296 / arcanist/bin/arc diff --update D25296).

Do you need to be able to replicate it? The fault does seem rather obvious in the code -

Andre already has a diff already out for this...

Changing to the (bool)strlen() to phutil_nonempty_string() is the simplest fix...

D25296 already out for this

Have replicated the fault.

Fixable using coalesce

I agree that Phorge should not fall over because of a deprecation warning.

ran ./bin/celerity map

Ran ./bin/celerity map

@aklapper can you please re-write this ticket with the information required from a feature request?

I think this should be implemented using the getHead() method that's already defined.

I'm reasonably sure that "branches" and "bookmarks" are always strings, but not so much about "base revision" and svn.

Please update the diff.

Probably fine. Most of these probably should be Strings anyway, but some can be integers in SVN or some other strange cases. Maybe we'll get xphast to tell us more about types, like the common Python tools.

You need to run bin/celerity map after changing a css file.

In T15448#9857, @avivey wrote:

In any case, it should be generic - on "search results page", although probably requires each SearchEngine to define the available fields in order to actually support this feature.