I noticed that this unit test is broken:
$ arc unit ./src/infrastructure/parser/__tests__/PhutilPygmentizeParserTestCase.php FAIL PhutilRemarkupEngineTestCase::testEngine Assertion failed, expected values to be equal (at PhutilRemarkupEngineTestCase.php:66): Failed to markup HTML in file 'link-brackets.txt'. Expected: '<p><a href="http://www.zany.com/omg/weird_url,,," class="remarkup-link" target="_blank" rel="noreferrer">http://www.zany.com/omg/weird_url,,,</a></p>' Actual: '<p><a href="http://www.zany.com/omg/weird_url,,," class="remarkup-link remarkup-link-ext" target="_blank" rel="noreferrer">http://www.zany.com/omg/weird_url,,,</a></p>'
Probably that's broken since this change of mine :D
rP349f006904fa: Remarkup: make less internal links open in new tabs
Apologies :D My fault. You know it's not completely intuitive to understand where our unit tests are located, and these tricky creatures don't fire automagically. I discovered just today, randomly running arc unit --everything.