Page MenuHomePhorge

Editing an Archived Project changes its color to Red
Open, LowPublic

Description

Editing an Archived Project sometimes updates the value of "color" field to "red", when the user did not intend to:

e.g. https://we.phorge.it/project/manage/42/#1327

So, it's not possible to manually mark an Archived Project as "color "= "blue", for example.

Event Timeline

This is interesting but note that calculating a suitable background/text contrast is a weird complex separate science and I'm not sure about how to implement this for any generic color

(I'm not exaggerating. I assisted to a very nice WordCamp in Milano where a volunteer talked for one hour about color Accessibility - it completely blasted my brain and I'm still recovering the damage)

I've updated the description.
This isn't about colors; there's a drop-down in Project called "color", and editing sometimes changes the value of that field.

Interestingly, I think this is a feature that automatically marks Archived projects as red ones.

Oh, I see. Yeah it's frustrating. It seems the current situation is "Archived Projects should not enforce a red color".

For me, it's OK that when I archive a Project it assumes a red color, but it's not OK if, when I then set "violet" it just overrides my preference with red.

I see PhabricatorProject#getColor() method probably enforcing red:

https://we.phorge.it/source/phorge/browse/master/src/applications/project/storage/PhabricatorProject.php

It seems this happens since 2014:

https://secure.phabricator.com/rPbe47f2141ab79d950fa1d0efe49aa9a693aad7a0

This issue only happened to me while editing an archived project.

valerio.bozzolan renamed this task from Editing a Project might change its color to Red to Editing an Archived Project changes its color to Red.Apr 19 2023, 13:28
valerio.bozzolan updated the task description. (Show Details)

Probably, the "color change" should be handled as "expanded transaction" - whatever it means - so that it changes only after its related cause (status change to → archived) and not always as long as the current value is archived.