I realize that this my own patch would create a problem for our own downstream glue code, as we create external search links like
http://phorge.localhost/search/?search:primary=true&search:scope=open-tasks&query=%22Wikimedia%5CRdbms%5CDBQueryError%3A%22%20%22Error%22%20%221146%3A%22%20%22Table%22%20%22%27database.table%27%22%20%22doesn%27t%22%20%22exist%22%20%22Function%3A%22%20%22Foo%5CBar%5CBaz%5CBla%3A%3AdoStuff%22%20%22Query%3A%22%20%22DELETE%22%20%22FROM%22%20%22%60function%22#R so I should likely raise the threshold at least.

Nah, LC_ALL=C won't change anything. (My system is already in variants of English.)

Unrelated troubleshooting but what about this?

Mark string as translatable

In D26060#28141, @valerio.bozzolan wrote:

P.S. why is your local unit test failing?

Cannot reproduce:

arc unit src/parser/__tests__/ArcanistBundleTestCase.php

What about landing this?

aaaand now, as I was mumbling aloud, maybe super-nice to move the $xform = definition out the foreach, so, we can move this up

(extra extra bonus bonus point: once it's up, we can find the $xform only if it's necessary)

I am receiving notification emails from @outlook.com addresses just fine.

Actually, at some point it was once possible for non-members of Trusted Contributors to create security tasks. Maybe spammers created spam tasks using the security task form, forcing admins to hide the security task form from non-members of Phactory: Community Projects

I'm still clueless if this could be more optimized somehow given my lack of understanding of the thumbnail software stack. Just saying.

Do as Valerio says

A rather boring git rebase master with no particular exciting new features

Darrn, I also wanted to accept this but somehow closed this tab. Sorry :D

improve PHPDoc thanks to amybones

P.S. why is your local unit test failing?

more

What could go wrong

I'm happy because when a coworker creates a new sub-project "Nonsense Sub", now you can just destroy it (the project, not the coworker lol) and everything is rollbacked as before successfully.

Added a "Limitations" section to clarify what this patch is not about, and clarifying why direct Milestones must be removed (so you don't need to read all the subtasks)

After applying this patch, phpstan throws a bunch of additional output here, like Class PhabricatorAuthPasswordQuery extends generic class PhabricatorCursorPagedPolicyAwareQuery but does not specify its types: R and such. Probably that is totally fine. Just saying, as a phpstan newbie.

If somebody can share the resulting query, to compare it A/B, that would be super

Put minus icon back in

Pasting full unit test output here before garbage collection kicks in:

Assertion failed, expected values to be equal (at PhutilSearchQueryCompilerTestCase.php:303): Function compilation of query: cat title:="Meow Meow"
Expected vs Actual Output Diff
--- Old Value
+++ New Value
@@ -1,18 +1 @@
-Array
-(
-    [0] => Array
-        (
-            [0] => 
-            [1] => and
-            [2] => cat
-        )
-
-    [1] => Array
-        (
-            [0] => title
-            [1] => exact
-            [2] => Meow Meow
-        )
-
-)
-
+false

1. Go to http://phorge.localhost/search/query/advanced/
2. In the Query field enter z a a "a phrase" a a a a ~a -b =foo title:u which includes duplicate values
3. Click Search button

I think the description of this task should be "It's too much difficult to understand what that red thing is about" or something similar

I very much like the new tip,

Don't output "1 Terms" but "x Term(s)"

Before:

It seems that Diviner still runs. Well done both for double-checking.

(about my last phrase I just mean we can have everywhere protected function runWorkflow() and we can avoid to introduce the argument - so for example we could rollback the file PhageExecWorkflow.php 🤯 🤯 🤯 lol )

(You are soo fast woow)

In D26037#27779, @aklapper wrote:

Yes to the idea however a related elephant in the room (IMHO) are those non-standard types like list or map or wild being replaced, no clue if that has any effects on...something™ (Diviner docs? Code?) as I haven't managed to understand the consequences of code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php yet. (Technically speaking map and list seem to be just arrays, indeed.)

Yeah, I've been wanting to put up a codemod diffs that get rid of all the custom types: wild, dict, dictionary, map, etc. None of these are understood by modern phpdoc tooling and while we could configure phpstan to understand them, it's probably easiest to just use whatever everyone else is using, especially because some editor extensions don't have a way to add custom types so we'd be leaving potential contributors at a disadvantage if they don't have phpstan.

Update signature to protected and add missing argument everywhere.

In D26040#27816, @aklapper wrote:

Running phpstan analyse, [...] Method ArcanistWorkflow::runWorkflow() invoked with 1 parameter, 0 required, both in src/workflow/ArcanistWorkflow.php:227. That looks like an improvement indeed.

In D26040#27819, @valerio.bozzolan wrote:

In D26040#27816, @aklapper wrote:

Keeping it protected will throw Protected method PhageExecWorkflow::runWorkflow() overriding public method ArcanistWorkflow::runWorkflow() should also be public.

Exactly what I mean: this patch introduced a public method, but what about just introducing a protected method? and rollback src/phage/workflow/PhageExecWorkflow.php

In Q183#2249, @aklapper wrote:

Hi and welcome, thanks for bringing this up! I guess you could Edit Question and change the View Policy of this Ponder Question to either "Trusted Contributors", or something more restrictive via the "Custom Policy" option, like administrators and subscribers, or such.

Hi and welcome, thanks for bringing this up! I guess you could Edit Question and change the View Policy of this Ponder Question to either "Trusted Contributors", or something more restrictive via the "Custom Policy" option, like administrators and subscribers, or such.