Avoid unneeded duplicate conditions in SQL SELECT queries in the Global Search when there are duplicate search tokens by removing them before constructing the SQL queries.
Closes T16094
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16094: Duplicated Query search tokens also create duplicate SQL query constructs
- Go to http://phorge.localhost/search/query/advanced/ and enter some duplicated search tokens in the Query field. Also try with operators and quoted search tokens.
- Use Dark Console to analyze resulting SQL queries, or check the return values of buildFerretSelectClause(), buildFerretJoinClause(), buildFerretWhereClause() in PhabricatorCursorPagedPolicyAwareQuery.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- dupQuerySearchTerms (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 2050 Build 2050: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 98 ms | PhutilSearchQueryCompilerTestCase::testCompileQueriesWithFunctions Assertion failed, expected values to be equal (at PhutilSearchQueryCompilerTestCase.php:303): Function compilation of query: cat title:="Meow Meow"
Expected vs Actual Output Diff
--- Old Value
| |
| 848 ms | PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed. | |
| 869 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 381 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 377 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| View Full Test Results (1 Failed · 11 Passed) |
Event Timeline
Comment Actions
Pasting full unit test output here before garbage collection kicks in:
Assertion failed, expected values to be equal (at PhutilSearchQueryCompilerTestCase.php:303): Function compilation of query: cat title:="Meow Meow" Expected vs Actual Output Diff --- Old Value +++ New Value @@ -1,18 +1 @@ -Array -( - [0] => Array - ( - [0] => - [1] => and - [2] => cat - ) - - [1] => Array - ( - [0] => title - [1] => exact - [2] => Meow Meow - ) - -) - +false