pair is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers
Read docs; run static code analysis.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- phpdocKillPairType (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 2068 Build 2068: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 823 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'.
#0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(87): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture))
#1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
| |
| 102 ms | ArcanistXMLLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "languages-6.lint-test".
MISSING MESSAGES
Message with severity "error" at "4:1" (XML5)
| |
| 73 ms | AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed. | |
| 90 ms | AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed. | |
| 70 ms | AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed. | |
| View Full Test Results (2 Failed · 189 Passed · 31 Skipped) |
Event Timeline
Comment Actions
Yessss
P.S. file a task for that broken unit test on your computer :D :D ideally finding if with git bisect you discover a regression in Arcanist
arc unit src/parser/__tests__/ArcanistBundleTestCase.php