Differential D26060
PhpDoc: Replace non-standard dict type with array Authored by aklapper on Wed, Jun 4, 07:55.
Details
Make static code analysis more correct (which does not also mean less noisy) by replacing "dict" type in PhpDoc with what they actually are: an array. See D26059 for the Phorge counterpart. Grep and read the code, use static code analysis.
Diff Detail
Event TimelineComment Actions P.S. why is your local unit test failing? Cannot reproduce: arc unit src/parser/__tests__/ArcanistBundleTestCase.php Comment Actions That is a very good question to which I currently have no answer. But it also happens on git master for me so I don't blame my patch for it. :P diff --git a/image_2.png b/image.png copy from image_2.png copy to image.png index 229920a50597be0644f4b994d213fc7042050289..229920a50597be0644f4b994d213fc7042050289 GIT binary patch literal 108 zc%17D@N?(olHy`uVBq!ia0y~yU|<1Z4kiW$2DQnYnhXpKk|nMYCBgY=CFO}lsSJ)O z`AMk?p1FzXsX?iUDV2pMQ*9U+82CJ0978H@B_$}xGO$Q6Fqkkf@+2Od!oa}5;OXk; Jvd$@?2>`UB82A7H literal 108 zc%17D@N?(olHy`uVBq!ia0y~yU|<1Z4kiW$2DQnYnhXpKk|nMYCBgY=CFO}lsSJ)O z`AMk?p1FzXsX?iUDV2pMQ*9U+82CJ0978H@B_$}xGO$Q6Fqkkf@+2Od!oa}5;OXk; Jvd$@?2>`UB82A7H diff --git a/image_2.png b/image_2.png index 229920a50597be0644f4b994d213fc7042050289..69ac76e69fabc49d97339547b91cf748ab703052 GIT binary patch literal 113 zc%17D@N?(olHy`uVBq!ia0y~yU|<1Z4kiW$2DQnYnhXpKk|nMYCBgY=CFO}lsSJ)O z`AMk?p1FzXsX?iUDV2pMQ*9U+7=%4t978H@CH*<yz~IB<Qpmu>!(e=ok=^x?;WY*Z O1_n=8KbLh*2~7Zgh8*nx literal 108 zc%17D@N?(olHy`uVBq!ia0y~yU|<1Z4kiW$2DQnYnhXpKk|nMYCBgY=CFO}lsSJ)O z`AMk?p1FzXsX?iUDV2pMQ*9U+82CJ0978H@B_$}xGO$Q6Fqkkf@+2Od!oa}5;OXk; Jvd$@?2>`UB82A7H Comment Actions Unrelated troubleshooting but what about this? LC_ALL=C arc unit src/parser/__tests__/ArcanistBundleTestCase.php |