Add tooltip for "not" search token tag in Global Search results
ClosedPublic
Actions

Authored by aklapper on Tue, Jun 3, 09:35.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16093: "NOT" search token tag uses an icon and no tooltip in Global Search results

Commits

rPa638bafe5103: Add tooltip for "not" search token tag in Global Search results

Summary

These tags already use colors to differentiate. Use a tooltip for "NOT" query token tags like all the other types also do, because consistency.

Closes T16093

Test Plan

Go to https://we.phorge.it/search/query/advanced/
In the Query field, enter bleh =zsd +a NOT(x) "phrase like this" a -phasa ~amp title:fb "use meo" érr.
Click Search button.
Look at the tags shown for the string Searched For: ....
See that only red tags also use a (minus) icon.
Don't see a minus icon for the red token tag anymore, now get a tooltip for the red token tag.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Jun 3, 09:35

Owners added a reviewer: O1: Blessed Committers.Tue, Jun 3, 09:35

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Jun 3, 09:35

aklapper requested review of this revision.Tue, Jun 3, 09:35

Harbormaster completed remote builds in B2049: Diff 3144.Tue, Jun 3, 09:35

I very much like the new tip,

but please let's keep that icon. That icon is self-explaining and it costs nothing, and it's great for people who are color blind I guess.

(If we love consistency, in the future we may add the same icon under PhutilSearchQueryCompiler::OPERATOR_ABSENT - but not removing from here plz pls ihih)

aklapper retitled this revision from Drop icon for "not" search token tag in Global Search results to Add tooltip for "not" search token tag in Global Search results.Tue, Jun 3, 10:57

aklapper edited the summary of this revision. (Show Details)

aklapper edited the test plan for this revision. (Show Details)

Put minus icon back in

Harbormaster completed remote builds in B2051: Diff 3146.Tue, Jun 3, 10:57

Macro basketslam: Acceeeeept

This revision is now accepted and ready to land.Tue, Jun 3, 11:16

aklapper retitled this revision from Drop icon for "not" search token tag in Global Search results to Add tooltip for "not" search token tag in Global Search results.Tue, Jun 3, 11:43

Closed by commit rPa638bafe5103: Add tooltip for "not" search token tag in Global Search results. · Explain WhyTue, Jun 3, 11:44

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa638bafe5103: Add tooltip for "not" search token tag in Global Search results.