Page MenuHomePhorge

PhpDoc: Replace non-standard dict type with array
AcceptedPublic

Authored by aklapper on Tue, Jun 3, 18:10.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Summary

Make static code analysis more correct (which does not also mean less noisy) by replacing "dict" and "dictionary" types in PhpDoc with what they actually are: an array.
The "dictionary" type is not mentioned in arcanist/src/parser/PhutilTypeSpec.php either, thus no side effects.

See also related discussions in https://we.phorge.it/D26037 and https://we.phorge.it/D26039#27821

Test Plan

Grep and read the code, use static code analysis.

Diff Detail

Repository
rP Phorge
Branch
phpdocKillDictType (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2052
Build 2052: arc lint + arc unit