Profile picture destroy: implement Before-Destruction engine to restore the builtin image
Needs ReviewPublic
Actions

Authored by valerio.bozzolan on Mon, May 19, 22:35.

Details

Reviewers

None

Group Reviewers

Maniphest Tasks

T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one")
T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image)
T16078: PhabricatorFileAttachmentQuery: allow to easily find which users are using a profile picture (allow to only get users, and only get attachments)
T16079: Allow extensions to define "Before Destruction" engines

Summary

When you destroy a profile picture from the command line, now that picture
does not cause anymore a 404 error on your user page. So, you do not see
anymore this problem:

Instead, you just see your exciting builtin image, fully operational.

This will be even more useful in a future when users could be able to delete
their own profile pictures (T15407), and this would happen in a safe way,
without causing any website damages.

This feature works thanks to the brand-new "Before-Destruction Engine",
described in T16079.

Closes T16074
Closes T16078
Ref T15407
Ref T16079

Test Plan

As indicated in T16074, set your profile picture by uploading an image,
then, destroy it from the command line:
You do not see anymore a broken user image, but a lovely builtin image.